* [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode
@ 2019-09-30 15:28 Fabrice Gasnier
2019-10-01 7:10 ` Pierre Yves MORDRET
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Gasnier @ 2019-09-30 15:28 UTC (permalink / raw)
To: wsa, pierre-yves.mordret
Cc: alexandre.torgue, linux-kernel, alain.volmat, linux-i2c,
fabrice.gasnier, linux-stm32, linux-arm-kernel
The slave-interface documentation [1] states "the bus driver should
transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event:
- 'val': backend returns first byte to be sent
The driver currently ignores the 1st byte to send on this event.
Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
[1] https://www.kernel.org/doc/Documentation/i2c/slave-interface
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 266d1c2..0af9219 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1192,6 +1192,8 @@ static void stm32f7_i2c_slave_start(struct stm32f7_i2c_dev *i2c_dev)
STM32F7_I2C_CR1_TXIE;
stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, mask);
+ /* Write 1st data byte */
+ writel_relaxed(value, base + STM32F7_I2C_TXDR);
} else {
/* Notify i2c slave that new write transfer is starting */
i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode
2019-09-30 15:28 [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode Fabrice Gasnier
@ 2019-10-01 7:10 ` Pierre Yves MORDRET
2019-10-15 12:19 ` Fabrice Gasnier
2019-10-21 14:00 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Pierre Yves MORDRET @ 2019-10-01 7:10 UTC (permalink / raw)
To: Fabrice Gasnier, wsa
Cc: alexandre.torgue, linux-kernel, alain.volmat, linux-i2c,
linux-stm32, linux-arm-kernel
Hi,
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thx
On 9/30/19 5:28 PM, Fabrice Gasnier wrote:
> The slave-interface documentation [1] states "the bus driver should
> transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event:
> - 'val': backend returns first byte to be sent
> The driver currently ignores the 1st byte to send on this event.
>
> Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
>
> [1] https://www.kernel.org/doc/Documentation/i2c/slave-interface
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 266d1c2..0af9219 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1192,6 +1192,8 @@ static void stm32f7_i2c_slave_start(struct stm32f7_i2c_dev *i2c_dev)
> STM32F7_I2C_CR1_TXIE;
> stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, mask);
>
> + /* Write 1st data byte */
> + writel_relaxed(value, base + STM32F7_I2C_TXDR);
> } else {
> /* Notify i2c slave that new write transfer is starting */
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode
2019-09-30 15:28 [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode Fabrice Gasnier
2019-10-01 7:10 ` Pierre Yves MORDRET
@ 2019-10-15 12:19 ` Fabrice Gasnier
2019-10-21 14:00 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Fabrice Gasnier @ 2019-10-15 12:19 UTC (permalink / raw)
To: wsa, pierre-yves.mordret
Cc: alexandre.torgue, linux-kernel, alain.volmat, linux-i2c,
linux-stm32, linux-arm-kernel
On 9/30/19 5:28 PM, Fabrice Gasnier wrote:
> The slave-interface documentation [1] states "the bus driver should
> transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event:
> - 'val': backend returns first byte to be sent
> The driver currently ignores the 1st byte to send on this event.
>
> Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
>
> [1] https://www.kernel.org/doc/Documentation/i2c/slave-interface
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
Hi Wolfram, all,
Gentle reminder on this patch.
Thanks in advance !
Best Regards,
Fabrice
> drivers/i2c/busses/i2c-stm32f7.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 266d1c2..0af9219 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1192,6 +1192,8 @@ static void stm32f7_i2c_slave_start(struct stm32f7_i2c_dev *i2c_dev)
> STM32F7_I2C_CR1_TXIE;
> stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, mask);
>
> + /* Write 1st data byte */
> + writel_relaxed(value, base + STM32F7_I2C_TXDR);
> } else {
> /* Notify i2c slave that new write transfer is starting */
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode
2019-09-30 15:28 [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode Fabrice Gasnier
2019-10-01 7:10 ` Pierre Yves MORDRET
2019-10-15 12:19 ` Fabrice Gasnier
@ 2019-10-21 14:00 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2019-10-21 14:00 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: alexandre.torgue, linux-kernel, pierre-yves.mordret,
alain.volmat, linux-i2c, linux-stm32, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 565 bytes --]
On Mon, Sep 30, 2019 at 05:28:01PM +0200, Fabrice Gasnier wrote:
> The slave-interface documentation [1] states "the bus driver should
> transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event:
> - 'val': backend returns first byte to be sent
> The driver currently ignores the 1st byte to send on this event.
>
> Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
>
> [1] https://www.kernel.org/doc/Documentation/i2c/slave-interface
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-21 14:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 15:28 [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode Fabrice Gasnier
2019-10-01 7:10 ` Pierre Yves MORDRET
2019-10-15 12:19 ` Fabrice Gasnier
2019-10-21 14:00 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).