From: Frank Wunderlich <frank-w@public-files.de>
To: Rob Herring <robh@kernel.org>
Cc: Frank Wunderlich <linux@fw-web.de>,
devicetree@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Subject: Aw: Re: [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT bindings to yaml
Date: Thu, 3 Mar 2022 08:04:15 +0100 [thread overview]
Message-ID: <trinity-1ca1f3fd-1eeb-4c8d-a7e2-65851eb8002b-1646291055736@3c-app-gmx-bs69> (raw)
In-Reply-To: <Yh+0B+iKx1gJXXCk@robh.at.kernel.org>
Hi Rob,
thanks for review,
have prepared the changes based on yours and krzysztof comments
https://github.com/frank-w/BPI-R2-4.14/commits/5.17-next-20220225
(just ignore the top 2 commits) i thought i had a size-cells-error, but did not get them again after reverting this part, seems they are fixed by inclusion of the sata-common binding
> Gesendet: Mittwoch, 02. März 2022 um 19:14 Uhr
> Von: "Rob Herring" <robh@kernel.org>
> An: "Frank Wunderlich" <linux@fw-web.de>
> On Tue, Mar 01, 2022 at 04:24:17PM +0100, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > new file mode 100644
> > index 000000000000..cf67ddfc6afb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > @@ -0,0 +1,162 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/ata/ahci-platform.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: AHCI SATA Controller
>
> blank line.
done
> > +description:
> > + SATA nodes are defined to describe on-chip Serial ATA controllers.
> > + Each SATA controller should have its own node.
> > +
> > + It is possible, but not required, to represent each port as a sub-node.
> > + It allows to enable each port independently when dealing with multiple
> > + PHYs.
>
> You need a '|' after 'description' if you want to maintain the
> paragraphs.
ok added | to all multiline descriptions
> > +
> > +maintainers:
> > + - Hans de Goede <hdegoede@redhat.com>
> > + - Jens Axboe <axboe@kernel.dk>
> > +
> > +allOf:
> > +- $ref: "sata-common.yaml#"
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - brcm,iproc-ahci
> > + - marvell,armada-8k-ahci
> > + - marvell,berlin2q-ahci
> > + - const: generic-ahci
> > + - enum:
> > + - brcm,iproc-ahci
> > + - cavium,octeon-7130-ahci
> > + - hisilicon,hisi-ahci
> > + - ibm,476gtr-ahci
> > + - marvell,armada-3700-ahci
> > + - marvell,armada-380-ahci
> > + - snps,dwc-ahci
> > + - snps,spear-ahci
>
> Install yamllint and run 'make dt_binding_check'. It's going to
> complain about the indentation.
you're right, i had no yamllint installed, so i have not seen these indention errors
> > + ahci-supply:
> > + description:
> > + regulator for AHCI controller
> > +
> > + clock-names:
>
> Group with 'clocks'
ok, already done in my tree because of krzysztofs comment
> > + ports-implemented:
> > + $ref: '/schemas/types.yaml#/definitions/uint32'
> > + description:
> > + Mask that indicates which ports that the HBA supports
> > + are available for software to use. Useful if PORTS_IMPL
> > + is not programmed by the BIOS, which is true with
> > + some embedded SoCs.
> > + maxItems: 1
>
> A uint32 is only ever 1 item. Drop.
>
> IIRC, isn't the max here 0xff? Add constraints.
i've found it only set to 0x1 so i have currently set the maximum to 0x1, is this ok?
If some higher value is needed binding needs to be touched...
> > +
> > + reg-names:
> > + maxItems: 1
>
> Group with 'reg'.
ok
> > +patternProperties:
> > + "^sata-port@[0-9a-f]+$":
> > + type: object
>
> additionalProperties: false
ok added to my tree
and needed to add phy-names because some marvell boards using this
arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dt.yaml: sata@540000: sata-port@1: 'phy-names' does not match any of the regexes: 'pinctrl-[0-9]+'
now i have only the marvell-errors about incomplete sata-port subnode (without phy/target-supply) like i mention in the patch...how to proceed with this?
regards Frank
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-03 7:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 15:24 [PATCH v4 0/5] Add sata nodes to rk356x Frank Wunderlich
2022-03-01 15:24 ` [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT bindings to yaml Frank Wunderlich
2022-03-02 9:46 ` Krzysztof Kozlowski
2022-03-02 10:31 ` Aw: " Frank Wunderlich
2022-03-02 10:59 ` Krzysztof Kozlowski
2022-03-02 18:14 ` Rob Herring
2022-03-03 7:04 ` Frank Wunderlich [this message]
2022-03-04 23:37 ` Rob Herring
2022-03-05 10:07 ` Aw: " Frank Wunderlich
2022-03-05 10:19 ` Frank Wunderlich
2022-03-01 15:24 ` [PATCH v4 2/5] arm64: dts: broadcom: Fix sata nodename Frank Wunderlich
2022-03-01 21:29 ` Florian Fainelli
2022-03-01 15:24 ` [PATCH v4 3/5] dt-bindings: Add power-domains property to ahci-platform Frank Wunderlich
2022-03-02 9:46 ` Krzysztof Kozlowski
2022-03-01 15:24 ` [PATCH v4 4/5] dt-bindings: Add rk3568-dwc3-ahci compatible Frank Wunderlich
2022-03-02 9:47 ` Krzysztof Kozlowski
2022-03-01 15:24 ` [PATCH v4 5/5] arm64: dts: rockchip: Add sata nodes to rk356x Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-1ca1f3fd-1eeb-4c8d-a7e2-65851eb8002b-1646291055736@3c-app-gmx-bs69 \
--to=frank-w@public-files.de \
--cc=axboe@kernel.dk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).