From: Frank Wunderlich <frank-w@public-files.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Frank Wunderlich <linux@fw-web.de>,
devicetree@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Rob Herring <robh+dt@kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Subject: Aw: Re: [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT bindings to yaml
Date: Wed, 2 Mar 2022 11:31:38 +0100 [thread overview]
Message-ID: <trinity-80a229fb-42dd-4705-9c55-fe6f3a381a40-1646217098213@3c-app-gmx-bap21> (raw)
In-Reply-To: <6dae47c3-6083-782e-ecab-7be3f0bca0e1@canonical.com>
Hi
> Gesendet: Mittwoch, 02. März 2022 um 10:46 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>
> On 01/03/2022 16:24, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - brcm,iproc-ahci
> > + - marvell,armada-8k-ahci
> > + - marvell,berlin2q-ahci
> > + - const: generic-ahci
> > + - enum:
> > + - brcm,iproc-ahci
>
> This one is already earlier in generic-ahci, so you can skip him here.
OK, i drop it
> > + - cavium,octeon-7130-ahci
> > + - hisilicon,hisi-ahci
> > + - ibm,476gtr-ahci
> > + - marvell,armada-3700-ahci
> > + - marvell,armada-380-ahci
> > + - snps,dwc-ahci
> > + - snps,spear-ahci
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description:
> > + Clock IDs array as required by the controller.
> > + minItems: 1
> > + maxItems: 3
> > +
> > + interrupts:
> > + description:
> > + specifies the interrupt number for the controller.
>
> Skip description, it's obvious.
OK
> > + maxItems: 1
> > +
> > + ahci-supply:
> > + description:
> > + regulator for AHCI controller
> > +
> > + clock-names:
> > + description:
> > + Names of clocks corresponding to IDs in the clock property.
> > + minItems: 1
> > + maxItems: 3
>
> Put the clock-names next to clocks.
had moved them down as they are optional, but ok, i move up
> > +
> > + dma-coherent:
> > + true
>
> New line not needed. "dma-coherent: true"
OK
> > + ports-implemented:
> > + $ref: '/schemas/types.yaml#/definitions/uint32'
> > + description:
> > + Mask that indicates which ports that the HBA supports
> > + are available for software to use. Useful if PORTS_IMPL
> > + is not programmed by the BIOS, which is true with
> > + some embedded SoCs.
> > + maxItems: 1
>
> maxItems are incorrect here, this is not an array.
right, i'll change it
> > +patternProperties:
> > + "^sata-port@[0-9a-f]+$":
> > + type: object
> > + description:
> > + Subnode with configuration of the Ports.
> > +
> > + properties:
> > + reg:
> > + maxItems: 1
> > +
> > + phys:
> > + minItems: 1
>
> maxItems: 1
oh, missed that
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/berlin2q.h>
> > + sata@f7e90000 {
> > + compatible = "marvell,berlin2q-ahci", "generic-ahci";
> > + reg = <0xe90000 0x1000>;
>
> You still have wrong address.
only took the example from the txt, but i guess reg should be <0xf7e90000 0x1000>; ?
will also fix all subjects to
"dt-bindings: ata: ahci-platform: ..."
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-02 10:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 15:24 [PATCH v4 0/5] Add sata nodes to rk356x Frank Wunderlich
2022-03-01 15:24 ` [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT bindings to yaml Frank Wunderlich
2022-03-02 9:46 ` Krzysztof Kozlowski
2022-03-02 10:31 ` Frank Wunderlich [this message]
2022-03-02 10:59 ` Aw: " Krzysztof Kozlowski
2022-03-02 18:14 ` Rob Herring
2022-03-03 7:04 ` Aw: " Frank Wunderlich
2022-03-04 23:37 ` Rob Herring
2022-03-05 10:07 ` Aw: " Frank Wunderlich
2022-03-05 10:19 ` Frank Wunderlich
2022-03-01 15:24 ` [PATCH v4 2/5] arm64: dts: broadcom: Fix sata nodename Frank Wunderlich
2022-03-01 21:29 ` Florian Fainelli
2022-03-01 15:24 ` [PATCH v4 3/5] dt-bindings: Add power-domains property to ahci-platform Frank Wunderlich
2022-03-02 9:46 ` Krzysztof Kozlowski
2022-03-01 15:24 ` [PATCH v4 4/5] dt-bindings: Add rk3568-dwc3-ahci compatible Frank Wunderlich
2022-03-02 9:47 ` Krzysztof Kozlowski
2022-03-01 15:24 ` [PATCH v4 5/5] arm64: dts: rockchip: Add sata nodes to rk356x Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-80a229fb-42dd-4705-9c55-fe6f3a381a40-1646217098213@3c-app-gmx-bap21 \
--to=frank-w@public-files.de \
--cc=axboe@kernel.dk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).