From: Akash Asthana <akashast@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mgautam@codeaurora.org, msavaliy@codeaurora.org
Subject: Re: [PATCH v5 3/3] tty: serial: qcom_geni_serial: Remove sysfs file
Date: Fri, 22 Nov 2019 06:47:19 +0000 [thread overview]
Message-ID: <0101016e91dd7270-2d8fa1f1-48b8-4583-a30c-343ea1c5cdea-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <5dcf0055.1c69fb81.258d1.5380@mx.google.com>
On 11/16/2019 1:15 AM, Stephen Boyd wrote:
> Quoting Akash Asthana (2019-11-15 01:57:48)
>> On 11/14/2019 11:06 PM, Stephen Boyd wrote:
>>> Please update the subject. This patch does more than remove the sysfs
>>> file. "Move loopback support to TIOCM_LOOP"?
>> Ok, I will update this in next version.
>>> Quoting Akash Asthana (2019-11-13 02:49:21)
>>>> Remove code from the driver that create and maintain loopback sysfs node.
>>>> Instead use the ioctl TIOCMSET with TIOCM_LOOP argument to set HW to
>>>> loopback mode.
>>>>
>>>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>>>> ---
>>>> Changes in V5:
>>>> - As per Greg's and Stephen's comment on v4 patch, removed loopback sysfs
>>>> file related code.
>>>>
>>>> drivers/tty/serial/qcom_geni_serial.c | 30 ++++--------------------------
>>>> 1 file changed, 4 insertions(+), 26 deletions(-)
>>>>
>>>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
>>>> index 56dad67..52f5ea2 100644
>>>> --- a/drivers/tty/serial/qcom_geni_serial.c
>>>> +++ b/drivers/tty/serial/qcom_geni_serial.c
>>>> @@ -238,10 +214,14 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport,
>>>> unsigned int mctrl)
>>>> {
>>>> u32 uart_manual_rfr = 0;
>>>> + struct qcom_geni_serial_port *port = to_dev_port(uport, uport);
>>>>
>>>> if (uart_console(uport))
>>>> return;
>>>>
>>>> + if (mctrl & TIOCM_LOOP)
>>>> + port->loopback = MAX_LOOPBACK_CFG;
>>> How does this work? The loopback is supposed to be the max all the time
>>> and not match some qup number or something?
>> port->loopback is unrelated to QUP number. However we have different
>> modes to run loopback test, 1(rx-tx sorted), 2(cts-rts sorted),
>>
>> 3 or Max(rx-tx sorted and cts-rts sorted). In our internal testing we
>> only use mode 3 hence we are initializing port->loopback variable
>>
>> to 3 and eventually it will be written to HW register from set_termios
>> call.
> Ok. Thanks for clarifying. Can you rename this macro to
> RX_TX_CTS_RTS_SORTED? I imagine seeing something like:
>
> /* SE_UART_LOOPBACK_CFG */
> #define RX_TX_SORTED BIT(0)
> #define CTS_RTS_SORTED BIT(1)
> #define RX_TX_CTS_RTS_SORTED RX_TX_SORTED | CTS_RTS_SORTED
>
> or whatever the bit field names really are.
Ok, I will update this is v6.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
prev parent reply other threads:[~2019-11-22 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:49 [PATCH v5 3/3] tty: serial: qcom_geni_serial: Remove sysfs file Akash Asthana
2019-11-14 17:36 ` Stephen Boyd
2019-11-15 9:57 ` Akash Asthana
2019-11-15 19:45 ` Stephen Boyd
2019-11-22 6:47 ` Akash Asthana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101016e91dd7270-2d8fa1f1-48b8-4583-a30c-343ea1c5cdea-000000@us-west-2.amazonses.com \
--to=akashast@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=msavaliy@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).