From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mgautam@codeaurora.org, msavaliy@codeaurora.org,
Akash Asthana <akashast@codeaurora.org>
Subject: Re: [PATCH v5 3/3] tty: serial: qcom_geni_serial: Remove sysfs file
Date: Thu, 14 Nov 2019 09:36:36 -0800 [thread overview]
Message-ID: <5dcd90a4.1c69fb81.757a7.37e8@mx.google.com> (raw)
In-Reply-To: <1573642161-14189-1-git-send-email-akashast@codeaurora.org>
Please update the subject. This patch does more than remove the sysfs
file. "Move loopback support to TIOCM_LOOP"?
Quoting Akash Asthana (2019-11-13 02:49:21)
> Remove code from the driver that create and maintain loopback sysfs node.
> Instead use the ioctl TIOCMSET with TIOCM_LOOP argument to set HW to
> loopback mode.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> Changes in V5:
> - As per Greg's and Stephen's comment on v4 patch, removed loopback sysfs
> file related code.
>
> drivers/tty/serial/qcom_geni_serial.c | 30 ++++--------------------------
> 1 file changed, 4 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 56dad67..52f5ea2 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -238,10 +214,14 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport,
> unsigned int mctrl)
> {
> u32 uart_manual_rfr = 0;
> + struct qcom_geni_serial_port *port = to_dev_port(uport, uport);
>
> if (uart_console(uport))
> return;
>
> + if (mctrl & TIOCM_LOOP)
> + port->loopback = MAX_LOOPBACK_CFG;
How does this work? The loopback is supposed to be the max all the time
and not match some qup number or something?
next prev parent reply other threads:[~2019-11-14 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 10:49 [PATCH v5 3/3] tty: serial: qcom_geni_serial: Remove sysfs file Akash Asthana
2019-11-14 17:36 ` Stephen Boyd [this message]
2019-11-15 9:57 ` Akash Asthana
2019-11-15 19:45 ` Stephen Boyd
2019-11-22 6:47 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dcd90a4.1c69fb81.757a7.37e8@mx.google.com \
--to=swboyd@chromium.org \
--cc=akashast@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=msavaliy@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).