linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] drm/msm: Remove Kconfig default
@ 2019-08-13 14:46 Jordan Crouse
  2019-08-13 14:46 ` [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM Jordan Crouse
  0 siblings, 1 reply; 4+ messages in thread
From: Jordan Crouse @ 2019-08-13 14:46 UTC (permalink / raw)
  To: freedreno
  Cc: linux-arm-msm, Sean Paul, linux-kernel, dri-devel, Rob Clark,
	David Airlie, Daniel Vetter

Remove the default for CONFIG_DRM_MSM and let the user select the driver
manually as one does.

Additionally select QCOM_COMMAND_DB for ARCH_QCOM targets to make sure
it doesn't get missed when we need it for a6xx targets.

v2: Move from default 'm' to no default

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---

 drivers/gpu/drm/msm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 9c37e4d..e9160ce 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -14,11 +14,11 @@ config DRM_MSM
 	select SHMEM
 	select TMPFS
 	select QCOM_SCM if ARCH_QCOM
+	select QCOM_COMMAND_DB if ARCH_QCOM
 	select WANT_DEV_COREDUMP
 	select SND_SOC_HDMI_CODEC if SND_SOC
 	select SYNC_FILE
 	select PM_OPP
-	default y
 	help
 	  DRM/KMS driver for MSM/snapdragon.
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM
  2019-08-13 14:46 [PATCH v2 1/2] drm/msm: Remove Kconfig default Jordan Crouse
@ 2019-08-13 14:46 ` Jordan Crouse
  2019-08-23  6:52   ` Linus Walleij
  0 siblings, 1 reply; 4+ messages in thread
From: Jordan Crouse @ 2019-08-13 14:46 UTC (permalink / raw)
  To: freedreno
  Cc: linux-arm-msm, Bjorn Andersson, Arnd Bergmann, Linus Walleij,
	Marcin Juszkiewicz, Catalin Marinas, Geert Uytterhoeven,
	Leonard Crestez, Enric Balletbo i Serra, Olof Johansson,
	Dinh Nguyen, Miquel Raynal, Krzysztof Kozlowski,
	linux-arm-kernel, Will Deacon, Jagan Teki, Fabrice Gasnier,
	Russell King, Shawn Guo, Simon Horman, Marek Szyprowski,
	Yannick Fertré,
	Maxime Ripard, Alexandre Torgue, linux-kernel, Andy Gross,
	Brian Masney, Frank Rowand, Tony Lindgren, Anson Huang

Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all
ARCH_QCOM enabled defconfigs to restore the previous expected build
behavior.

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---

 arch/arm/configs/multi_v7_defconfig | 1 +
 arch/arm/configs/qcom_defconfig     | 1 +
 arch/arm64/configs/defconfig        | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index b0a0568..12dfdab 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -635,6 +635,7 @@ CONFIG_DRM_ATMEL_HLCDC=m
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_RCAR_LVDS=y
 CONFIG_DRM_SUN4I=m
+CONFIG_DRM_MSM=m
 CONFIG_DRM_FSL_DCU=m
 CONFIG_DRM_TEGRA=y
 CONFIG_DRM_STM=m
diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index 34433bf..02f1e7b 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -147,6 +147,7 @@ CONFIG_REGULATOR_QCOM_SMD_RPM=y
 CONFIG_REGULATOR_QCOM_SPMI=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_DRM=y
+CONFIG_DRM_MSM=m
 CONFIG_DRM_PANEL_SIMPLE=y
 CONFIG_FB=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1cd66cf..4fec7a9 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -531,6 +531,7 @@ CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_SUN4I=m
 CONFIG_DRM_SUN8I_DW_HDMI=m
 CONFIG_DRM_SUN8I_MIXER=m
+CONFIG_DRM_MSM=m
 CONFIG_DRM_TEGRA=m
 CONFIG_DRM_PANEL_SIMPLE=m
 CONFIG_DRM_SII902X=m
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM
  2019-08-13 14:46 ` [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM Jordan Crouse
@ 2019-08-23  6:52   ` Linus Walleij
  2019-08-27  4:49     ` Bjorn Andersson
  0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2019-08-23  6:52 UTC (permalink / raw)
  To: Jordan Crouse, Andy Gross
  Cc: freedreno, MSM, Bjorn Andersson, Arnd Bergmann,
	Marcin Juszkiewicz, Catalin Marinas, Geert Uytterhoeven,
	Leonard Crestez, Enric Balletbo i Serra, Olof Johansson,
	Dinh Nguyen, Miquel Raynal, Krzysztof Kozlowski, Linux ARM,
	Will Deacon, Jagan Teki, Fabrice Gasnier, Russell King,
	Shawn Guo, Simon Horman, Marek Szyprowski, Yannick Fertré,
	Maxime Ripard, Alexandre Torgue, linux-kernel, Brian Masney,
	Frank Rowand, Tony Lindgren, Anson Huang

On Tue, Aug 13, 2019 at 4:46 PM Jordan Crouse <jcrouse@codeaurora.org> wrote:

> Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all
> ARCH_QCOM enabled defconfigs to restore the previous expected build
> behavior.
>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I suppose Andy will pick this up?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM
  2019-08-23  6:52   ` Linus Walleij
@ 2019-08-27  4:49     ` Bjorn Andersson
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2019-08-27  4:49 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Jordan Crouse, Andy Gross, freedreno, MSM, Arnd Bergmann,
	Marcin Juszkiewicz, Catalin Marinas, Geert Uytterhoeven,
	Leonard Crestez, Enric Balletbo i Serra, Olof Johansson,
	Dinh Nguyen, Miquel Raynal, Krzysztof Kozlowski, Linux ARM,
	Will Deacon, Jagan Teki, Fabrice Gasnier, Russell King,
	Shawn Guo, Simon Horman, Marek Szyprowski, Yannick Fertr?,
	Maxime Ripard, Alexandre Torgue, linux-kernel, Brian Masney,
	Frank Rowand, Tony Lindgren, Anson Huang

On Thu 22 Aug 23:52 PDT 2019, Linus Walleij wrote:

> On Tue, Aug 13, 2019 at 4:46 PM Jordan Crouse <jcrouse@codeaurora.org> wrote:
> 
> > Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all
> > ARCH_QCOM enabled defconfigs to restore the previous expected build
> > behavior.
> >
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I suppose Andy will pick this up?
> 

Not sure why, but this patch isn't in any of my mailboxes. So thanks for
the reminder, I've picked it from patchworks for 5.4.

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-27  4:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 14:46 [PATCH v2 1/2] drm/msm: Remove Kconfig default Jordan Crouse
2019-08-13 14:46 ` [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM Jordan Crouse
2019-08-23  6:52   ` Linus Walleij
2019-08-27  4:49     ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).