[PATCH 0/2] Add QMP V3 USB3 PHY support for SC7180

[PATCH 0/2] Add QMP V3 USB3 PHY support for SC7180

[Sandeep Maheswaram]

Add QMP V3 USB3 PHY entries for SC7180 in phy driver and
device tree bindings

Sandeep Maheswaram (2):
  phy: qcom-qmp: Add QMP V3 USB3 PHY support for SC7180
  dt-bindings: phy-qcom-qmp: Add SC7180 QMP phy support

 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 11 +++++++++--
 drivers/phy/qualcomm/phy-qcom-qmp.c                    |  5 ++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

[PATCH 1/2] phy: qcom-qmp: Add QMP V3 USB3 PHY support for SC7180

[Sandeep Maheswaram]

Adding QMP v3 USB3 phy support for SC7180.

Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 091e203..52275c5 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (c) 2017, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
  */
 
 #include <linux/clk.h>
@@ -2118,6 +2118,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
 	}, {
 		.compatible = "qcom,sm8150-qmp-ufs-phy",
 		.data = &sm8150_ufsphy_cfg,
+	}, {
+		.compatible = "qcom,sc7180-qmp-usb3-phy",
+		.data = &qmp_v3_usb3phy_cfg,
 	},
 	{ },
 };
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

[PATCH 2/2] dt-bindings: phy-qcom-qmp: Add SC7180 QMP phy support

[Sandeep Maheswaram]

Add QMP phy entries for SC7180 in device tree bindings.

Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
---
 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
index eac9ad3..369f5b7 100644
--- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
+++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
@@ -15,17 +15,20 @@ Required properties:
 	       "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
 	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
 	       "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845,
-	       "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150.
+	       "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150,
+	       "qcom,sc7180-qmp-usb3-phy" for USB3 QMP V3 phy on sc7180.
 
 - reg:
   - index 0: address and length of register set for PHY's common
              serdes block.
   - index 1: address and length of the DP_COM control block (for
-             "qcom,sdm845-qmp-usb3-phy" only).
+             "qcom,sdm845-qmp-usb3-phy" and "qcom,sc7180-qmp-usb3-phy" only).
 
 - reg-names:
   - For "qcom,sdm845-qmp-usb3-phy":
     - Should be: "reg-base", "dp_com"
+  - For "qcom,sc7180-qmp-usb3-phy":
+    - Should be: "reg-base", "dp_com"
   - For all others:
     - The reg-names property shouldn't be defined.
 
@@ -60,6 +63,8 @@ Required properties:
 			"ref", "ref_aux".
 		For "qcom,sm8150-qmp-ufs-phy" must contain:
 			"ref", "ref_aux".
+		For "qcom,sc7180-qmp-usb3-phy" must contain:
+			"aux", "cfg_ahb", "ref", "com_aux".
 
  - resets: a list of phandles and reset controller specifier pairs,
 	   one for each entry in reset-names.
@@ -88,6 +93,8 @@ Required properties:
 			"ufsphy".
 		For "qcom,sm8150-qmp-ufs-phy": must contain:
 			"ufsphy".
+		For "qcom,sc7180-qmp-usb3-phy" must contain:
+			"phy", "common".
 
  - vdda-phy-supply: Phandle to a regulator supply to PHY core block.
  - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH 2/2] dt-bindings: phy-qcom-qmp: Add SC7180 QMP phy support

[Stephen Boyd]

Quoting Sandeep Maheswaram (2019-10-29 23:55:44)
> Add QMP phy entries for SC7180 in device tree bindings.
> 
> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

Can you convert this binding to YAML? Would make it easier to see what
is applicable to certain compatibles.

> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> index eac9ad3..369f5b7 100644
> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> @@ -15,17 +15,20 @@ Required properties:
>                "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
>                "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
>                "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845,
> -              "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150.
> +              "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150,

Should remove the comma at the end of these lines so they don't have to
change.

> +              "qcom,sc7180-qmp-usb3-phy" for USB3 QMP V3 phy on sc7180.
>  
>  - reg:
>    - index 0: address and length of register set for PHY's common
>               serdes block.
>    - index 1: address and length of the DP_COM control block (for
> -             "qcom,sdm845-qmp-usb3-phy" only).
> +             "qcom,sdm845-qmp-usb3-phy" and "qcom,sc7180-qmp-usb3-phy" only).
>  
>  - reg-names:
>    - For "qcom,sdm845-qmp-usb3-phy":
>      - Should be: "reg-base", "dp_com"
> +  - For "qcom,sc7180-qmp-usb3-phy":
> +    - Should be: "reg-base", "dp_com"
>    - For all others:
>      - The reg-names property shouldn't be defined.

Why is this so complicated? Would be better to just know that index 1 is
dp_com and index 0 is "normal" register base.

>  
> @@ -60,6 +63,8 @@ Required properties:
>                         "ref", "ref_aux".
>                 For "qcom,sm8150-qmp-ufs-phy" must contain:
>                         "ref", "ref_aux".
> +               For "qcom,sc7180-qmp-usb3-phy" must contain:
> +                       "aux", "cfg_ahb", "ref", "com_aux".
>  
>   - resets: a list of phandles and reset controller specifier pairs,
>            one for each entry in reset-names.
> @@ -88,6 +93,8 @@ Required properties:
>                         "ufsphy".
>                 For "qcom,sm8150-qmp-ufs-phy": must contain:
>                         "ufsphy".
> +               For "qcom,sc7180-qmp-usb3-phy" must contain:
> +                       "phy", "common".

Please sort these lists based on compatible string.

>  
>   - vdda-phy-supply: Phandle to a regulator supply to PHY core block.
>   - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.

Re: [PATCH 1/2] phy: qcom-qmp: Add QMP V3 USB3 PHY support for SC7180

[Manu Gautam]

On 10/30/2019 12:25 PM, Sandeep Maheswaram wrote:
> Adding QMP v3 USB3 phy support for SC7180.
>
> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 091e203..52275c5 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Copyright (c) 2017, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
>   */
>  
>  #include <linux/clk.h>
> @@ -2118,6 +2118,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
>  	}, {
>  		.compatible = "qcom,sm8150-qmp-ufs-phy",
>  		.data = &sm8150_ufsphy_cfg,
> +	}, {
> +		.compatible = "qcom,sc7180-qmp-usb3-phy",
> +		.data = &qmp_v3_usb3phy_cfg,

SC7180 has single QMP PHY with each lane dedicated for USB and DP.
USB driver should perform only PHY reset, not the global reset.


>  	},
>  	{ },
>  };

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project