linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] drm/msm: Remove unneeded semicolon
@ 2019-12-14  9:31 zhengbin
  2019-12-14  9:31 ` [PATCH 1/4] drm/msm/hdmi: " zhengbin
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: zhengbin @ 2019-12-14  9:31 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel
  Cc: zhengbin13

zhengbin (4):
  drm/msm/hdmi: Remove unneeded semicolon
  drm/msm/mdp5: Remove unneeded semicolon
  drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c
  drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c

 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c   | 2 +-
 drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c    | 2 +-
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

--
2.7.4


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/4] drm/msm/hdmi: Remove unneeded semicolon
  2019-12-14  9:31 [PATCH 0/4] drm/msm: Remove unneeded semicolon zhengbin
@ 2019-12-14  9:31 ` zhengbin
  2019-12-16 15:48   ` Jordan Crouse
  2019-12-14  9:31 ` [PATCH 2/4] drm/msm/mdp5: " zhengbin
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: zhengbin @ 2019-12-14  9:31 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/msm/hdmi/hdmi_connector.c:104:3-4: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
index 839822d..2ccb55a 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
@@ -101,7 +101,7 @@ static int gpio_config(struct hdmi *hdmi, bool on)

 				gpiod_set_value_cansleep(gpio.gpiod, value);
 			}
-		};
+		}

 		DBG("gpio off");
 	}
--
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/4] drm/msm/mdp5: Remove unneeded semicolon
  2019-12-14  9:31 [PATCH 0/4] drm/msm: Remove unneeded semicolon zhengbin
  2019-12-14  9:31 ` [PATCH 1/4] drm/msm/hdmi: " zhengbin
@ 2019-12-14  9:31 ` zhengbin
  2019-12-16 15:48   ` Jordan Crouse
  2019-12-14  9:31 ` [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c zhengbin
  2019-12-14  9:31 ` [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c zhengbin
  3 siblings, 1 reply; 9+ messages in thread
From: zhengbin @ 2019-12-14  9:31 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:905:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
index 1f48f64..e3c4c25 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
@@ -902,7 +902,7 @@ struct mdp5_cfg_handler *mdp5_cfg_init(struct mdp5_kms *mdp5_kms,
 				major, minor);
 		ret = -ENXIO;
 		goto fail;
-	};
+	}

 	/* only after mdp5_cfg global pointer's init can we access the hw */
 	for (i = 0; i < num_handlers; i++) {
--
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c
  2019-12-14  9:31 [PATCH 0/4] drm/msm: Remove unneeded semicolon zhengbin
  2019-12-14  9:31 ` [PATCH 1/4] drm/msm/hdmi: " zhengbin
  2019-12-14  9:31 ` [PATCH 2/4] drm/msm/mdp5: " zhengbin
@ 2019-12-14  9:31 ` zhengbin
  2019-12-16 15:48   ` Jordan Crouse
  2019-12-14  9:31 ` [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c zhengbin
  3 siblings, 1 reply; 9+ messages in thread
From: zhengbin @ 2019-12-14  9:31 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:741:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 58d5acb..8d4fdc3 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -738,7 +738,7 @@ int dpu_plane_validate_multirect_v2(struct dpu_multirect_plane_states *plane)
 	} else {
 		pstate[R0]->multirect_index = DPU_SSPP_RECT_0;
 		pstate[R1]->multirect_index = DPU_SSPP_RECT_1;
-	};
+	}

 	DPU_DEBUG_PLANE(dpu_plane[R0], "R0: %d - %d\n",
 		pstate[R0]->multirect_mode, pstate[R0]->multirect_index);
--
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c
  2019-12-14  9:31 [PATCH 0/4] drm/msm: Remove unneeded semicolon zhengbin
                   ` (2 preceding siblings ...)
  2019-12-14  9:31 ` [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c zhengbin
@ 2019-12-14  9:31 ` zhengbin
  2019-12-16 15:49   ` Jordan Crouse
  3 siblings, 1 reply; 9+ messages in thread
From: zhengbin @ 2019-12-14  9:31 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:2260:3-4: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index f96e142..0974aa8 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -2257,7 +2257,7 @@ int dpu_encoder_wait_for_event(struct drm_encoder *drm_enc,
 			DPU_ERROR_ENC(dpu_enc, "unknown wait event %d\n",
 					event);
 			return -EINVAL;
-		};
+		}

 		if (fn_wait) {
 			DPU_ATRACE_BEGIN("wait_for_completion_event");
--
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/4] drm/msm/hdmi: Remove unneeded semicolon
  2019-12-14  9:31 ` [PATCH 1/4] drm/msm/hdmi: " zhengbin
@ 2019-12-16 15:48   ` Jordan Crouse
  0 siblings, 0 replies; 9+ messages in thread
From: Jordan Crouse @ 2019-12-16 15:48 UTC (permalink / raw)
  To: zhengbin
  Cc: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel

On Sat, Dec 14, 2019 at 05:31:47PM +0800, zhengbin wrote:
> Fixes coccicheck warning:
> 
> drivers/gpu/drm/msm/hdmi/hdmi_connector.c:104:3-4: Unneeded semicolon

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> index 839822d..2ccb55a 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> @@ -101,7 +101,7 @@ static int gpio_config(struct hdmi *hdmi, bool on)
> 
>  				gpiod_set_value_cansleep(gpio.gpiod, value);
>  			}
> -		};
> +		}
> 
>  		DBG("gpio off");
>  	}
> --
> 2.7.4
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/4] drm/msm/mdp5: Remove unneeded semicolon
  2019-12-14  9:31 ` [PATCH 2/4] drm/msm/mdp5: " zhengbin
@ 2019-12-16 15:48   ` Jordan Crouse
  0 siblings, 0 replies; 9+ messages in thread
From: Jordan Crouse @ 2019-12-16 15:48 UTC (permalink / raw)
  To: zhengbin
  Cc: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel

On Sat, Dec 14, 2019 at 05:31:48PM +0800, zhengbin wrote:
> Fixes coccicheck warning:
> 
> drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:905:2-3: Unneeded semicolon
> 

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
> index 1f48f64..e3c4c25 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
> @@ -902,7 +902,7 @@ struct mdp5_cfg_handler *mdp5_cfg_init(struct mdp5_kms *mdp5_kms,
>  				major, minor);
>  		ret = -ENXIO;
>  		goto fail;
> -	};
> +	}
> 
>  	/* only after mdp5_cfg global pointer's init can we access the hw */
>  	for (i = 0; i < num_handlers; i++) {
> --
> 2.7.4
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c
  2019-12-14  9:31 ` [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c zhengbin
@ 2019-12-16 15:48   ` Jordan Crouse
  0 siblings, 0 replies; 9+ messages in thread
From: Jordan Crouse @ 2019-12-16 15:48 UTC (permalink / raw)
  To: zhengbin
  Cc: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel

On Sat, Dec 14, 2019 at 05:31:49PM +0800, zhengbin wrote:
> Fixes coccicheck warning:
> 
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:741:2-3: Unneeded semicolon
> 

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 58d5acb..8d4fdc3 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -738,7 +738,7 @@ int dpu_plane_validate_multirect_v2(struct dpu_multirect_plane_states *plane)
>  	} else {
>  		pstate[R0]->multirect_index = DPU_SSPP_RECT_0;
>  		pstate[R1]->multirect_index = DPU_SSPP_RECT_1;
> -	};
> +	}
> 
>  	DPU_DEBUG_PLANE(dpu_plane[R0], "R0: %d - %d\n",
>  		pstate[R0]->multirect_mode, pstate[R0]->multirect_index);
> --
> 2.7.4
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c
  2019-12-14  9:31 ` [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c zhengbin
@ 2019-12-16 15:49   ` Jordan Crouse
  0 siblings, 0 replies; 9+ messages in thread
From: Jordan Crouse @ 2019-12-16 15:49 UTC (permalink / raw)
  To: zhengbin
  Cc: robdclark, sean, airlied, daniel, linux-arm-msm, freedreno, dri-devel

On Sat, Dec 14, 2019 at 05:31:50PM +0800, zhengbin wrote:
> Fixes coccicheck warning:
> 
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:2260:3-4: Unneeded semicolon

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index f96e142..0974aa8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -2257,7 +2257,7 @@ int dpu_encoder_wait_for_event(struct drm_encoder *drm_enc,
>  			DPU_ERROR_ENC(dpu_enc, "unknown wait event %d\n",
>  					event);
>  			return -EINVAL;
> -		};
> +		}
> 
>  		if (fn_wait) {
>  			DPU_ATRACE_BEGIN("wait_for_completion_event");
> --
> 2.7.4
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-12-16 15:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-14  9:31 [PATCH 0/4] drm/msm: Remove unneeded semicolon zhengbin
2019-12-14  9:31 ` [PATCH 1/4] drm/msm/hdmi: " zhengbin
2019-12-16 15:48   ` Jordan Crouse
2019-12-14  9:31 ` [PATCH 2/4] drm/msm/mdp5: " zhengbin
2019-12-16 15:48   ` Jordan Crouse
2019-12-14  9:31 ` [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c zhengbin
2019-12-16 15:48   ` Jordan Crouse
2019-12-14  9:31 ` [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c zhengbin
2019-12-16 15:49   ` Jordan Crouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).