From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH 2/3] soc: qcom: rpmh-rsc: Loop over less bits in irq handler
Date: Fri, 24 Apr 2020 10:27:07 -0700 [thread overview]
Message-ID: <158774922735.135303.1360850783025067093@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAD=FV=V7KfjEpdQdkXdnGK86cEkpO_SxcDgFiXqAr8oj25P_zw@mail.gmail.com>
Quoting Doug Anderson (2020-04-24 10:13:43)
> Hi,
>
> On Fri, Apr 24, 2020 at 10:11 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Thu, Apr 23, 2020 at 9:54 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > readl returns a u32, and BITS_PER_LONG is different on 32-bit vs. 64-bit
> > > architectures. Let's make the type we stash the readl into a u32 and
> > > then loop over the bits set in that type instead of potentially looping
> > > over more bits than we will ever need to.
> > >
> > > Cc: Maulik Shah <mkshah@codeaurora.org>
> > > Cc: Douglas Anderson <dianders@chromium.org>
> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > > ---
> > > drivers/soc/qcom/rpmh-rsc.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> Oh, I suppose one nit is s/less/fewer/ in the subject. "bits" are
> discrete / countable, not continuous / uncountable.
>
Ok that's good.
next prev parent reply other threads:[~2020-04-24 17:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 4:54 [PATCH 0/3] Even moar rpmh cleanups Stephen Boyd
2020-04-24 4:54 ` [PATCH 1/3] soc: qcom: rpmh-rsc: Remove tcs_is_free() API Stephen Boyd
2020-04-24 5:36 ` Bjorn Andersson
2020-04-24 17:21 ` Stephen Boyd
2020-04-24 17:12 ` Doug Anderson
2020-04-24 17:28 ` Stephen Boyd
2020-04-24 4:54 ` [PATCH 2/3] soc: qcom: rpmh-rsc: Loop over less bits in irq handler Stephen Boyd
2020-04-24 5:37 ` Bjorn Andersson
2020-04-24 17:11 ` Doug Anderson
2020-04-24 17:13 ` Doug Anderson
2020-04-24 17:27 ` Stephen Boyd [this message]
2020-04-24 4:54 ` [PATCH 3/3] soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition Stephen Boyd
2020-04-24 5:37 ` Bjorn Andersson
2020-04-24 17:11 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158774922735.135303.1360850783025067093@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkshah@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).