From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Maulik Shah <mkshah@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 2/3] soc: qcom: rpmh-rsc: Loop over less bits in irq handler
Date: Thu, 23 Apr 2020 22:37:20 -0700 [thread overview]
Message-ID: <20200424053720.GW20625@builder.lan> (raw)
In-Reply-To: <20200424045414.133381-3-swboyd@chromium.org>
On Thu 23 Apr 21:54 PDT 2020, Stephen Boyd wrote:
> readl returns a u32, and BITS_PER_LONG is different on 32-bit vs. 64-bit
> architectures. Let's make the type we stash the readl into a u32 and
> then loop over the bits set in that type instead of potentially looping
> over more bits than we will ever need to.
>
> Cc: Maulik Shah <mkshah@codeaurora.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/soc/qcom/rpmh-rsc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index 76e0294a672c..462dd267afef 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -365,13 +365,13 @@ static irqreturn_t tcs_tx_done(int irq, void *p)
> {
> struct rsc_drv *drv = p;
> int i, j, err = 0;
> - unsigned long irq_status;
> + u32 irq_status;
> const struct tcs_request *req;
> struct tcs_cmd *cmd;
>
> irq_status = readl_relaxed(drv->tcs_base + RSC_DRV_IRQ_STATUS);
>
> - for_each_set_bit(i, &irq_status, BITS_PER_LONG) {
> + for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) {
> req = get_req_from_tcs(drv, i);
> if (!req) {
> WARN_ON(1);
> --
> Sent by a computer, using git, on the internet
>
next prev parent reply other threads:[~2020-04-24 5:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 4:54 [PATCH 0/3] Even moar rpmh cleanups Stephen Boyd
2020-04-24 4:54 ` [PATCH 1/3] soc: qcom: rpmh-rsc: Remove tcs_is_free() API Stephen Boyd
2020-04-24 5:36 ` Bjorn Andersson
2020-04-24 17:21 ` Stephen Boyd
2020-04-24 17:12 ` Doug Anderson
2020-04-24 17:28 ` Stephen Boyd
2020-04-24 4:54 ` [PATCH 2/3] soc: qcom: rpmh-rsc: Loop over less bits in irq handler Stephen Boyd
2020-04-24 5:37 ` Bjorn Andersson [this message]
2020-04-24 17:11 ` Doug Anderson
2020-04-24 17:13 ` Doug Anderson
2020-04-24 17:27 ` Stephen Boyd
2020-04-24 4:54 ` [PATCH 3/3] soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition Stephen Boyd
2020-04-24 5:37 ` Bjorn Andersson
2020-04-24 17:11 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424053720.GW20625@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).