* [RFC 0/3] Re-introduce TX FIFO resize for larger EP bursting @ 2020-05-07 21:59 Wesley Cheng 2020-05-07 21:59 ` [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Wesley Cheng @ 2020-05-07 21:59 UTC (permalink / raw) To: agross, bjorn.andersson, robh+dt, balbi, gregkh Cc: linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp, Wesley Cheng Currently, there is no functionality to allow for resizing the TXFIFOs, and relying on the HW default setting for the TXFIFO depth. In most cases, the HW default is probably sufficient, but for USB compositions that contain multiple functions that require EP bursting, the default settings might not be enough. Also to note, the current SW will assign an EP to a function driver w/o checking to see if the TXFIFO size for that particular EP is large enough. (this is a problem if there are multiple HW defined values for the TXFIFO size) It is mentioned in the SNPS databook that a minimum of TX FIFO depth = 3 is required for an EP that supports bursting. Otherwise, there may be frequent occurences of bursts ending. For high bandwidth functions, such as data tethering (protocols that support data aggregation), mass storage, and media transfer protocol (over FFS), the bMaxBurst value can be large, and a bigger TXFIFO depth may prove to be beneficial in terms of USB throughput. (which can be associated to system access latency, etc...) It allows for a more consistent burst of traffic, w/o any interruptions, as data is readily available in the FIFO. With testing done using the mass storage function driver, the results show that with a larger TXFIFO depth, the bandwidth increased significantly. Test Parameters: - Platform: Qualcomm SM8150 - bMaxBurst = 6 - USB req size = 256kB - Num of USB reqs = 16 - USB Speed = Super-Speed - Function Driver: Mass Storage (w/ ramdisk) - Test Application: CrystalDiskMark Results: TXFIFO Depth = 3 max packets Test Case | Data Size | AVG tput (in MB/s) ------------------------------------------- Sequential|1 GB x | Read |9 loops | 193.60 | | 195.86 | | 184.77 | | 193.60 ------------------------------------------- TXFIFO Depth = 6 max packets Test Case | Data Size | AVG tput (in MB/s) ------------------------------------------- Sequential|1 GB x | Read |9 loops | 287.35 | | 304.94 | | 289.64 | | 293.61 ------------------------------------------- Wesley Cheng (3): usb: dwc3: Resize TX FIFOs to meet EP bursting requirements arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 + drivers/usb/dwc3/core.c | 2 + drivers/usb/dwc3/core.h | 6 ++ drivers/usb/dwc3/ep0.c | 40 ++++++++++- drivers/usb/dwc3/gadget.c | 95 ++++++++++++++++++++++++++ 6 files changed, 144 insertions(+), 2 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements 2020-05-07 21:59 [RFC 0/3] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng @ 2020-05-07 21:59 ` Wesley Cheng 2020-05-08 12:45 ` Felipe Balbi 2020-05-07 21:59 ` [RFC 2/3] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng 2020-05-07 21:59 ` [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Wesley Cheng 2 siblings, 1 reply; 8+ messages in thread From: Wesley Cheng @ 2020-05-07 21:59 UTC (permalink / raw) To: agross, bjorn.andersson, robh+dt, balbi, gregkh Cc: linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp, Wesley Cheng Some devices have USB compositions which may require multiple endpoints that support EP bursting. HW defined TX FIFO sizes may not always be sufficient for these compositions. By utilizing flexible TX FIFO allocation, this allows for endpoints to request the required FIFO depth to achieve higher bandwidth. With some higher bMaxBurst configurations, using a larger TX FIFO size results in better TX throughput. Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- drivers/usb/dwc3/core.c | 2 + drivers/usb/dwc3/core.h | 6 +++ drivers/usb/dwc3/ep0.c | 40 +++++++++++++++++++- drivers/usb/dwc3/gadget.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 142 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index edc1715..cca5554 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1304,6 +1304,8 @@ static void dwc3_get_properties(struct dwc3 *dwc) &tx_thr_num_pkt_prd); device_property_read_u8(dev, "snps,tx-max-burst-prd", &tx_max_burst_prd); + dwc->needs_fifo_resize = device_property_read_bool(dev, + "tx-fifo-resize"); dwc->disable_scramble_quirk = device_property_read_bool(dev, "snps,disable_scramble_quirk"); diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 4c171a8..e815c13 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -675,6 +675,7 @@ struct dwc3_event_buffer { * isochronous START TRANSFER command failure workaround * @start_cmd_status: the status of testing START TRANSFER command with * combo_num = 'b00 + * @fifo_depth: allocated TXFIFO depth */ struct dwc3_ep { struct usb_ep endpoint; @@ -718,6 +719,7 @@ struct dwc3_ep { u8 resource_index; u32 frame_number; u32 interval; + int fifo_depth; char name[20]; @@ -1004,6 +1006,7 @@ struct dwc3_scratchpad_array { * 1 - utmi_l1_suspend_n * @is_fpga: true when we are using the FPGA board * @pending_events: true when we have pending IRQs to be handled + * @needs_fifo_resize: not all users might want fifo resizing, flag it * @pullups_connected: true when Run/Stop bit is set * @setup_packet_pending: true when there's a Setup Packet in FIFO. Workaround * @three_stage_setup: set if we perform a three phase setup @@ -1044,6 +1047,7 @@ struct dwc3_scratchpad_array { * @dis_metastability_quirk: set to disable metastability quirk. * @imod_interval: set the interrupt moderation interval in 250ns * increments or 0 to disable. + * @last_fifo_depth: total TXFIFO depth of all enabled USB IN/INT endpoints */ struct dwc3 { struct work_struct drd_work; @@ -1204,6 +1208,7 @@ struct dwc3 { unsigned is_utmi_l1_suspend:1; unsigned is_fpga:1; unsigned pending_events:1; + unsigned needs_fifo_resize:1; unsigned pullups_connected:1; unsigned setup_packet_pending:1; unsigned three_stage_setup:1; @@ -1236,6 +1241,7 @@ struct dwc3 { unsigned dis_metastability_quirk:1; u16 imod_interval; + int last_fifo_depth; }; #define INCRX_BURST_MODE 0 diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 6dee4da..7ee2302 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -601,8 +601,9 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl) { enum usb_device_state state = dwc->gadget.state; u32 cfg; - int ret; + int ret, num, size; u32 reg; + struct dwc3_ep *dep; cfg = le16_to_cpu(ctrl->wValue); @@ -611,6 +612,43 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl) return -EINVAL; case USB_STATE_ADDRESS: + /* + * If tx-fifo-resize flag is not set for the controller, then + * do not clear existing allocated TXFIFO since we do not + * allocate it again in dwc3_gadget_resize_tx_fifos + */ + if (dwc->needs_fifo_resize) { + /* Read ep0IN related TXFIFO size */ + dep = dwc->eps[1]; + size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); + if (dwc3_is_usb31(dwc)) + dep->fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size); + else + dep->fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size); + + dwc->last_fifo_depth = dep->fifo_depth; + /* Clear existing TXFIFO for all IN eps except ep0 */ + for (num = 3; num < min_t(int, dwc->num_eps, + DWC3_ENDPOINTS_NUM); num += 2) { + dep = dwc->eps[num]; + /* Don't change TXFRAMNUM on usb31 version */ + size = dwc3_is_usb31(dwc) ? + dwc3_readl(dwc->regs, + DWC3_GTXFIFOSIZ(num >> 1)) & + DWC31_GTXFIFOSIZ_TXFRAMNUM : + 0; + + dwc3_writel(dwc->regs, + DWC3_GTXFIFOSIZ(num >> 1), + size); + dep->fifo_depth = 0; + + dev_dbg(dwc->dev, "%s(): %s fifo_depth:%x\n", + __func__, dep->name, + dep->fifo_depth); + } + } + ret = dwc3_ep0_delegate_req(dwc, ctrl); /* if the cfg matches and the cfg is non zero */ if (cfg && (!ret || (ret == USB_GADGET_DELAYED_STATUS))) { diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 00746c2..6baca05 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -540,6 +540,97 @@ static int dwc3_gadget_start_config(struct dwc3_ep *dep) return 0; } +/* + * dwc3_gadget_resize_tx_fifos - reallocate fifo spaces for current use-case + * @dwc: pointer to our context structure + * + * This function will a best effort FIFO allocation in order + * to improve FIFO usage and throughput, while still allowing + * us to enable as many endpoints as possible. + * + * Keep in mind that this operation will be highly dependent + * on the configured size for RAM1 - which contains TxFifo -, + * the amount of endpoints enabled on coreConsultant tool, and + * the width of the Master Bus. + * + * In the ideal world, we would always be able to satisfy the + * following equation: + * + * ((512 + 2 * MDWIDTH-Bytes) + (Number of IN Endpoints - 1) * \ + * (3 * (1024 + MDWIDTH-Bytes) + MDWIDTH-Bytes)) / MDWIDTH-Bytes + * + * Unfortunately, due to many variables that's not always the case. + */ +static int dwc3_gadget_resize_tx_fifos(struct dwc3 *dwc, struct dwc3_ep *dep) +{ + int fifo_size, mdwidth, max_packet = 1024; + int tmp, mult = 1, fifo_0_start, ram1_depth; + + if (!dwc->needs_fifo_resize) + return 0; + + /* resize IN endpoints excepts ep0 */ + if (!usb_endpoint_dir_in(dep->endpoint.desc) || dep->number <= 1) + return 0; + + /* Don't resize already resized IN endpoint */ + if (dep->fifo_depth) { + dev_dbg(dwc->dev, "%s fifo_depth:%d is already set\n", + dep->endpoint.name, dep->fifo_depth); + return 0; + } + + ram1_depth = DWC3_RAM1_DEPTH(dwc->hwparams.hwparams7); + mdwidth = DWC3_MDWIDTH(dwc->hwparams.hwparams0); + /* MDWIDTH is represented in bits, we need it in bytes */ + mdwidth >>= 3; + + if (((dep->endpoint.maxburst > 1) && + usb_endpoint_xfer_bulk(dep->endpoint.desc)) + || usb_endpoint_xfer_isoc(dep->endpoint.desc)) + mult = 3; + + if ((dep->endpoint.maxburst > 6) && + usb_endpoint_xfer_bulk(dep->endpoint.desc) + && dwc3_is_usb31(dwc)) + mult = 6; + + tmp = ((max_packet + mdwidth) * mult) + mdwidth; + fifo_size = DIV_ROUND_UP(tmp, mdwidth); + dep->fifo_depth = fifo_size; + + /* Check if TXFIFOs start at non-zero addr */ + tmp = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); + fifo_0_start = DWC3_GTXFIFOSIZ_TXFSTADDR(tmp); + + fifo_size |= (fifo_0_start + (dwc->last_fifo_depth << 16)); + if (dwc3_is_usb31(dwc)) + dwc->last_fifo_depth += DWC31_GTXFIFOSIZ_TXFDEP(fifo_size); + else + dwc->last_fifo_depth += DWC3_GTXFIFOSIZ_TXFDEP(fifo_size); + + dev_dbg(dwc->dev, "%s ep_num:%d last_fifo_depth:%04x fifo_depth:%d\n", + dep->endpoint.name, dep->number >> 1, + dwc->last_fifo_depth, dep->fifo_depth); + + /* Check fifo size allocation doesn't exceed available RAM size. */ + if (dwc->last_fifo_depth >= ram1_depth) { + dev_err(dwc->dev, "Fifosize(%d) > RAM size(%d) %s depth:%d\n", + (dwc->last_fifo_depth * mdwidth), ram1_depth, + dep->endpoint.name, fifo_size); + if (dwc3_is_usb31(dwc)) + fifo_size = DWC31_GTXFIFOSIZ_TXFDEP(fifo_size); + else + fifo_size = DWC3_GTXFIFOSIZ_TXFDEP(fifo_size); + dwc->last_fifo_depth -= fifo_size; + dep->fifo_depth = 0; + return -ENOMEM; + } + + dwc3_writel(dwc->regs, DWC3_GTXFIFOSIZ(dep->number >> 1), fifo_size); + return 0; +} + static int dwc3_gadget_set_ep_config(struct dwc3_ep *dep, unsigned int action) { const struct usb_ss_ep_comp_descriptor *comp_desc; @@ -620,6 +711,10 @@ static int __dwc3_gadget_ep_enable(struct dwc3_ep *dep, unsigned int action) int ret; if (!(dep->flags & DWC3_EP_ENABLED)) { + ret = dwc3_gadget_resize_tx_fifos(dwc, dep); + if (ret) + return ret; + ret = dwc3_gadget_start_config(dep); if (ret) return ret; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements 2020-05-07 21:59 ` [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng @ 2020-05-08 12:45 ` Felipe Balbi 2020-05-09 8:42 ` Wesley Cheng 0 siblings, 1 reply; 8+ messages in thread From: Felipe Balbi @ 2020-05-08 12:45 UTC (permalink / raw) To: Wesley Cheng, agross, bjorn.andersson, robh+dt, gregkh Cc: linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp, Wesley Cheng [-- Attachment #1: Type: text/plain, Size: 6377 bytes --] Hi, Wesley Cheng <wcheng@codeaurora.org> writes: > Some devices have USB compositions which may require multiple endpoints > that support EP bursting. HW defined TX FIFO sizes may not always be > sufficient for these compositions. By utilizing flexible TX FIFO > allocation, this allows for endpoints to request the required FIFO depth to > achieve higher bandwidth. With some higher bMaxBurst configurations, using > a larger TX FIFO size results in better TX throughput. This needs to be carefully thought out as it can introduce situations where gadget drivers that worked previously stop working. > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 4c171a8..e815c13 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -675,6 +675,7 @@ struct dwc3_event_buffer { > * isochronous START TRANSFER command failure workaround > * @start_cmd_status: the status of testing START TRANSFER command with > * combo_num = 'b00 > + * @fifo_depth: allocated TXFIFO depth > */ > struct dwc3_ep { > struct usb_ep endpoint; > @@ -718,6 +719,7 @@ struct dwc3_ep { > u8 resource_index; > u32 frame_number; > u32 interval; > + int fifo_depth; > > char name[20]; > > @@ -1004,6 +1006,7 @@ struct dwc3_scratchpad_array { > * 1 - utmi_l1_suspend_n > * @is_fpga: true when we are using the FPGA board > * @pending_events: true when we have pending IRQs to be handled > + * @needs_fifo_resize: not all users might want fifo resizing, flag it > * @pullups_connected: true when Run/Stop bit is set > * @setup_packet_pending: true when there's a Setup Packet in FIFO. Workaround > * @three_stage_setup: set if we perform a three phase setup > @@ -1044,6 +1047,7 @@ struct dwc3_scratchpad_array { > * @dis_metastability_quirk: set to disable metastability quirk. > * @imod_interval: set the interrupt moderation interval in 250ns > * increments or 0 to disable. > + * @last_fifo_depth: total TXFIFO depth of all enabled USB IN/INT endpoints > */ > struct dwc3 { > struct work_struct drd_work; > @@ -1204,6 +1208,7 @@ struct dwc3 { > unsigned is_utmi_l1_suspend:1; > unsigned is_fpga:1; > unsigned pending_events:1; > + unsigned needs_fifo_resize:1; Instead of passing a flag, this could be detected in runtime during ->udc_start() > diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c > index 6dee4da..7ee2302 100644 > --- a/drivers/usb/dwc3/ep0.c > +++ b/drivers/usb/dwc3/ep0.c > @@ -611,6 +612,43 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl) > return -EINVAL; > > case USB_STATE_ADDRESS: are you sure it's safe to fiddle with TX FIFO allocation at SetAddress() time? > + /* > + * If tx-fifo-resize flag is not set for the controller, then > + * do not clear existing allocated TXFIFO since we do not > + * allocate it again in dwc3_gadget_resize_tx_fifos > + */ > + if (dwc->needs_fifo_resize) { > + /* Read ep0IN related TXFIFO size */ > + dep = dwc->eps[1]; > + size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); > + if (dwc3_is_usb31(dwc)) > + dep->fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size); > + else > + dep->fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size); > + > + dwc->last_fifo_depth = dep->fifo_depth; > + /* Clear existing TXFIFO for all IN eps except ep0 */ > + for (num = 3; num < min_t(int, dwc->num_eps, > + DWC3_ENDPOINTS_NUM); num += 2) { > + dep = dwc->eps[num]; > + /* Don't change TXFRAMNUM on usb31 version */ > + size = dwc3_is_usb31(dwc) ? > + dwc3_readl(dwc->regs, > + DWC3_GTXFIFOSIZ(num >> 1)) & > + DWC31_GTXFIFOSIZ_TXFRAMNUM : > + 0; > + > + dwc3_writel(dwc->regs, > + DWC3_GTXFIFOSIZ(num >> 1), > + size); > + dep->fifo_depth = 0; > + > + dev_dbg(dwc->dev, "%s(): %s fifo_depth:%x\n", > + __func__, dep->name, > + dep->fifo_depth); no dev_dbg() calls in this driver, please. > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 00746c2..6baca05 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -540,6 +540,97 @@ static int dwc3_gadget_start_config(struct dwc3_ep *dep) > return 0; > } > > +/* > + * dwc3_gadget_resize_tx_fifos - reallocate fifo spaces for current use-case > + * @dwc: pointer to our context structure > + * > + * This function will a best effort FIFO allocation in order > + * to improve FIFO usage and throughput, while still allowing > + * us to enable as many endpoints as possible. > + * > + * Keep in mind that this operation will be highly dependent > + * on the configured size for RAM1 - which contains TxFifo -, > + * the amount of endpoints enabled on coreConsultant tool, and > + * the width of the Master Bus. > + * > + * In the ideal world, we would always be able to satisfy the > + * following equation: > + * > + * ((512 + 2 * MDWIDTH-Bytes) + (Number of IN Endpoints - 1) * \ > + * (3 * (1024 + MDWIDTH-Bytes) + MDWIDTH-Bytes)) / MDWIDTH-Bytes > + * > + * Unfortunately, due to many variables that's not always the case. > + */ > +static int dwc3_gadget_resize_tx_fifos(struct dwc3 *dwc, struct dwc3_ep *dep) > +{ > + int fifo_size, mdwidth, max_packet = 1024; > + int tmp, mult = 1, fifo_0_start, ram1_depth; > + > + if (!dwc->needs_fifo_resize) > + return 0; > + > + /* resize IN endpoints excepts ep0 */ typo: excepts > + if (!usb_endpoint_dir_in(dep->endpoint.desc) || dep->number <= 1) > + return 0; > + > + /* Don't resize already resized IN endpoint */ > + if (dep->fifo_depth) { > + dev_dbg(dwc->dev, "%s fifo_depth:%d is already set\n", > + dep->endpoint.name, dep->fifo_depth); no dev_dbg() > @@ -620,6 +711,10 @@ static int __dwc3_gadget_ep_enable(struct dwc3_ep *dep, unsigned int action) > int ret; > > if (!(dep->flags & DWC3_EP_ENABLED)) { > + ret = dwc3_gadget_resize_tx_fifos(dwc, dep); technically, you're no resizing a single FIFO. In any case, what happens when you run out of space midway through the resizing? You already accepted the gadget driver, you're already bound to it, then you resize the FIFOs and things start to fall apart. How do we handle that? -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements 2020-05-08 12:45 ` Felipe Balbi @ 2020-05-09 8:42 ` Wesley Cheng 0 siblings, 0 replies; 8+ messages in thread From: Wesley Cheng @ 2020-05-09 8:42 UTC (permalink / raw) To: Felipe Balbi, agross, bjorn.andersson, robh+dt, gregkh Cc: linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp On 5/8/2020 5:45 AM, Felipe Balbi wrote: > > Hi, > > Wesley Cheng <wcheng@codeaurora.org> writes: >> Some devices have USB compositions which may require multiple endpoints >> that support EP bursting. HW defined TX FIFO sizes may not always be >> sufficient for these compositions. By utilizing flexible TX FIFO >> allocation, this allows for endpoints to request the required FIFO depth to >> achieve higher bandwidth. With some higher bMaxBurst configurations, using >> a larger TX FIFO size results in better TX throughput. > > This needs to be carefully thought out as it can introduce situations > where gadget drivers that worked previously stop working. > Hi Felipe, Thanks for the feedback. I agree, the TX FIFO resizing logic should be reviewed carefully to, in order not to cause any regressions. Would you be willing to shed some light on some of the failures you've seen previously where the gadget drivers stopped working? (would help possibly come up with better approaches, etc...) >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index 4c171a8..e815c13 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -675,6 +675,7 @@ struct dwc3_event_buffer { >> * isochronous START TRANSFER command failure workaround >> * @start_cmd_status: the status of testing START TRANSFER command with >> * combo_num = 'b00 >> + * @fifo_depth: allocated TXFIFO depth >> */ >> struct dwc3_ep { >> struct usb_ep endpoint; >> @@ -718,6 +719,7 @@ struct dwc3_ep { >> u8 resource_index; >> u32 frame_number; >> u32 interval; >> + int fifo_depth; >> >> char name[20]; >> >> @@ -1004,6 +1006,7 @@ struct dwc3_scratchpad_array { >> * 1 - utmi_l1_suspend_n >> * @is_fpga: true when we are using the FPGA board >> * @pending_events: true when we have pending IRQs to be handled >> + * @needs_fifo_resize: not all users might want fifo resizing, flag it >> * @pullups_connected: true when Run/Stop bit is set >> * @setup_packet_pending: true when there's a Setup Packet in FIFO. Workaround >> * @three_stage_setup: set if we perform a three phase setup >> @@ -1044,6 +1047,7 @@ struct dwc3_scratchpad_array { >> * @dis_metastability_quirk: set to disable metastability quirk. >> * @imod_interval: set the interrupt moderation interval in 250ns >> * increments or 0 to disable. >> + * @last_fifo_depth: total TXFIFO depth of all enabled USB IN/INT endpoints >> */ >> struct dwc3 { >> struct work_struct drd_work; >> @@ -1204,6 +1208,7 @@ struct dwc3 { >> unsigned is_utmi_l1_suspend:1; >> unsigned is_fpga:1; >> unsigned pending_events:1; >> + unsigned needs_fifo_resize:1; > > Instead of passing a flag, this could be detected in runtime during ->udc_start() > The flag was going to serve the purpose of allowing platforms to define if they want to enable the TX FIFO resizing logic or not. Maybe in their particular HW platform, the HW default FIFO settings are sufficient. >> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c >> index 6dee4da..7ee2302 100644 >> --- a/drivers/usb/dwc3/ep0.c >> +++ b/drivers/usb/dwc3/ep0.c >> @@ -611,6 +612,43 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl) >> return -EINVAL; >> >> case USB_STATE_ADDRESS: > > are you sure it's safe to fiddle with TX FIFO allocation at SetAddress() > time? > It should be acceptable, as the function drivers shouldn't be calling usb_ep_enable() until we receive a SET_CONFIG from the host to enable the configuration. __dwc3_gadget_ep_enable() --> dwc3_gadget_set_ep_config() is where we'd assign the EP to a particular TX FIFO. >> + /* >> + * If tx-fifo-resize flag is not set for the controller, then >> + * do not clear existing allocated TXFIFO since we do not >> + * allocate it again in dwc3_gadget_resize_tx_fifos >> + */ >> + if (dwc->needs_fifo_resize) { >> + /* Read ep0IN related TXFIFO size */ >> + dep = dwc->eps[1]; >> + size = dwc3_readl(dwc->regs, DWC3_GTXFIFOSIZ(0)); >> + if (dwc3_is_usb31(dwc)) >> + dep->fifo_depth = DWC31_GTXFIFOSIZ_TXFDEP(size); >> + else >> + dep->fifo_depth = DWC3_GTXFIFOSIZ_TXFDEP(size); >> + >> + dwc->last_fifo_depth = dep->fifo_depth; >> + /* Clear existing TXFIFO for all IN eps except ep0 */ >> + for (num = 3; num < min_t(int, dwc->num_eps, >> + DWC3_ENDPOINTS_NUM); num += 2) { >> + dep = dwc->eps[num]; >> + /* Don't change TXFRAMNUM on usb31 version */ >> + size = dwc3_is_usb31(dwc) ? >> + dwc3_readl(dwc->regs, >> + DWC3_GTXFIFOSIZ(num >> 1)) & >> + DWC31_GTXFIFOSIZ_TXFRAMNUM : >> + 0; >> + >> + dwc3_writel(dwc->regs, >> + DWC3_GTXFIFOSIZ(num >> 1), >> + size); >> + dep->fifo_depth = 0; >> + >> + dev_dbg(dwc->dev, "%s(): %s fifo_depth:%x\n", >> + __func__, dep->name, >> + dep->fifo_depth); > > no dev_dbg() calls in this driver, please. > Got it. >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 00746c2..6baca05 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -540,6 +540,97 @@ static int dwc3_gadget_start_config(struct dwc3_ep *dep) >> return 0; >> } >> >> +/* >> + * dwc3_gadget_resize_tx_fifos - reallocate fifo spaces for current use-case >> + * @dwc: pointer to our context structure >> + * >> + * This function will a best effort FIFO allocation in order >> + * to improve FIFO usage and throughput, while still allowing >> + * us to enable as many endpoints as possible. >> + * >> + * Keep in mind that this operation will be highly dependent >> + * on the configured size for RAM1 - which contains TxFifo -, >> + * the amount of endpoints enabled on coreConsultant tool, and >> + * the width of the Master Bus. >> + * >> + * In the ideal world, we would always be able to satisfy the >> + * following equation: >> + * >> + * ((512 + 2 * MDWIDTH-Bytes) + (Number of IN Endpoints - 1) * \ >> + * (3 * (1024 + MDWIDTH-Bytes) + MDWIDTH-Bytes)) / MDWIDTH-Bytes >> + * >> + * Unfortunately, due to many variables that's not always the case. >> + */ >> +static int dwc3_gadget_resize_tx_fifos(struct dwc3 *dwc, struct dwc3_ep *dep) >> +{ >> + int fifo_size, mdwidth, max_packet = 1024; >> + int tmp, mult = 1, fifo_0_start, ram1_depth; >> + >> + if (!dwc->needs_fifo_resize) >> + return 0; >> + >> + /* resize IN endpoints excepts ep0 */ > > typo: excepts > Got it. >> + if (!usb_endpoint_dir_in(dep->endpoint.desc) || dep->number <= 1) >> + return 0; >> + >> + /* Don't resize already resized IN endpoint */ >> + if (dep->fifo_depth) { >> + dev_dbg(dwc->dev, "%s fifo_depth:%d is already set\n", >> + dep->endpoint.name, dep->fifo_depth); > > no dev_dbg() > Understood. >> @@ -620,6 +711,10 @@ static int __dwc3_gadget_ep_enable(struct dwc3_ep *dep, unsigned int action) >> int ret; >> >> if (!(dep->flags & DWC3_EP_ENABLED)) { >> + ret = dwc3_gadget_resize_tx_fifos(dwc, dep); > > technically, you're no resizing a single FIFO. In any case, what happens > when you run out of space midway through the resizing? You already > accepted the gadget driver, you're already bound to it, then you resize > the FIFOs and things start to fall apart. How do we handle that? > Yes, that is a valid concern. At the moment, if we returned -ENOMEM due to the resizing logic failing, then the function driver would receive an error during usb_ep_enable(). This would then most likely result in the data path not being enabled for each subsequent function driver. Would the situation be better if we avoid binding to the UDC entirely if our TXFIFO was out of memory? Thanks again for the input! -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC 2/3] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic 2020-05-07 21:59 [RFC 0/3] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng 2020-05-07 21:59 ` [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng @ 2020-05-07 21:59 ` Wesley Cheng 2020-05-07 21:59 ` [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Wesley Cheng 2 siblings, 0 replies; 8+ messages in thread From: Wesley Cheng @ 2020-05-07 21:59 UTC (permalink / raw) To: agross, bjorn.andersson, robh+dt, balbi, gregkh Cc: linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp, Wesley Cheng Enable the flexible TX FIFO resize logic on SM8150. Using a larger TX FIFO SZ can help account for situations when system latency is greater than the USB bus transmission latency. Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index a36512d..c285233 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -708,6 +708,7 @@ interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>; snps,dis_u2_susphy_quirk; snps,dis_enblslpm_quirk; + tx-fifo-resize; phys = <&usb_1_hsphy>, <&usb_1_ssphy>; phy-names = "usb2-phy", "usb3-phy"; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize 2020-05-07 21:59 [RFC 0/3] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng 2020-05-07 21:59 ` [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng 2020-05-07 21:59 ` [RFC 2/3] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng @ 2020-05-07 21:59 ` Wesley Cheng 2020-05-15 3:10 ` Rob Herring 2 siblings, 1 reply; 8+ messages in thread From: Wesley Cheng @ 2020-05-07 21:59 UTC (permalink / raw) To: agross, bjorn.andersson, robh+dt, balbi, gregkh Cc: linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp, Wesley Cheng Re-introduce the comment for the tx-fifo-resize setting for the DWC3 controller. Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt index 9946ff9..489f5da 100644 --- a/Documentation/devicetree/bindings/usb/dwc3.txt +++ b/Documentation/devicetree/bindings/usb/dwc3.txt @@ -105,7 +105,7 @@ Optional properties: 1-16 (DWC_usb31 programming guide section 1.2.3) to enable periodic ESS TX threshold. - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. + - tx-fifo-resize: determines if the FIFO *has* to be reallocated. - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 register, undefined length INCR burst type enable and INCRx type. When just one value, which means INCRX burst mode enabled. When -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize 2020-05-07 21:59 ` [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Wesley Cheng @ 2020-05-15 3:10 ` Rob Herring 2020-05-15 18:39 ` Wesley Cheng 0 siblings, 1 reply; 8+ messages in thread From: Rob Herring @ 2020-05-15 3:10 UTC (permalink / raw) To: Wesley Cheng Cc: agross, bjorn.andersson, balbi, gregkh, linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp On Thu, May 07, 2020 at 02:59:28PM -0700, Wesley Cheng wrote: > Re-introduce the comment for the tx-fifo-resize setting for the DWC3 > controller. Why? > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 9946ff9..489f5da 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -105,7 +105,7 @@ Optional properties: > 1-16 (DWC_usb31 programming guide section 1.2.3) to > enable periodic ESS TX threshold. > > - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. > + - tx-fifo-resize: determines if the FIFO *has* to be reallocated. > - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 > register, undefined length INCR burst type enable and INCRx type. > When just one value, which means INCRX burst mode enabled. When > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize 2020-05-15 3:10 ` Rob Herring @ 2020-05-15 18:39 ` Wesley Cheng 0 siblings, 0 replies; 8+ messages in thread From: Wesley Cheng @ 2020-05-15 18:39 UTC (permalink / raw) To: Rob Herring Cc: agross, bjorn.andersson, balbi, gregkh, linux-arm-msm, devicetree, linux-kernel, linux-usb, jackp On 5/14/2020 8:10 PM, Rob Herring wrote: > On Thu, May 07, 2020 at 02:59:28PM -0700, Wesley Cheng wrote: >> Re-introduce the comment for the tx-fifo-resize setting for the DWC3 >> controller. > > Why? > Hi Rob, Initially, the reasoning behind bringing back the DTSI parameter, was to address situations where vendors don't require the resizing logic. I was assuming that each vendor has their own HW configuration for the TX FIFO size, and some may already have sufficient space to account for their endpoint requirements. However, if Felipe doesn't believe we need to have a DTSI parameter for this, then we don't need to re-add this back in. >> >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt >> index 9946ff9..489f5da 100644 >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt >> @@ -105,7 +105,7 @@ Optional properties: >> 1-16 (DWC_usb31 programming guide section 1.2.3) to >> enable periodic ESS TX threshold. >> >> - - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. >> + - tx-fifo-resize: determines if the FIFO *has* to be reallocated. >> - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 >> register, undefined length INCR burst type enable and INCRx type. >> When just one value, which means INCRX burst mode enabled. When >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-15 18:39 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-07 21:59 [RFC 0/3] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng 2020-05-07 21:59 ` [RFC 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng 2020-05-08 12:45 ` Felipe Balbi 2020-05-09 8:42 ` Wesley Cheng 2020-05-07 21:59 ` [RFC 2/3] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng 2020-05-07 21:59 ` [RFC 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Wesley Cheng 2020-05-15 3:10 ` Rob Herring 2020-05-15 18:39 ` Wesley Cheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).