Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/3] Enable DVFS support for IPQ6018
@ 2020-07-30  8:49 Kathiravan T
  2020-07-30  8:49 ` [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC Kathiravan T
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Kathiravan T @ 2020-07-30  8:49 UTC (permalink / raw)
  To: agross, bjorn.andersson, robh+dt, lgirdwood, broonie, sivaprak,
	kathirav, linux-arm-msm, devicetree, linux-kernel

Add A53 PLL, APCS clock, RPM Glink, RPM message RAM, cpu-opp-table,
SMPA2 regulator to enable the cpu frequency on IPQ6018.

Kathiravan T (3):
  dt-bindings: mailbox: add compatible for the IPQ6018 SoC
  dt-bindings: regulator: add the sub node names for the MP5496 PMIC
  arm64: dts: ipq6018: enable DVFS support

 .../bindings/mailbox/qcom,apcs-kpss-global.yaml    |  1 +
 .../bindings/regulator/qcom,smd-rpm-regulator.yaml |  2 +
 arch/arm64/boot/dts/qcom/ipq6018.dtsi              | 96 +++++++++++++++++++++-
 3 files changed, 96 insertions(+), 3 deletions(-)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC
  2020-07-30  8:49 [PATCH 0/3] Enable DVFS support for IPQ6018 Kathiravan T
@ 2020-07-30  8:49 ` Kathiravan T
  2020-07-31 22:28   ` Rob Herring
  2020-07-30  8:49 ` [PATCH 2/3] dt-bindings: regulator: add the sub node names for the MP5496 PMIC Kathiravan T
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Kathiravan T @ 2020-07-30  8:49 UTC (permalink / raw)
  To: agross, bjorn.andersson, robh+dt, lgirdwood, broonie, sivaprak,
	kathirav, linux-arm-msm, devicetree, linux-kernel

Add the mailbox compatible for the IPQ6018 SoC.

Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
---
 Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 12eff942708d..60e9532fcd29 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -16,6 +16,7 @@ maintainers:
 properties:
   compatible:
     enum:
+      - qcom,ipq6018-apcs-apps-global
       - qcom,ipq8074-apcs-apps-global
       - qcom,msm8916-apcs-kpss-global
       - qcom,msm8996-apcs-hmss-global
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/3] dt-bindings: regulator: add the sub node names for the MP5496 PMIC
  2020-07-30  8:49 [PATCH 0/3] Enable DVFS support for IPQ6018 Kathiravan T
  2020-07-30  8:49 ` [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC Kathiravan T
@ 2020-07-30  8:49 ` Kathiravan T
  2020-07-30  8:49 ` [PATCH 3/3] arm64: dts: ipq6018: enable DVFS support Kathiravan T
  2020-07-30 22:28 ` [PATCH 0/3] Enable DVFS support for IPQ6018 Mark Brown
  3 siblings, 0 replies; 7+ messages in thread
From: Kathiravan T @ 2020-07-30  8:49 UTC (permalink / raw)
  To: agross, bjorn.andersson, robh+dt, lgirdwood, broonie, sivaprak,
	kathirav, linux-arm-msm, devicetree, linux-kernel

MP5496 PMIC is found on IPQ6018 SoC. SMPA2 regulator controls the APSS
voltage scaling. Document the sub node name for the same.

Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
---
 Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
index 8d212bdbee02..d2022206081f 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
@@ -22,6 +22,8 @@ description:
   Each sub-node is identified using the node's name, with valid values listed
   for each of the pmics below.
 
+  For mp5496, s2
+
   For pm8841, s1, s2, s3, s4, s5, s6, s7, s8
 
   For pm8916, s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11,
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 3/3] arm64: dts: ipq6018: enable DVFS support
  2020-07-30  8:49 [PATCH 0/3] Enable DVFS support for IPQ6018 Kathiravan T
  2020-07-30  8:49 ` [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC Kathiravan T
  2020-07-30  8:49 ` [PATCH 2/3] dt-bindings: regulator: add the sub node names for the MP5496 PMIC Kathiravan T
@ 2020-07-30  8:49 ` Kathiravan T
  2020-07-30 21:47   ` kernel test robot
  2020-07-30 22:28 ` [PATCH 0/3] Enable DVFS support for IPQ6018 Mark Brown
  3 siblings, 1 reply; 7+ messages in thread
From: Kathiravan T @ 2020-07-30  8:49 UTC (permalink / raw)
  To: agross, bjorn.andersson, robh+dt, lgirdwood, broonie, sivaprak,
	kathirav, linux-arm-msm, devicetree, linux-kernel

Add A53 PLL, APCS clock, RPM Glink, RPM message RAM, cpu-opp-table,
SMPA2 regulator to enable the cpu frequency on IPQ6018.

Co-developed-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 96 +++++++++++++++++++++++++++++++++--
 1 file changed, 93 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 1aa8d8579463..a94dac76bf3f 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -8,6 +8,7 @@
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/qcom,gcc-ipq6018.h>
 #include <dt-bindings/reset/qcom,gcc-ipq6018.h>
+#include <dt-bindings/clock/qcom,apss-ipq.h>
 
 / {
 	#address-cells = <2>;
@@ -38,6 +39,10 @@
 			reg = <0x0>;
 			enable-method = "psci";
 			next-level-cache = <&L2_0>;
+			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
+			clock-names = "cpu";
+			operating-points-v2 = <&cpu_opp_table>;
+			cpu-supply = <&ipq6018_s2>;
 		};
 
 		CPU1: cpu@1 {
@@ -46,6 +51,10 @@
 			enable-method = "psci";
 			reg = <0x1>;
 			next-level-cache = <&L2_0>;
+			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
+			clock-names = "cpu";
+			operating-points-v2 = <&cpu_opp_table>;
+			cpu-supply = <&ipq6018_s2>;
 		};
 
 		CPU2: cpu@2 {
@@ -54,6 +63,10 @@
 			enable-method = "psci";
 			reg = <0x2>;
 			next-level-cache = <&L2_0>;
+			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
+			clock-names = "cpu";
+			operating-points-v2 = <&cpu_opp_table>;
+			cpu-supply = <&ipq6018_s2>;
 		};
 
 		CPU3: cpu@3 {
@@ -62,6 +75,10 @@
 			enable-method = "psci";
 			reg = <0x3>;
 			next-level-cache = <&L2_0>;
+			clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>;
+			clock-names = "cpu";
+			operating-points-v2 = <&cpu_opp_table>;
+			cpu-supply = <&ipq6018_s2>;
 		};
 
 		L2_0: l2-cache {
@@ -70,6 +87,42 @@
 		};
 	};
 
+	cpu_opp_table: cpu_opp_table {
+		compatible = "operating-points-v2";
+		opp-shared;
+
+		opp-864000000 {
+			opp-hz = /bits/ 64 <864000000>;
+			opp-microvolt = <725000>;
+			clock-latency-ns = <200000>;
+		};
+		opp-1056000000 {
+			opp-hz = /bits/ 64 <1056000000>;
+			opp-microvolt = <787500>;
+			clock-latency-ns = <200000>;
+		};
+		opp-1320000000 {
+			opp-hz = /bits/ 64 <1320000000>;
+			opp-microvolt = <862500>;
+			clock-latency-ns = <200000>;
+		};
+		opp-1440000000 {
+			opp-hz = /bits/ 64 <1440000000>;
+			opp-microvolt = <925000>;
+			clock-latency-ns = <200000>;
+		};
+		opp-1608000000 {
+			opp-hz = /bits/ 64 <1608000000>;
+			opp-microvolt = <987500>;
+			clock-latency-ns = <200000>;
+		};
+		opp-1800000000 {
+			opp-hz = /bits/ 64 <1800000000>;
+			opp-microvolt = <1062500>;
+			clock-latency-ns = <200000>;
+		};
+	};
+
 	firmware {
 		scm {
 			compatible = "qcom,scm";
@@ -98,6 +151,11 @@
 		#size-cells = <2>;
 		ranges;
 
+		rpm_msg_ram: memory@0x60000 {
+			reg = <0x0 0x60000 0x0 0x6000>;
+			no-map;
+		};
+
 		tz: tz@48500000 {
 			reg = <0x0 0x48500000 0x0 0x00200000>;
 			no-map;
@@ -294,12 +352,22 @@
 		};
 
 		apcs_glb: mailbox@b111000 {
-			compatible = "qcom,ipq8074-apcs-apps-global";
-			reg = <0x0b111000 0xc>;
-
+			compatible = "qcom,ipq6018-apcs-apps-global";
+			reg = <0x0b111000 0x1000>;
+			#clock-cells = <1>;
+			clocks = <&a53pll>, <&xo>;
+			clock-names = "pll", "xo";
 			#mbox-cells = <1>;
 		};
 
+		a53pll: clock@b116000 {
+			compatible = "qcom,ipq6018-a53pll";
+			reg = <0x0b116000 0x40>;
+			#clock-cells = <0>;
+			clocks = <&xo>;
+			clock-names = "xo";
+		};
+
 		timer {
 			compatible = "arm,armv8-timer";
 			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
@@ -440,4 +508,26 @@
 			#interrupt-cells = <2>;
 		};
 	};
+
+	rpm-glink {
+		compatible = "qcom,glink-rpm";
+		interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
+		qcom,rpm-msg-ram = <&rpm_msg_ram>;
+		mboxes = <&apcs_glb 0>;
+
+		rpm_requests: glink-channel {
+			compatible = "qcom,rpm-ipq6018";
+			qcom,glink-channels = "rpm_requests";
+
+			regulators {
+				compatible = "qcom,rpm-mp5496-regulators";
+
+				ipq6018_s2: s2 {
+					regulator-min-microvolt = <725000>;
+					regulator-max-microvolt = <1062500>;
+					regulator-always-on;
+				};
+			};
+		};
+	};
 };
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] arm64: dts: ipq6018: enable DVFS support
  2020-07-30  8:49 ` [PATCH 3/3] arm64: dts: ipq6018: enable DVFS support Kathiravan T
@ 2020-07-30 21:47   ` kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2020-07-30 21:47 UTC (permalink / raw)
  To: Kathiravan T, agross, bjorn.andersson, robh+dt, lgirdwood,
	broonie, sivaprak, linux-arm-msm, devicetree, linux-kernel
  Cc: kbuild-all


[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

Hi Kathiravan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on regulator/for-next]
[cannot apply to robh/for-next v5.8-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kathiravan-T/Enable-DVFS-support-for-IPQ6018/20200730-165021
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts:10:
>> arch/arm64/boot/dts/qcom/ipq6018.dtsi:11:10: fatal error: dt-bindings/clock/qcom,apss-ipq.h: No such file or directory
    #include <dt-bindings/clock/qcom,apss-ipq.h>
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   compilation terminated.

vim +11 arch/arm64/boot/dts/qcom/ipq6018.dtsi

  > 11	#include <dt-bindings/clock/qcom,apss-ipq.h>
    12	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50230 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] Enable DVFS support for IPQ6018
  2020-07-30  8:49 [PATCH 0/3] Enable DVFS support for IPQ6018 Kathiravan T
                   ` (2 preceding siblings ...)
  2020-07-30  8:49 ` [PATCH 3/3] arm64: dts: ipq6018: enable DVFS support Kathiravan T
@ 2020-07-30 22:28 ` Mark Brown
  3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-30 22:28 UTC (permalink / raw)
  To: Kathiravan T, linux-kernel, bjorn.andersson, robh+dt, agross,
	linux-arm-msm, lgirdwood, devicetree, sivaprak

On Thu, 30 Jul 2020 14:19:21 +0530, Kathiravan T wrote:
> Add A53 PLL, APCS clock, RPM Glink, RPM message RAM, cpu-opp-table,
> SMPA2 regulator to enable the cpu frequency on IPQ6018.
> 
> Kathiravan T (3):
>   dt-bindings: mailbox: add compatible for the IPQ6018 SoC
>   dt-bindings: regulator: add the sub node names for the MP5496 PMIC
>   arm64: dts: ipq6018: enable DVFS support
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: add the sub node names for the MP5496 PMIC
      commit: bcb3b2a7639db2412875520cddc3abd179068793

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC
  2020-07-30  8:49 ` [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC Kathiravan T
@ 2020-07-31 22:28   ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2020-07-31 22:28 UTC (permalink / raw)
  To: Kathiravan T
  Cc: linux-arm-msm, bjorn.andersson, devicetree, sivaprak, robh+dt,
	broonie, agross, lgirdwood, linux-kernel

On Thu, 30 Jul 2020 14:19:22 +0530, Kathiravan T wrote:
> Add the mailbox compatible for the IPQ6018 SoC.
> 
> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30  8:49 [PATCH 0/3] Enable DVFS support for IPQ6018 Kathiravan T
2020-07-30  8:49 ` [PATCH 1/3] dt-bindings: mailbox: add compatible for the IPQ6018 SoC Kathiravan T
2020-07-31 22:28   ` Rob Herring
2020-07-30  8:49 ` [PATCH 2/3] dt-bindings: regulator: add the sub node names for the MP5496 PMIC Kathiravan T
2020-07-30  8:49 ` [PATCH 3/3] arm64: dts: ipq6018: enable DVFS support Kathiravan T
2020-07-30 21:47   ` kernel test robot
2020-07-30 22:28 ` [PATCH 0/3] Enable DVFS support for IPQ6018 Mark Brown

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git