* Re: [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback
2021-03-19 15:50 [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback Loic Poulain
@ 2021-04-07 7:23 ` Loic Poulain
2021-04-07 8:14 ` Manivannan Sadhasivam
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Loic Poulain @ 2021-04-07 7:23 UTC (permalink / raw)
To: Manivannan Sadhasivam, Hemant Kumar; +Cc: linux-arm-msm
Hi Mani, Hemant
On Fri, 19 Mar 2021 at 16:42, Loic Poulain <loic.poulain@linaro.org> wrote:
>
> Deinit the device on shutdown to halt MHI/PCI operation on device
> side. This change fixes floating device state with some hosts that
> do not fully shutdown PCIe device when rebooting.
Any comments on this change?
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/bus/mhi/pci_generic.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index cbd2224..b104ab8 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -532,6 +532,12 @@ static void mhi_pci_remove(struct pci_dev *pdev)
> mhi_unregister_controller(mhi_cntrl);
> }
>
> +static void mhi_pci_shutdown(struct pci_dev *pdev)
> +{
> + mhi_pci_remove(pdev);
> + pci_set_power_state(pdev, PCI_D3hot);
> +}
> +
> static void mhi_pci_reset_prepare(struct pci_dev *pdev)
> {
> struct mhi_pci_device *mhi_pdev = pci_get_drvdata(pdev);
> @@ -704,6 +710,7 @@ static struct pci_driver mhi_pci_driver = {
> .id_table = mhi_pci_id_table,
> .probe = mhi_pci_probe,
> .remove = mhi_pci_remove,
> + .shutdown = mhi_pci_shutdown,
> .err_handler = &mhi_pci_err_handler,
> .driver.pm = &mhi_pci_pm_ops
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback
2021-03-19 15:50 [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback Loic Poulain
2021-04-07 7:23 ` Loic Poulain
@ 2021-04-07 8:14 ` Manivannan Sadhasivam
2021-04-07 8:16 ` Manivannan Sadhasivam
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-07 8:14 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, linux-arm-msm
On Fri, Mar 19, 2021 at 04:50:37PM +0100, Loic Poulain wrote:
> Deinit the device on shutdown to halt MHI/PCI operation on device
> side. This change fixes floating device state with some hosts that
> do not fully shutdown PCIe device when rebooting.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/pci_generic.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index cbd2224..b104ab8 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -532,6 +532,12 @@ static void mhi_pci_remove(struct pci_dev *pdev)
> mhi_unregister_controller(mhi_cntrl);
> }
>
> +static void mhi_pci_shutdown(struct pci_dev *pdev)
> +{
> + mhi_pci_remove(pdev);
> + pci_set_power_state(pdev, PCI_D3hot);
> +}
> +
> static void mhi_pci_reset_prepare(struct pci_dev *pdev)
> {
> struct mhi_pci_device *mhi_pdev = pci_get_drvdata(pdev);
> @@ -704,6 +710,7 @@ static struct pci_driver mhi_pci_driver = {
> .id_table = mhi_pci_id_table,
> .probe = mhi_pci_probe,
> .remove = mhi_pci_remove,
> + .shutdown = mhi_pci_shutdown,
> .err_handler = &mhi_pci_err_handler,
> .driver.pm = &mhi_pci_pm_ops
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback
2021-03-19 15:50 [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback Loic Poulain
2021-04-07 7:23 ` Loic Poulain
2021-04-07 8:14 ` Manivannan Sadhasivam
@ 2021-04-07 8:16 ` Manivannan Sadhasivam
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-07 8:16 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, linux-arm-msm
On Fri, Mar 19, 2021 at 04:50:37PM +0100, Loic Poulain wrote:
> Deinit the device on shutdown to halt MHI/PCI operation on device
> side. This change fixes floating device state with some hosts that
> do not fully shutdown PCIe device when rebooting.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/pci_generic.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index cbd2224..b104ab8 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -532,6 +532,12 @@ static void mhi_pci_remove(struct pci_dev *pdev)
> mhi_unregister_controller(mhi_cntrl);
> }
>
> +static void mhi_pci_shutdown(struct pci_dev *pdev)
> +{
> + mhi_pci_remove(pdev);
> + pci_set_power_state(pdev, PCI_D3hot);
> +}
> +
> static void mhi_pci_reset_prepare(struct pci_dev *pdev)
> {
> struct mhi_pci_device *mhi_pdev = pci_get_drvdata(pdev);
> @@ -704,6 +710,7 @@ static struct pci_driver mhi_pci_driver = {
> .id_table = mhi_pci_id_table,
> .probe = mhi_pci_probe,
> .remove = mhi_pci_remove,
> + .shutdown = mhi_pci_shutdown,
> .err_handler = &mhi_pci_err_handler,
> .driver.pm = &mhi_pci_pm_ops
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback
2021-03-19 15:50 [PATCH] bus: mhi: pci_generic: Implement PCI shutdown callback Loic Poulain
` (2 preceding siblings ...)
2021-04-07 8:16 ` Manivannan Sadhasivam
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
To: Loic Poulain; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Fri, 19 Mar 2021 16:50:37 +0100 you wrote:
> Deinit the device on shutdown to halt MHI/PCI operation on device
> side. This change fixes floating device state with some hosts that
> do not fully shutdown PCIe device when rebooting.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/bus/mhi/pci_generic.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Here is the summary with links:
- bus: mhi: pci_generic: Implement PCI shutdown callback
https://git.kernel.org/qcom/c/757072abe1c0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread