* [PATCH] phy: qcom-qmp: remove redundant error of clock bulk
@ 2021-04-09 3:07 Chunfeng Yun
2021-04-12 23:53 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Chunfeng Yun @ 2021-04-09 3:07 UTC (permalink / raw)
To: Bjorn Andersson, Vinod Koul
Cc: Andy Gross, Kishon Vijay Abraham I, Matthias Brugger,
linux-arm-msm, linux-kernel, linux-arm-kernel, linux-mediatek,
Chunfeng Yun
There is error log in clk_bulk_prepare/enable()
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 9cdebe7..f14b8be 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -3598,10 +3598,8 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy)
}
ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
- if (ret) {
- dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+ if (ret)
goto err_rst;
- }
if (cfg->has_phy_dp_com_ctrl) {
qphy_setbits(dp_com, QPHY_V3_DP_COM_POWER_DOWN_CTRL,
@@ -4035,10 +4033,8 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev)
}
ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
- if (ret) {
- dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+ if (ret)
return ret;
- }
ret = clk_prepare_enable(qphy->pipe_clk);
if (ret) {
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] phy: qcom-qmp: remove redundant error of clock bulk
2021-04-09 3:07 [PATCH] phy: qcom-qmp: remove redundant error of clock bulk Chunfeng Yun
@ 2021-04-12 23:53 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2021-04-12 23:53 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Vinod Koul, Andy Gross, Kishon Vijay Abraham I, Matthias Brugger,
linux-arm-msm, linux-kernel, linux-arm-kernel, linux-mediatek
On Thu 08 Apr 22:07 CDT 2021, Chunfeng Yun wrote:
> There is error log in clk_bulk_prepare/enable()
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 9cdebe7..f14b8be 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -3598,10 +3598,8 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy)
> }
>
> ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
> - if (ret) {
> - dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
> + if (ret)
> goto err_rst;
> - }
>
> if (cfg->has_phy_dp_com_ctrl) {
> qphy_setbits(dp_com, QPHY_V3_DP_COM_POWER_DOWN_CTRL,
> @@ -4035,10 +4033,8 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev)
> }
>
> ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
> - if (ret) {
> - dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
> + if (ret)
> return ret;
> - }
>
> ret = clk_prepare_enable(qphy->pipe_clk);
> if (ret) {
> --
> 1.8.1.1.dirty
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-12 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 3:07 [PATCH] phy: qcom-qmp: remove redundant error of clock bulk Chunfeng Yun
2021-04-12 23:53 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).