* [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log
@ 2021-04-09 1:54 Jia Yang
2021-04-09 6:35 ` Manivannan Sadhasivam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jia Yang @ 2021-04-09 1:54 UTC (permalink / raw)
To: adrian.hunter, agross, bjorn.andersson, ulf.hansson
Cc: linux-mmc, linux-arm-msm, linux-kernel
devm_ioremap_resource() has recorded error log, so it's
unnecessary to record log again.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jia Yang <jiayang5@huawei.com>
---
drivers/mmc/host/sdhci-msm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index d170c919e6e4..e44b7a66b73c 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
struct mmc_host *mmc = msm_host->mmc;
struct device *dev = mmc_dev(mmc);
struct resource *res;
- int err;
if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS))
return 0;
@@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
}
msm_host->ice_mem = devm_ioremap_resource(dev, res);
- if (IS_ERR(msm_host->ice_mem)) {
- err = PTR_ERR(msm_host->ice_mem);
- dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
- return err;
- }
+ if (IS_ERR(msm_host->ice_mem))
+ return PTR_ERR(msm_host->ice_mem);
if (!sdhci_msm_ice_supported(msm_host))
goto disable;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log
2021-04-09 1:54 [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log Jia Yang
@ 2021-04-09 6:35 ` Manivannan Sadhasivam
2021-04-12 7:52 ` Ulf Hansson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-09 6:35 UTC (permalink / raw)
To: Jia Yang
Cc: adrian.hunter, agross, bjorn.andersson, ulf.hansson, linux-mmc,
linux-arm-msm, linux-kernel
On Fri, Apr 09, 2021 at 09:54:24AM +0800, Jia Yang wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jia Yang <jiayang5@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/mmc/host/sdhci-msm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index d170c919e6e4..e44b7a66b73c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
> struct mmc_host *mmc = msm_host->mmc;
> struct device *dev = mmc_dev(mmc);
> struct resource *res;
> - int err;
>
> if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS))
> return 0;
> @@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
> }
>
> msm_host->ice_mem = devm_ioremap_resource(dev, res);
> - if (IS_ERR(msm_host->ice_mem)) {
> - err = PTR_ERR(msm_host->ice_mem);
> - dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
> - return err;
> - }
> + if (IS_ERR(msm_host->ice_mem))
> + return PTR_ERR(msm_host->ice_mem);
>
> if (!sdhci_msm_ice_supported(msm_host))
> goto disable;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log
2021-04-09 1:54 [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log Jia Yang
2021-04-09 6:35 ` Manivannan Sadhasivam
@ 2021-04-12 7:52 ` Ulf Hansson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2021-04-12 7:52 UTC (permalink / raw)
To: Jia Yang
Cc: Adrian Hunter, Andy Gross, Bjorn Andersson, linux-mmc,
linux-arm-msm, Linux Kernel Mailing List
On Fri, 9 Apr 2021 at 03:44, Jia Yang <jiayang5@huawei.com> wrote:
>
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jia Yang <jiayang5@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-msm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index d170c919e6e4..e44b7a66b73c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
> struct mmc_host *mmc = msm_host->mmc;
> struct device *dev = mmc_dev(mmc);
> struct resource *res;
> - int err;
>
> if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS))
> return 0;
> @@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host,
> }
>
> msm_host->ice_mem = devm_ioremap_resource(dev, res);
> - if (IS_ERR(msm_host->ice_mem)) {
> - err = PTR_ERR(msm_host->ice_mem);
> - dev_err(dev, "Failed to map ICE registers; err=%d\n", err);
> - return err;
> - }
> + if (IS_ERR(msm_host->ice_mem))
> + return PTR_ERR(msm_host->ice_mem);
>
> if (!sdhci_msm_ice_supported(msm_host))
> goto disable;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log
2021-04-09 1:54 [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log Jia Yang
2021-04-09 6:35 ` Manivannan Sadhasivam
2021-04-12 7:52 ` Ulf Hansson
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
To: Jia Yang; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Fri, 9 Apr 2021 09:54:24 +0800 you wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jia Yang <jiayang5@huawei.com>
> ---
> drivers/mmc/host/sdhci-msm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Here is the summary with links:
- [-next] mmc: sdhci-msm: Remove unnecessary error log
https://git.kernel.org/qcom/c/ffa4877c0a29
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-26 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 1:54 [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log Jia Yang
2021-04-09 6:35 ` Manivannan Sadhasivam
2021-04-12 7:52 ` Ulf Hansson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).