linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bus: mhi: core: Use mhi_soc_reset() API instead of register write
@ 2021-07-01 19:55 Bhaumik Bhatt
  2021-07-01 20:57 ` Hemant Kumar
  0 siblings, 1 reply; 2+ messages in thread
From: Bhaumik Bhatt @ 2021-07-01 19:55 UTC (permalink / raw)
  To: manivannan.sadhasivam; +Cc: linux-arm-msm, hemantk, linux-kernel, Bhaumik Bhatt

Currently, register writes are used when ramdump collection in
panic path occurs. Replace that with new mhi_soc_reset() API such
that a controller defined reset() function is exercised if one is
present and the regular SOC reset is done if it is not.

Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
---
 drivers/bus/mhi/core/boot.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
index 8100cf5..10a91df 100644
--- a/drivers/bus/mhi/core/boot.c
+++ b/drivers/bus/mhi/core/boot.c
@@ -112,9 +112,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
 			/* Hardware reset so force device to enter RDDM */
 			dev_dbg(dev,
 				"Did not enter RDDM, do a host req reset\n");
-			mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
-				      MHI_SOC_RESET_REQ_OFFSET,
-				      MHI_SOC_RESET_REQ);
+			mhi_soc_reset(mhi_cntrl);
 			udelay(delayus);
 		}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bus: mhi: core: Use mhi_soc_reset() API instead of register write
  2021-07-01 19:55 [PATCH] bus: mhi: core: Use mhi_soc_reset() API instead of register write Bhaumik Bhatt
@ 2021-07-01 20:57 ` Hemant Kumar
  0 siblings, 0 replies; 2+ messages in thread
From: Hemant Kumar @ 2021-07-01 20:57 UTC (permalink / raw)
  To: Bhaumik Bhatt, manivannan.sadhasivam; +Cc: linux-arm-msm, linux-kernel

On Thu, 2021-07-01 at 12:55 -0700, Bhaumik Bhatt wrote:
> Currently, register writes are used when ramdump collection in
> panic path occurs. Replace that with new mhi_soc_reset() API such
> that a controller defined reset() function is exercised if one is
> present and the regular SOC reset is done if it is not.
> 
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-01 20:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01 19:55 [PATCH] bus: mhi: core: Use mhi_soc_reset() API instead of register write Bhaumik Bhatt
2021-07-01 20:57 ` Hemant Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).