From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: mani@kernel.org, loic.poulain@linaro.org,
butterflyhuangxx@gmail.com, davem@davemloft.net, kuba@kernel.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter
Date: Mon, 30 Aug 2021 11:30:06 +0000 [thread overview]
Message-ID: <163032300690.3135.17165027106916962159.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210830083717.GU7722@kadam>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 30 Aug 2021 11:37:17 +0300 you wrote:
> These checks are still not strict enough. The main problem is that if
> "cb->type == QRTR_TYPE_NEW_SERVER" is true then "len - hdrlen" is
> guaranteed to be 4 but we need to be at least 16 bytes. In fact, we
> can reject everything smaller than sizeof(*pkt) which is 20 bytes.
>
> Also I don't like the ALIGN(size, 4). It's better to just insist that
> data is needs to be aligned at the start.
>
> [...]
Here is the summary with links:
- [v2,net] net: qrtr: make checks in qrtr_endpoint_post() stricter
https://git.kernel.org/netdev/net-next/c/aaa8e4922c88
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-08-30 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 13:24 [PATCH net-next] net: qrtr: make checks in qrtr_endpoint_post() stricter Dan Carpenter
2021-08-27 15:35 ` butt3rflyh4ck
2021-08-27 17:17 ` Dan Carpenter
2021-08-30 8:37 ` [PATCH v2 net] " Dan Carpenter
2021-08-30 11:30 ` patchwork-bot+netdevbpf [this message]
2021-09-03 19:29 Yassine Oudjana
2021-09-06 6:53 ` Dan Carpenter
2021-09-15 17:30 ` Steev Klimaszewski
2021-09-15 18:40 ` Yassine Oudjana
2021-09-15 21:58 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163032300690.3135.17165027106916962159.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=butterflyhuangxx@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).