From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yassine Oudjana <y.oudjana@protonmail.com>
Cc: bjorn.andersson@linaro.org, butterflyhuangxx@gmail.com,
davem@davemloft.net, kuba@kernel.org,
linux-arm-msm@vger.kernel.org, loic.poulain@linaro.org,
mani@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter
Date: Mon, 6 Sep 2021 09:53:20 +0300 [thread overview]
Message-ID: <20210906065320.GC1935@kadam> (raw)
In-Reply-To: <S4IVYQ.R543O8OZ1IFR3@protonmail.com>
On Fri, Sep 03, 2021 at 07:29:28PM +0000, Yassine Oudjana wrote:
> > if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
> > @@ -506,8 +506,12 @@ int qrtr_endpoint_post(struct qrtr_endpoint
> *ep, const void *data, size_t len)
> >
> > if (cb->type == QRTR_TYPE_NEW_SERVER) {
> > /* Remote node endpoint can bridge other distant nodes */
> > - const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
> > + const struct qrtr_ctrl_pkt *pkt;
> >
> > + if (size < sizeof(*pkt))
> > + goto err;
> > +
> > + pkt = data + hdrlen;
> > qrtr_node_assign(node, le32_to_cpu(pkt->server.node));
> > }
> >
> > --
> > 2.20.1
> >
>
> This is crashing MSM8996. I get these messages (dmesg | grep
> remoteproc):
Yes. I apologize for that. The fix has been merged already.
regards,
dan carpenter
next prev parent reply other threads:[~2021-09-06 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 19:29 [PATCH v2 net] net: qrtr: make checks in qrtr_endpoint_post() stricter Yassine Oudjana
2021-09-06 6:53 ` Dan Carpenter [this message]
2021-09-15 17:30 ` Steev Klimaszewski
2021-09-15 18:40 ` Yassine Oudjana
2021-09-15 21:58 ` Steev Klimaszewski
-- strict thread matches above, loose matches on Subject: below --
2021-08-27 15:35 [PATCH net-next] " butt3rflyh4ck
2021-08-30 8:37 ` [PATCH v2 net] " Dan Carpenter
2021-08-30 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906065320.GC1935@kadam \
--to=dan.carpenter@oracle.com \
--cc=bjorn.andersson@linaro.org \
--cc=butterflyhuangxx@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).