* [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
@ 2022-09-15 14:16 Johan Hovold
2022-09-15 15:09 ` Bjorn Andersson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Johan Hovold @ 2022-09-15 14:16 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold
The size of the UFS PHY serdes register region is 0x1c8 and the
corresponding 'reg' property should specifically not include the
adjacent regions that are defined in the child node (e.g. tx and rx).
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 4b85c9276435..638317f78ab2 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1432,7 +1432,7 @@ ufs_mem_hc: ufs@1d84000 {
ufs_mem_phy: phy@1d87000 {
compatible = "qcom,sc8280xp-qmp-ufs-phy";
- reg = <0 0x01d87000 0 0xe10>;
+ reg = <0 0x01d87000 0 0x1c8>;
#address-cells = <2>;
#size-cells = <2>;
ranges;
@@ -1500,7 +1500,7 @@ ufs_card_hc: ufs@1da4000 {
ufs_card_phy: phy@1da7000 {
compatible = "qcom,sc8280xp-qmp-ufs-phy";
- reg = <0 0x01da7000 0 0xe10>;
+ reg = <0 0x01da7000 0 0x1c8>;
#address-cells = <2>;
#size-cells = <2>;
ranges;
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
2022-09-15 14:16 [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size Johan Hovold
@ 2022-09-15 15:09 ` Bjorn Andersson
2022-09-20 8:53 ` Johan Hovold
2022-10-03 17:46 ` Brian Masney
2022-10-18 3:05 ` Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2022-09-15 15:09 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> The size of the UFS PHY serdes register region is 0x1c8 and the
> corresponding 'reg' property should specifically not include the
> adjacent regions that are defined in the child node (e.g. tx and rx).
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 4b85c9276435..638317f78ab2 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1432,7 +1432,7 @@ ufs_mem_hc: ufs@1d84000 {
>
> ufs_mem_phy: phy@1d87000 {
> compatible = "qcom,sc8280xp-qmp-ufs-phy";
> - reg = <0 0x01d87000 0 0xe10>;
> + reg = <0 0x01d87000 0 0x1c8>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> @@ -1500,7 +1500,7 @@ ufs_card_hc: ufs@1da4000 {
>
> ufs_card_phy: phy@1da7000 {
> compatible = "qcom,sc8280xp-qmp-ufs-phy";
> - reg = <0 0x01da7000 0 0xe10>;
> + reg = <0 0x01da7000 0 0x1c8>;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
2022-09-15 15:09 ` Bjorn Andersson
@ 2022-09-20 8:53 ` Johan Hovold
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2022-09-20 8:53 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Johan Hovold, Andy Gross, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On Thu, Sep 15, 2022 at 10:09:07AM -0500, Bjorn Andersson wrote:
> On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> > The size of the UFS PHY serdes register region is 0x1c8 and the
> > corresponding 'reg' property should specifically not include the
> > adjacent regions that are defined in the child node (e.g. tx and rx).
> >
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
I can't seem to find this one in either the arm64-for-6.1 or fixes
branch for 6.0. Did you just forget to push it?
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
2022-09-15 14:16 [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size Johan Hovold
2022-09-15 15:09 ` Bjorn Andersson
@ 2022-10-03 17:46 ` Brian Masney
2022-10-03 19:30 ` Andrew Halaney
2022-10-18 3:05 ` Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Brian Masney @ 2022-10-03 17:46 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> The size of the UFS PHY serdes register region is 0x1c8 and the
> corresponding 'reg' property should specifically not include the
> adjacent regions that are defined in the child node (e.g. tx and rx).
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
This fixes an issue that I'm seeing on the QDrive3 in next-20220930.
Reviewed-by: Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
2022-10-03 17:46 ` Brian Masney
@ 2022-10-03 19:30 ` Andrew Halaney
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Halaney @ 2022-10-03 19:30 UTC (permalink / raw)
To: Brian Masney
Cc: Johan Hovold, Bjorn Andersson, Andy Gross, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On Mon, Oct 03, 2022 at 01:46:29PM -0400, Brian Masney wrote:
> On Thu, Sep 15, 2022 at 04:16:01PM +0200, Johan Hovold wrote:
> > The size of the UFS PHY serdes register region is 0x1c8 and the
> > corresponding 'reg' property should specifically not include the
> > adjacent regions that are defined in the child node (e.g. tx and rx).
> >
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> This fixes an issue that I'm seeing on the QDrive3 in next-20220930.
>
> Reviewed-by: Brian Masney <bmasney@redhat.com>
>
Tested-by: Andrew Halaney <ahalaney@redhat.com> #Qdrive3/sa8540p-adp-ride
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
2022-09-15 14:16 [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size Johan Hovold
2022-09-15 15:09 ` Bjorn Andersson
2022-10-03 17:46 ` Brian Masney
@ 2022-10-18 3:05 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-10-18 3:05 UTC (permalink / raw)
To: johan+linaro
Cc: devicetree, linux-kernel, agross, robh+dt, linux-arm-msm,
Krzysztof Kozlowski, Konrad Dybcio
On Thu, 15 Sep 2022 16:16:01 +0200, Johan Hovold wrote:
> The size of the UFS PHY serdes register region is 0x1c8 and the
> corresponding 'reg' property should specifically not include the
> adjacent regions that are defined in the child node (e.g. tx and rx).
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size
commit: 8703d55bd5eac642275fe91b34ac62ad0ad312b5
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-18 3:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 14:16 [PATCH] arm64: dts: qcom: sc8280xp: fix UFS PHY serdes size Johan Hovold
2022-09-15 15:09 ` Bjorn Andersson
2022-09-20 8:53 ` Johan Hovold
2022-10-03 17:46 ` Brian Masney
2022-10-03 19:30 ` Andrew Halaney
2022-10-18 3:05 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).