* [PATCH v5 1/7] dt-bindings: phy: Add qcom,snps-eusb2-repeater schema file
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
@ 2023-02-08 19:01 ` Abel Vesa
2023-02-08 19:01 ` [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy Abel Vesa
` (7 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List,
Krzysztof Kozlowski
The SM8550 SoC uses Synopsis eUSB2 repeater found in PM8550b.
Add a dt-binding schema for the new driver.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-2-abel.vesa@linaro.org/
Changes since v4:
* added Krzysztof R-b tag
* added description about what the eUSB repeater does
Changes since v3:
* made this patch the first one in the series to fix the binding check
for the 2nd patch.
* dropped the compatible for pmic in the example. This is due to the
dependency between this patch and the next one.
.../phy/qcom,snps-eusb2-repeater.yaml | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
new file mode 100644
index 000000000000..083fda530b48
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/qcom,snps-eusb2-repeater.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Synopsis eUSB2 to USB 2.0 repeater
+
+maintainers:
+ - Abel Vesa <abel.vesa@linaro.org>
+
+description:
+ eUSB2 repeater converts between eUSB2 and USB 2.0 signaling levels and
+ allows a eUSB2 PHY to connect to legacy USB 2.0 products
+
+properties:
+ compatible:
+ const: qcom,pm8550b-eusb2-repeater
+
+ reg:
+ maxItems: 1
+
+ "#phy-cells":
+ const: 0
+
+ vdd18-supply: true
+
+ vdd3-supply: true
+
+required:
+ - compatible
+ - reg
+ - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/spmi/spmi.h>
+
+ pmic@7 {
+ reg = <0x7 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pm8550b_eusb2_repeater: phy@fd00 {
+ compatible = "qcom,pm8550b-eusb2-repeater";
+ reg = <0xfd00>;
+ #phy-cells = <0>;
+ };
+ };
+...
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
2023-02-08 19:01 ` [PATCH v5 1/7] dt-bindings: phy: Add qcom,snps-eusb2-repeater schema file Abel Vesa
@ 2023-02-08 19:01 ` Abel Vesa
2023-02-10 11:43 ` Krzysztof Kozlowski
2023-02-14 15:36 ` Vinod Koul
2023-02-08 19:01 ` [PATCH v5 3/7] dt-bindings: phy: qcom,snps-eusb2-phy: Add phys property for the repeater Abel Vesa
` (6 subsequent siblings)
8 siblings, 2 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List
The phy pattern property will be used for providing eUSB2 repeater
functionality. This will be modelled as a Qualcomm PHY driver.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-3-abel.vesa@linaro.org/
Changes since v4:
* none
Changes since v3:
* made this the second patch rather than the first in the series
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index adf88245c409..1e6fadec1301 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -135,6 +135,10 @@ patternProperties:
type: object
$ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
+ "phy@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/phy/qcom,snps-eusb2-repeater.yaml#
+
"pon@[0-9a-f]+$":
type: object
$ref: /schemas/power/reset/qcom,pon.yaml#
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy
2023-02-08 19:01 ` [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy Abel Vesa
@ 2023-02-10 11:43 ` Krzysztof Kozlowski
2023-02-14 15:36 ` Vinod Koul
1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-10 11:43 UTC (permalink / raw)
To: Abel Vesa, Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List
On 08/02/2023 20:01, Abel Vesa wrote:
> The phy pattern property will be used for providing eUSB2 repeater
> functionality. This will be modelled as a Qualcomm PHY driver.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy
2023-02-08 19:01 ` [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy Abel Vesa
2023-02-10 11:43 ` Krzysztof Kozlowski
@ 2023-02-14 15:36 ` Vinod Koul
2023-02-22 15:16 ` Lee Jones
1 sibling, 1 reply; 13+ messages in thread
From: Vinod Koul @ 2023-02-14 15:36 UTC (permalink / raw)
To: Abel Vesa, Lee Jones
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Kishon Vijay Abraham I, Johan Hovold,
linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List
On 08-02-23, 21:01, Abel Vesa wrote:
> The phy pattern property will be used for providing eUSB2 repeater
> functionality. This will be modelled as a Qualcomm PHY driver.
Lee,
Can I get your ack and merge this thru phy tree
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> The v4 is here:
> https://lore.kernel.org/all/20230207135551.1418637-3-abel.vesa@linaro.org/
>
> Changes since v4:
> * none
>
> Changes since v3:
> * made this the second patch rather than the first in the series
>
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index adf88245c409..1e6fadec1301 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -135,6 +135,10 @@ patternProperties:
> type: object
> $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
>
> + "phy@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/phy/qcom,snps-eusb2-repeater.yaml#
> +
> "pon@[0-9a-f]+$":
> type: object
> $ref: /schemas/power/reset/qcom,pon.yaml#
> --
> 2.34.1
--
~Vinod
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy
2023-02-14 15:36 ` Vinod Koul
@ 2023-02-22 15:16 ` Lee Jones
0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2023-02-22 15:16 UTC (permalink / raw)
To: Vinod Koul
Cc: Abel Vesa, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Kishon Vijay Abraham I,
Johan Hovold, linux-arm-msm, linux-phy, devicetree,
Linux Kernel Mailing List
On Tue, 14 Feb 2023, Vinod Koul wrote:
> On 08-02-23, 21:01, Abel Vesa wrote:
> > The phy pattern property will be used for providing eUSB2 repeater
> > functionality. This will be modelled as a Qualcomm PHY driver.
>
> Lee,
>
> Can I get your ack and merge this thru phy tree
Acked-by: Lee Jones <lee@kernel.org>
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >
> > The v4 is here:
> > https://lore.kernel.org/all/20230207135551.1418637-3-abel.vesa@linaro.org/
> >
> > Changes since v4:
> > * none
> >
> > Changes since v3:
> > * made this the second patch rather than the first in the series
> >
> > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > index adf88245c409..1e6fadec1301 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > @@ -135,6 +135,10 @@ patternProperties:
> > type: object
> > $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
> >
> > + "phy@[0-9a-f]+$":
> > + type: object
> > + $ref: /schemas/phy/qcom,snps-eusb2-repeater.yaml#
> > +
> > "pon@[0-9a-f]+$":
> > type: object
> > $ref: /schemas/power/reset/qcom,pon.yaml#
> > --
> > 2.34.1
>
> --
> ~Vinod
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v5 3/7] dt-bindings: phy: qcom,snps-eusb2-phy: Add phys property for the repeater
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
2023-02-08 19:01 ` [PATCH v5 1/7] dt-bindings: phy: Add qcom,snps-eusb2-repeater schema file Abel Vesa
2023-02-08 19:01 ` [PATCH v5 2/7] dt-bindings: mfd: qcom,spmi-pmic: Add pattern property for phy Abel Vesa
@ 2023-02-08 19:01 ` Abel Vesa
2023-02-08 19:01 ` [PATCH v5 4/7] phy: qcom: Add QCOM SNPS eUSB2 repeater driver Abel Vesa
` (5 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List,
Krzysztof Kozlowski
The phys property is used for allowing the eusb2 to interface
with the repeater, which is modelled as a phy driver.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-4-abel.vesa@linaro.org/
Changes since v4:
* added Krzysztof's A-b tag
Changes since v3:
* dropped the phy-names property and changed the commit message
accordingly
.../devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
index de72577e34a4..c53bab107b6d 100644
--- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
@@ -33,6 +33,11 @@ properties:
resets:
maxItems: 1
+ phys:
+ maxItems: 1
+ description:
+ Phandle to eUSB2 to USB 2.0 repeater
+
vdd-supply:
description:
Phandle to 0.88V regulator supply to PHY digital circuit.
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 4/7] phy: qcom: Add QCOM SNPS eUSB2 repeater driver
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
` (2 preceding siblings ...)
2023-02-08 19:01 ` [PATCH v5 3/7] dt-bindings: phy: qcom,snps-eusb2-phy: Add phys property for the repeater Abel Vesa
@ 2023-02-08 19:01 ` Abel Vesa
2023-02-08 19:01 ` [PATCH v5 5/7] phy: qcom: phy-qcom-snps-eusb2: Add support for eUSB2 repeater Abel Vesa
` (4 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List
PM8550B contains a eUSB2 repeater used for making the eUSB2 from
SM8550 USB 2.0 compliant. This can be modelled SW-wise as a Phy.
So add a new phy driver for it.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-5-abel.vesa@linaro.org/
Changes since v4:
* none
Changes since v3:
* fixed all indentation issues and dropped a few blank lines to pass
checkpatch
* dropped shift defines as they were not used
* dropped the repeater_mode as it was not used
* dropped the of_node_get and of_node_put for of_node
* dropped the comment related to regulators in eusb2_repeater_cfg, like
Vinod suggested
* dropped the initialization of ret in eusb2_repeater_init
drivers/phy/qualcomm/Kconfig | 9 +
drivers/phy/qualcomm/Makefile | 1 +
.../phy/qualcomm/phy-qcom-eusb2-repeater.c | 259 ++++++++++++++++++
3 files changed, 269 insertions(+)
create mode 100644 drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
index 513322cdf83c..4850d48f31fa 100644
--- a/drivers/phy/qualcomm/Kconfig
+++ b/drivers/phy/qualcomm/Kconfig
@@ -121,6 +121,15 @@ config PHY_QCOM_SNPS_EUSB2
chipsets. The PHY is paired with a Synopsys DWC3 USB controller
on Qualcomm SOCs.
+config PHY_QCOM_EUSB2_REPEATER
+ tristate "Qualcomm SNPS eUSB2 Repeater Driver"
+ depends on OF && (ARCH_QCOM || COMPILE_TEST)
+ select GENERIC_PHY
+ help
+ Enable support for the USB high-speed SNPS eUSB2 repeater on Qualcomm
+ PMICs. The repeater is paired with a Synopsys eUSB2 Phy
+ on Qualcomm SOCs.
+
config PHY_QCOM_USB_HS
tristate "Qualcomm USB HS PHY module"
depends on USB_ULPI_BUS
diff --git a/drivers/phy/qualcomm/Makefile b/drivers/phy/qualcomm/Makefile
index b2c01665622b..de3dc9ccf067 100644
--- a/drivers/phy/qualcomm/Makefile
+++ b/drivers/phy/qualcomm/Makefile
@@ -14,6 +14,7 @@ obj-$(CONFIG_PHY_QCOM_QMP_USB) += phy-qcom-qmp-usb.o
obj-$(CONFIG_PHY_QCOM_QUSB2) += phy-qcom-qusb2.o
obj-$(CONFIG_PHY_QCOM_SNPS_EUSB2) += phy-qcom-snps-eusb2.o
+obj-$(CONFIG_PHY_QCOM_EUSB2_REPEATER) += phy-qcom-eusb2-repeater.o
obj-$(CONFIG_PHY_QCOM_USB_HS) += phy-qcom-usb-hs.o
obj-$(CONFIG_PHY_QCOM_USB_HSIC) += phy-qcom-usb-hsic.o
obj-$(CONFIG_PHY_QCOM_USB_HS_28NM) += phy-qcom-usb-hs-28nm.o
diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
new file mode 100644
index 000000000000..3f265ac2df20
--- /dev/null
+++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2023, Linaro Limited
+ */
+
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/regulator/consumer.h>
+#include <linux/regmap.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/phy/phy.h>
+
+/* eUSB2 status registers */
+#define EUSB2_RPTR_STATUS 0x08
+#define RPTR_OK BIT(7)
+
+/* eUSB2 control registers */
+#define EUSB2_EN_CTL1 0x46
+#define EUSB2_RPTR_EN BIT(7)
+
+#define EUSB2_FORCE_EN_5 0xe8
+#define F_CLK_19P2M_EN BIT(6)
+
+#define EUSB2_FORCE_VAL_5 0xeD
+#define V_CLK_19P2M_EN BIT(6)
+
+#define EUSB2_TUNE_IUSB2 0x51
+#define EUSB2_TUNE_SQUELCH_U 0x54
+#define EUSB2_TUNE_USB2_PREEM 0x57
+
+#define QCOM_EUSB2_REPEATER_INIT_CFG(o, v) \
+ { \
+ .offset = o, \
+ .val = v, \
+ }
+
+struct eusb2_repeater_init_tbl {
+ unsigned int offset;
+ unsigned int val;
+};
+
+struct eusb2_repeater_cfg {
+ const struct eusb2_repeater_init_tbl *init_tbl;
+ int init_tbl_num;
+ const char * const *vreg_list;
+ int num_vregs;
+};
+
+struct eusb2_repeater {
+ struct device *dev;
+ struct regmap *regmap;
+ struct phy *phy;
+ struct regulator_bulk_data *vregs;
+ const struct eusb2_repeater_cfg *cfg;
+ u16 base;
+ enum phy_mode mode;
+};
+
+static const char * const pm8550b_vreg_l[] = {
+ "vdd18", "vdd3",
+};
+
+static const struct eusb2_repeater_init_tbl pm8550b_init_tbl[] = {
+ QCOM_EUSB2_REPEATER_INIT_CFG(EUSB2_TUNE_IUSB2, 0x8),
+ QCOM_EUSB2_REPEATER_INIT_CFG(EUSB2_TUNE_SQUELCH_U, 0x3),
+ QCOM_EUSB2_REPEATER_INIT_CFG(EUSB2_TUNE_USB2_PREEM, 0x5),
+};
+
+static const struct eusb2_repeater_cfg pm8550b_eusb2_cfg = {
+ .init_tbl = pm8550b_init_tbl,
+ .init_tbl_num = ARRAY_SIZE(pm8550b_init_tbl),
+ .vreg_list = pm8550b_vreg_l,
+ .num_vregs = ARRAY_SIZE(pm8550b_vreg_l),
+};
+
+static int eusb2_repeater_init_vregs(struct eusb2_repeater *rptr)
+{
+ int num = rptr->cfg->num_vregs;
+ struct device *dev = rptr->dev;
+ int i;
+
+ rptr->vregs = devm_kcalloc(dev, num, sizeof(*rptr->vregs), GFP_KERNEL);
+ if (!rptr->vregs)
+ return -ENOMEM;
+
+ for (i = 0; i < num; i++)
+ rptr->vregs[i].supply = rptr->cfg->vreg_list[i];
+
+ return devm_regulator_bulk_get(dev, num, rptr->vregs);
+}
+
+static int eusb2_repeater_init(struct phy *phy)
+{
+ struct eusb2_repeater *rptr = phy_get_drvdata(phy);
+ const struct eusb2_repeater_init_tbl *init_tbl = rptr->cfg->init_tbl;
+ int num = rptr->cfg->init_tbl_num;
+ u32 val;
+ int ret;
+ int i;
+
+ ret = regulator_bulk_enable(rptr->cfg->num_vregs, rptr->vregs);
+ if (ret)
+ return ret;
+
+ regmap_update_bits(rptr->regmap, rptr->base + EUSB2_EN_CTL1,
+ EUSB2_RPTR_EN, EUSB2_RPTR_EN);
+
+ for (i = 0; i < num; i++)
+ regmap_update_bits(rptr->regmap,
+ rptr->base + init_tbl[i].offset,
+ init_tbl[i].val, init_tbl[i].val);
+
+ ret = regmap_read_poll_timeout(rptr->regmap,
+ rptr->base + EUSB2_RPTR_STATUS, val,
+ val & RPTR_OK, 10, 5);
+ if (ret)
+ dev_err(rptr->dev, "initialization timed-out\n");
+
+ return ret;
+}
+
+static int eusb2_repeater_set_mode(struct phy *phy,
+ enum phy_mode mode, int submode)
+{
+ struct eusb2_repeater *rptr = phy_get_drvdata(phy);
+
+ switch (mode) {
+ case PHY_MODE_USB_HOST:
+ /*
+ * CM.Lx is prohibited when repeater is already into Lx state as
+ * per eUSB 1.2 Spec. Below implement software workaround until
+ * PHY and controller is fixing seen observation.
+ */
+ regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_EN_5,
+ F_CLK_19P2M_EN, F_CLK_19P2M_EN);
+ regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_VAL_5,
+ V_CLK_19P2M_EN, V_CLK_19P2M_EN);
+ break;
+ case PHY_MODE_USB_DEVICE:
+ /*
+ * In device mode clear host mode related workaround as there
+ * is no repeater reset available, and enable/disable of
+ * repeater doesn't clear previous value due to shared
+ * regulators (say host <-> device mode switch).
+ */
+ regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_EN_5,
+ F_CLK_19P2M_EN, 0);
+ regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_VAL_5,
+ V_CLK_19P2M_EN, 0);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static int eusb2_repeater_exit(struct phy *phy)
+{
+ struct eusb2_repeater *rptr = phy_get_drvdata(phy);
+
+ return regulator_bulk_disable(rptr->cfg->num_vregs, rptr->vregs);
+}
+
+static const struct phy_ops eusb2_repeater_ops = {
+ .init = eusb2_repeater_init,
+ .exit = eusb2_repeater_exit,
+ .set_mode = eusb2_repeater_set_mode,
+ .owner = THIS_MODULE,
+};
+
+static int eusb2_repeater_probe(struct platform_device *pdev)
+{
+ struct eusb2_repeater *rptr;
+ struct device *dev = &pdev->dev;
+ struct phy_provider *phy_provider;
+ struct device_node *np = dev->of_node;
+ u32 res;
+ int ret;
+
+ rptr = devm_kzalloc(dev, sizeof(*rptr), GFP_KERNEL);
+ if (!rptr)
+ return -ENOMEM;
+
+ rptr->dev = dev;
+ dev_set_drvdata(dev, rptr);
+
+ rptr->cfg = of_device_get_match_data(dev);
+ if (!rptr->cfg)
+ return -EINVAL;
+
+ rptr->regmap = dev_get_regmap(dev->parent, NULL);
+ if (!rptr->regmap)
+ return -ENODEV;
+
+ ret = of_property_read_u32(np, "reg", &res);
+ if (ret < 0)
+ return ret;
+
+ rptr->base = res;
+
+ ret = eusb2_repeater_init_vregs(rptr);
+ if (ret < 0) {
+ dev_err(dev, "unable to get supplies\n");
+ return ret;
+ }
+
+ rptr->phy = devm_phy_create(dev, np, &eusb2_repeater_ops);
+ if (IS_ERR(rptr->phy)) {
+ dev_err(dev, "failed to create PHY: %d\n", ret);
+ return PTR_ERR(rptr->phy);
+ }
+
+ phy_set_drvdata(rptr->phy, rptr);
+
+ phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+ if (IS_ERR(phy_provider))
+ return PTR_ERR(phy_provider);
+
+ dev_info(dev, "Registered Qcom-eUSB2 repeater\n");
+
+ return 0;
+}
+
+static int eusb2_repeater_remove(struct platform_device *pdev)
+{
+ struct eusb2_repeater *rptr = platform_get_drvdata(pdev);
+
+ if (!rptr)
+ return 0;
+
+ eusb2_repeater_exit(rptr->phy);
+
+ return 0;
+}
+
+static const struct of_device_id eusb2_repeater_of_match_table[] = {
+ {
+ .compatible = "qcom,pm8550b-eusb2-repeater",
+ .data = &pm8550b_eusb2_cfg,
+ },
+ { },
+};
+MODULE_DEVICE_TABLE(of, eusb2_repeater_of_match_table);
+
+static struct platform_driver eusb2_repeater_driver = {
+ .probe = eusb2_repeater_probe,
+ .remove = eusb2_repeater_remove,
+ .driver = {
+ .name = "qcom-eusb2-repeater",
+ .of_match_table = eusb2_repeater_of_match_table,
+ },
+};
+
+module_platform_driver(eusb2_repeater_driver);
+
+MODULE_DESCRIPTION("Qualcomm PMIC eUSB2 Repeater driver");
+MODULE_LICENSE("GPL");
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 5/7] phy: qcom: phy-qcom-snps-eusb2: Add support for eUSB2 repeater
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
` (3 preceding siblings ...)
2023-02-08 19:01 ` [PATCH v5 4/7] phy: qcom: Add QCOM SNPS eUSB2 repeater driver Abel Vesa
@ 2023-02-08 19:01 ` Abel Vesa
2023-02-08 19:01 ` [PATCH v5 6/7] arm64: dts: qcom: pm8550b: Add eUSB2 repeater node Abel Vesa
` (3 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List,
Neil Armstrong
From: Neil Armstrong <neil.armstrong@linaro.org>
For USB 2.0 compliance, eUSB2 needs a repeater. The PHY needs to
initialize and reset it. So add repeater support
Co-developed-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-6-abel.vesa@linaro.org/
Changes since v4:
* none
Changes since v3:
* none
drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
index 40a421cf3dd9..ca1cfa53d90d 100644
--- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
@@ -128,6 +128,8 @@ struct qcom_snps_eusb2_hsphy {
struct regulator_bulk_data vregs[EUSB2_NUM_VREGS];
enum phy_mode mode;
+
+ struct phy *repeater;
};
static int qcom_snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode)
@@ -136,7 +138,7 @@ static int qcom_snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int
phy->mode = mode;
- return 0;
+ return phy_set_mode_ext(phy->repeater, mode, submode);
}
static void qcom_snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset,
@@ -234,6 +236,12 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p)
if (ret)
return ret;
+ ret = phy_init(phy->repeater);
+ if (ret) {
+ dev_err(&p->dev, "repeater init failed. %d\n", ret);
+ goto disable_vreg;
+ }
+
ret = clk_prepare_enable(phy->ref_clk);
if (ret) {
dev_err(&p->dev, "failed to enable ref clock, %d\n", ret);
@@ -341,6 +349,8 @@ static int qcom_snps_eusb2_hsphy_exit(struct phy *p)
regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs);
+ phy_exit(phy->repeater);
+
return 0;
}
@@ -354,6 +364,7 @@ static const struct phy_ops qcom_snps_eusb2_hsphy_ops = {
static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ struct device_node *np = dev->of_node;
struct qcom_snps_eusb2_hsphy *phy;
struct phy_provider *phy_provider;
struct phy *generic_phy;
@@ -385,6 +396,12 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
if (ret)
return dev_err_probe(dev, ret,
"failed to get regulator supplies\n");
+
+ phy->repeater = devm_of_phy_get_by_index(dev, np, 0);
+ if (IS_ERR(phy->repeater))
+ return dev_err_probe(dev, PTR_ERR(phy->repeater),
+ "failed to get repeater\n");
+
generic_phy = devm_phy_create(dev, NULL, &qcom_snps_eusb2_hsphy_ops);
if (IS_ERR(generic_phy)) {
dev_err(dev, "failed to create phy %d\n", ret);
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 6/7] arm64: dts: qcom: pm8550b: Add eUSB2 repeater node
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
` (4 preceding siblings ...)
2023-02-08 19:01 ` [PATCH v5 5/7] phy: qcom: phy-qcom-snps-eusb2: Add support for eUSB2 repeater Abel Vesa
@ 2023-02-08 19:01 ` Abel Vesa
2023-02-08 19:02 ` [PATCH v5 7/7] arm64: dts: qcom: sm8550-mtp: " Abel Vesa
` (2 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List,
Neil Armstrong
From: Neil Armstrong <neil.armstrong@linaro.org>
Add nodes for the eUSB2 repeater found on the pm8550b SPMI PMIC.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-7-abel.vesa@linaro.org/
Changes since v4:
* none
Changes since v3:
* none
arch/arm64/boot/dts/qcom/pm8550b.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8550b.dtsi b/arch/arm64/boot/dts/qcom/pm8550b.dtsi
index 16bcfb64d735..72609f31c890 100644
--- a/arch/arm64/boot/dts/qcom/pm8550b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8550b.dtsi
@@ -55,5 +55,11 @@ pm8550b_gpios: gpio@8800 {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pm8550b_eusb2_repeater: phy@fd00 {
+ compatible = "qcom,pm8550b-eusb2-repeater";
+ reg = <0xfd00>;
+ #phy-cells = <0>;
+ };
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v5 7/7] arm64: dts: qcom: sm8550-mtp: Add eUSB2 repeater node
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
` (5 preceding siblings ...)
2023-02-08 19:01 ` [PATCH v5 6/7] arm64: dts: qcom: pm8550b: Add eUSB2 repeater node Abel Vesa
@ 2023-02-08 19:02 ` Abel Vesa
2023-02-16 13:12 ` [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Vinod Koul
2023-03-15 23:34 ` (subset) " Bjorn Andersson
8 siblings, 0 replies; 13+ messages in thread
From: Abel Vesa @ 2023-02-08 19:02 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, vkoul, Kishon Vijay Abraham I,
Johan Hovold
Cc: linux-arm-msm, linux-phy, devicetree, Linux Kernel Mailing List
Add the PMIC eUSB2 repeater node and add the usb-repeater
property to the eUSB2 PHY to allow it to be controlled by the
PHY driver.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
The v4 is here:
https://lore.kernel.org/all/20230207135551.1418637-8-abel.vesa@linaro.org/
Changes since v4:
* none
Changes since v3:
* Dropped the phy-names property from usb_1_hsphy, like Dmitry suggested
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 56aab7cafcbc..6b6ec0fe5e5e 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -457,6 +457,11 @@ sdc2_card_det_n: sdc2-card-det-state {
};
};
+&pm8550b_eusb2_repeater {
+ vdd18-supply = <&vreg_l15b_1p8>;
+ vdd3-supply = <&vreg_l5b_3p1>;
+};
+
&qupv3_id_0 {
status = "okay";
};
@@ -563,6 +568,8 @@ &usb_1_hsphy {
vdd-supply = <&vreg_l1e_0p88>;
vdda12-supply = <&vreg_l3e_1p2>;
+ phys = <&pm8550b_eusb2_repeater>;
+
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
` (6 preceding siblings ...)
2023-02-08 19:02 ` [PATCH v5 7/7] arm64: dts: qcom: sm8550-mtp: " Abel Vesa
@ 2023-02-16 13:12 ` Vinod Koul
2023-03-15 23:34 ` (subset) " Bjorn Andersson
8 siblings, 0 replies; 13+ messages in thread
From: Vinod Koul @ 2023-02-16 13:12 UTC (permalink / raw)
To: Abel Vesa
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Kishon Vijay Abraham I,
Johan Hovold, linux-arm-msm, linux-phy, devicetree,
Linux Kernel Mailing List
On 08-02-23, 21:01, Abel Vesa wrote:
> This patchset adds support for the eUSB2 repeater found in pmic PM8550B,
> used along with SM8550. Since there is no dedicated generic framework
> for eUSB2 repeaters, the most appropriate subsystem to model it is the
> generic phy. This patchset also adds support for such repeater to the
> eUSB2 PHY found in SM8550. Basically, the eUSB2 PHY will have its own
> "phy" which is actually a repeater.
Applied phy patches, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (subset) [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater
2023-02-08 19:01 [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Abel Vesa
` (7 preceding siblings ...)
2023-02-16 13:12 ` [PATCH v5 0/7] sm8550: Add support for eUSB2 repeater Vinod Koul
@ 2023-03-15 23:34 ` Bjorn Andersson
8 siblings, 0 replies; 13+ messages in thread
From: Bjorn Andersson @ 2023-03-15 23:34 UTC (permalink / raw)
To: Johan Hovold, Krzysztof Kozlowski, vkoul, Rob Herring, Lee Jones,
Konrad Dybcio, Abel Vesa, Kishon Vijay Abraham I, Andy Gross
Cc: Linux Kernel Mailing List, devicetree, linux-arm-msm, linux-phy
On Wed, 8 Feb 2023 21:01:53 +0200, Abel Vesa wrote:
> This patchset adds support for the eUSB2 repeater found in pmic PM8550B,
> used along with SM8550. Since there is no dedicated generic framework
> for eUSB2 repeaters, the most appropriate subsystem to model it is the
> generic phy. This patchset also adds support for such repeater to the
> eUSB2 PHY found in SM8550. Basically, the eUSB2 PHY will have its own
> "phy" which is actually a repeater.
>
> [...]
Applied, thanks!
[6/7] arm64: dts: qcom: pm8550b: Add eUSB2 repeater node
commit: fdaa922585f4474c88fbfaa129f8114f38200660
[7/7] arm64: dts: qcom: sm8550-mtp: Add eUSB2 repeater node
commit: 749078e38e1ee28357e8fdcd4eac382a465bd1e7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread