* [PATCH] drm/msm: Use struct fb_info.screen_buffer
@ 2023-05-22 19:17 Thomas Zimmermann
2023-05-23 8:20 ` Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2023-05-22 19:17 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, Thomas Zimmermann
The fbdev framebuffer is in system memory. Store the address in
the field 'screen_buffer'. Fixes the following sparse warning.
../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces)
../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base
../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void *
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/msm/msm_fbdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 2ebc86381e1c..ce0ba6d1979a 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -121,9 +121,9 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
drm_fb_helper_fill_info(fbi, helper, sizes);
- fbi->screen_base = msm_gem_get_vaddr(bo);
- if (IS_ERR(fbi->screen_base)) {
- ret = PTR_ERR(fbi->screen_base);
+ fbi->screen_buffer = msm_gem_get_vaddr(bo);
+ if (IS_ERR(fbi->screen_buffer)) {
+ ret = PTR_ERR(fbi->screen_buffer);
goto fail;
}
fbi->screen_size = bo->size;
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: Use struct fb_info.screen_buffer
2023-05-22 19:17 [PATCH] drm/msm: Use struct fb_info.screen_buffer Thomas Zimmermann
@ 2023-05-23 8:20 ` Javier Martinez Canillas
2023-06-04 1:58 ` Dmitry Baryshkov
2023-06-04 3:01 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2023-05-23 8:20 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied,
daniel, linux-arm-msm, freedreno, dri-devel
Hello Thomas,
On Mon, May 22, 2023 at 9:17 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> The fbdev framebuffer is in system memory. Store the address in
> the field 'screen_buffer'. Fixes the following sparse warning.
>
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces)
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void *
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: Use struct fb_info.screen_buffer
2023-05-22 19:17 [PATCH] drm/msm: Use struct fb_info.screen_buffer Thomas Zimmermann
2023-05-23 8:20 ` Javier Martinez Canillas
@ 2023-06-04 1:58 ` Dmitry Baryshkov
2023-06-04 3:01 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-06-04 1:58 UTC (permalink / raw)
To: Thomas Zimmermann, robdclark, quic_abhinavk, sean, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno
On 22/05/2023 22:17, Thomas Zimmermann wrote:
> The fbdev framebuffer is in system memory. Store the address in
> the field 'screen_buffer'. Fixes the following sparse warning.
>
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces)
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void *
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: Use struct fb_info.screen_buffer
2023-05-22 19:17 [PATCH] drm/msm: Use struct fb_info.screen_buffer Thomas Zimmermann
2023-05-23 8:20 ` Javier Martinez Canillas
2023-06-04 1:58 ` Dmitry Baryshkov
@ 2023-06-04 3:01 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-06-04 3:01 UTC (permalink / raw)
To: robdclark, quic_abhinavk, sean, airlied, daniel, Thomas Zimmermann
Cc: linux-arm-msm, dri-devel, freedreno
On Mon, 22 May 2023 21:17:01 +0200, Thomas Zimmermann wrote:
> The fbdev framebuffer is in system memory. Store the address in
> the field 'screen_buffer'. Fixes the following sparse warning.
>
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces)
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base
> ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void *
>
> [...]
Applied, thanks!
[1/1] drm/msm: Use struct fb_info.screen_buffer
https://gitlab.freedesktop.org/lumag/msm/-/commit/4fb5ad612c5c
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-04 3:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 19:17 [PATCH] drm/msm: Use struct fb_info.screen_buffer Thomas Zimmermann
2023-05-23 8:20 ` Javier Martinez Canillas
2023-06-04 1:58 ` Dmitry Baryshkov
2023-06-04 3:01 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).