* [PATCH] soc: qcom: Fix a IS_ERR() vs NULL bug in probe
@ 2023-06-06 8:21 Dan Carpenter
2023-06-06 9:32 ` Konrad Dybcio
2023-06-13 22:30 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-06-06 8:21 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, kernel-janitors
The devm_ioremap() function returns NULL on error, it never returns
error pointers.
Fixes: a77b2a0b1280 ("soc: qcom: Introduce RPM master stats driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/soc/qcom/rpm_master_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/rpm_master_stats.c b/drivers/soc/qcom/rpm_master_stats.c
index 6dd98b9f7129..9ca13bcf67d3 100644
--- a/drivers/soc/qcom/rpm_master_stats.c
+++ b/drivers/soc/qcom/rpm_master_stats.c
@@ -105,7 +105,7 @@ static int master_stats_probe(struct platform_device *pdev)
}
data[i].base = devm_ioremap(dev, res.start, resource_size(&res));
- if (IS_ERR(data[i].base)) {
+ if (!data[i].base) {
debugfs_remove_recursive(root);
return dev_err_probe(dev, -EINVAL,
"Could not map the MSG RAM slice idx %d!\n", i);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: Fix a IS_ERR() vs NULL bug in probe
2023-06-06 8:21 [PATCH] soc: qcom: Fix a IS_ERR() vs NULL bug in probe Dan Carpenter
@ 2023-06-06 9:32 ` Konrad Dybcio
2023-06-13 22:30 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-06-06 9:32 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Bjorn Andersson, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, kernel-janitors
On 6.06.2023 10:21, Dan Carpenter wrote:
> The devm_ioremap() function returns NULL on error, it never returns
> error pointers.
>
> Fixes: a77b2a0b1280 ("soc: qcom: Introduce RPM master stats driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Thanks!
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/soc/qcom/rpm_master_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/rpm_master_stats.c b/drivers/soc/qcom/rpm_master_stats.c
> index 6dd98b9f7129..9ca13bcf67d3 100644
> --- a/drivers/soc/qcom/rpm_master_stats.c
> +++ b/drivers/soc/qcom/rpm_master_stats.c
> @@ -105,7 +105,7 @@ static int master_stats_probe(struct platform_device *pdev)
> }
>
> data[i].base = devm_ioremap(dev, res.start, resource_size(&res));
> - if (IS_ERR(data[i].base)) {
> + if (!data[i].base) {
> debugfs_remove_recursive(root);
> return dev_err_probe(dev, -EINVAL,
> "Could not map the MSG RAM slice idx %d!\n", i);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: Fix a IS_ERR() vs NULL bug in probe
2023-06-06 8:21 [PATCH] soc: qcom: Fix a IS_ERR() vs NULL bug in probe Dan Carpenter
2023-06-06 9:32 ` Konrad Dybcio
@ 2023-06-13 22:30 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-06-13 22:30 UTC (permalink / raw)
To: Konrad Dybcio, Dan Carpenter
Cc: linux-arm-msm, Andy Gross, Manivannan Sadhasivam,
kernel-janitors, linux-kernel
On Tue, 6 Jun 2023 11:21:22 +0300, Dan Carpenter wrote:
> The devm_ioremap() function returns NULL on error, it never returns
> error pointers.
>
>
Applied, thanks!
[1/1] soc: qcom: Fix a IS_ERR() vs NULL bug in probe
commit: 3aed112953b1877ede66ae77afa4e5a5024be7cb
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-13 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 8:21 [PATCH] soc: qcom: Fix a IS_ERR() vs NULL bug in probe Dan Carpenter
2023-06-06 9:32 ` Konrad Dybcio
2023-06-13 22:30 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).