linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matthew McClintock <mmcclint@codeaurora.org>, linus.walleij@linaro.org
Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
	qca-upstream.external@qca.qualcomm.com,
	Sricharan R <sricharan@codeaurora.org>,
	Rob Herring <robh@kernel.org>,
	Mathieu Olivari <mathieu@codeaurora.org>,
	Varadarajan Narayanan <varada@codeaurora.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/17] pinctrl: qcom: ipq4019: fix register offsets
Date: Fri, 25 Mar 2016 14:31:12 -0700	[thread overview]
Message-ID: <20160325213112.GC8929@tuxbot> (raw)
In-Reply-To: <1458770712-10880-4-git-send-email-mmcclint@codeaurora.org>

On Wed 23 Mar 15:04 PDT 2016, Matthew McClintock wrote:

> For this SoC the register offsets changed from previous versions to be
> separated by a larger amount.
> 
> CC: linus.walleij@linaro.org

So the HW guys changed the register layout of the TLMM block? Matches
the layout of contemporary MSMs, so I see no problems with this.

Acked-by: bjorn.andersson@linaro.org

Regards,
Bjorn

> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-ipq4019.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> index cb9f16a..b68ae42 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> @@ -254,11 +254,11 @@ DECLARE_QCA_GPIO_PINS(99);
>  			qca_mux_##f14			\
>  		},				        \
>  		.nfuncs = 15,				\
> -		.ctl_reg = 0x1000 + 0x10 * id,		\
> -		.io_reg = 0x1004 + 0x10 * id,		\
> -		.intr_cfg_reg = 0x1008 + 0x10 * id,	\
> -		.intr_status_reg = 0x100c + 0x10 * id,	\
> -		.intr_target_reg = 0x400 + 0x4 * id,	\
> +		.ctl_reg = 0x0 + 0x1000 * id,		\
> +		.io_reg = 0x4 + 0x1000 * id,		\
> +		.intr_cfg_reg = 0x8 + 0x1000 * id,	\
> +		.intr_status_reg = 0xc + 0x1000 * id,	\
> +		.intr_target_reg = 0x8 + 0x1000 * id,	\
>  		.mux_bit = 2,			\
>  		.pull_bit = 0,			\
>  		.drv_bit = 6,			\
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2016-03-25 21:31 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 22:04 [PATCH 00/17] Additional IPQ4019 platform support Matthew McClintock
2016-03-23 22:04 ` [PATCH 01/17] pinctrl: qcom: ipq4019: set ngpios to correct value Matthew McClintock
2016-03-25 21:19   ` Bjorn Andersson
2016-03-31  9:53   ` Linus Walleij
2016-03-23 22:04 ` [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode Matthew McClintock
2016-03-25 21:22   ` Bjorn Andersson
2016-03-31  9:55   ` Linus Walleij
2016-03-23 22:04 ` [PATCH 03/17] pinctrl: qcom: ipq4019: fix register offsets Matthew McClintock
2016-03-25 21:31   ` Bjorn Andersson [this message]
2016-03-31  9:57   ` Linus Walleij
2016-03-23 22:04 ` [PATCH 04/17] clk: qcom: ipq4019: switch remaining defines to enums Matthew McClintock
2016-03-29 23:31   ` Stephen Boyd
2016-03-23 22:05 ` [PATCH 05/17] clk: qcom: ipq4019: add some fixed clocks for ddrppl and fepll Matthew McClintock
2016-03-29 23:31   ` Stephen Boyd
     [not found] ` <1458770712-10880-1-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:05   ` [PATCH 06/17] watchdog: qcom: update device tree bindings Matthew McClintock
2016-03-23 22:26     ` Stephen Boyd
2016-03-24 15:49       ` Matthew McClintock
     [not found]     ` <1458770712-10880-7-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-25 14:13       ` Rob Herring
2016-03-23 22:05   ` [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock
2016-03-25 14:15     ` Rob Herring
2016-03-28 17:02       ` Matthew McClintock
2016-03-28 17:26         ` Rob Herring
2016-03-28 18:15         ` Guenter Roeck
     [not found]           ` <20160328181544.GB29820-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-03-28 22:22             ` Matthew McClintock
2016-03-23 22:05   ` [PATCH 15/17] qcom: ipq4019: add cpu operating points for cpufreq support Matthew McClintock
     [not found]     ` <1458770712-10880-16-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:33       ` Stephen Boyd
2017-03-22 14:10     ` [15/17] " Sven Eckelmann
2016-03-23 22:05 ` [PATCH 07/17] watchdog: qcom: add option for standalone watchdog not in timer block Matthew McClintock
     [not found]   ` <1458770712-10880-8-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:40     ` Stephen Boyd
2016-03-25 16:23     ` Guenter Roeck
     [not found]       ` <20160325162326.GA25767-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-03-28 16:55         ` Matthew McClintock
     [not found]           ` <D54FA5B6-F170-40D3-BF0D-60D40A2C2829-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-28 18:13             ` Guenter Roeck
2016-03-28 20:40               ` Matthew McClintock
2016-03-28 21:56                 ` Guenter Roeck
     [not found]                   ` <20160328215638.GA25221-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-03-28 22:21                     ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 08/17] watchdog: qcom: configure BARK time in addition to BITE time Matthew McClintock
     [not found]   ` <1458770712-10880-9-git-send-email-mmcclint-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-23 22:42     ` Stephen Boyd
2016-03-24 15:46       ` Matthew McClintock
2016-03-24 16:17         ` Guenter Roeck
2016-03-24 19:49           ` Matthew McClintock
2016-04-07  7:02     ` Guenter Roeck
2016-03-23 22:05 ` [PATCH 10/17] qcom: ipq4019: add watchdog node to ipq4019 SoC and DK01 device tree Matthew McClintock
2016-03-23 22:05 ` [PATCH 11/17] qcom: ipq4019: add support for reset via qcom,ps-hold Matthew McClintock
2016-03-23 22:05 ` [PATCH 12/17] qcom: ipq4019: add spi node to ipq4019 SoC and DK01 device tree Matthew McClintock
2016-03-23 22:05 ` [PATCH 13/17] qcom: ipq4019: add i2c " Matthew McClintock
2016-03-23 22:05 ` [PATCH 14/17] cpufreq: ipq4019: add cpufreq driver Matthew McClintock
2016-03-24  6:44   ` Viresh Kumar
2016-03-24 15:42     ` Matthew McClintock
2016-03-23 22:05 ` [PATCH 16/17] qcom: ipq4019: add crypto nodes to ipq4019 SoC and DK01 device tree Matthew McClintock
2016-03-23 22:05 ` [PATCH 17/17] qcom: ipq4019: add DMA " Matthew McClintock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160325213112.GC8929@tuxbot \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu@codeaurora.org \
    --cc=mmcclint@codeaurora.org \
    --cc=qca-upstream.external@qca.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sricharan@codeaurora.org \
    --cc=varada@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).