From: Stephen Boyd <sboyd@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Andy Gross <andy.gross@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 3/9] media: venus: adding core part and helper functions
Date: Fri, 11 Nov 2016 14:54:52 -0800 [thread overview]
Message-ID: <20161111225452.GD5177@codeaurora.org> (raw)
In-Reply-To: <550b86f3-e687-ddcd-2f20-d430bbe06940@linaro.org>
On 11/11, Stanimir Varbanov wrote:
> On 11/10/2016 11:43 PM, Stephen Boyd wrote:
> >
> > Should this be ret |= ? Only the last time through the loop will
> > there be an error. Or perhaps we should be bailing out early from
> > this loop?
>
> I think that even if unset_buffers fail we need to free the memory. In
> case of an error in firmware while unset buffers we should mark the
> session as invalid and abort the session acordingly.
Ok. So perhaps we shouldn't have any return value for this
function then?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-11 22:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 17:33 [PATCH v3 0/9] Qualcomm video decoder/encoder driver Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 1/9] doc: DT: vidc: binding document for Qualcomm video driver Stanimir Varbanov
2016-11-14 17:04 ` Rob Herring
2016-11-15 17:15 ` Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 2/9] MAINTAINERS: Add Qualcomm Venus video accelerator driver Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 3/9] media: venus: adding core part and helper functions Stanimir Varbanov
2016-11-10 21:43 ` Stephen Boyd
2016-11-11 16:17 ` Stanimir Varbanov
2016-11-11 22:54 ` Stephen Boyd [this message]
2016-11-11 11:32 ` Hans Verkuil
2016-11-14 9:42 ` Stanimir Varbanov
2016-11-14 9:47 ` Hans Verkuil
2016-11-14 10:11 ` Stanimir Varbanov
2016-11-14 10:25 ` Hans Verkuil
2016-11-17 9:10 ` Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 4/9] media: venus: vdec: add video decoder files Stanimir Varbanov
2016-11-11 11:39 ` Hans Verkuil
2016-11-14 10:11 ` Stanimir Varbanov
2016-11-18 9:11 ` Stanimir Varbanov
2016-11-21 15:04 ` Hans Verkuil
2016-11-21 15:29 ` Stanimir Varbanov
2016-11-21 15:33 ` Hans Verkuil
2016-11-21 16:09 ` Stanimir Varbanov
2016-11-23 20:24 ` Nicolas Dufresne
2016-11-24 13:16 ` Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 5/9] media: venus: venc: add video encoder files Stanimir Varbanov
2016-11-11 11:43 ` Hans Verkuil
2016-11-14 10:27 ` Stanimir Varbanov
2016-11-07 17:34 ` [PATCH v3 6/9] media: venus: hfi: add Host Firmware Interface (HFI) Stanimir Varbanov
2016-11-07 17:34 ` [PATCH v3 7/9] media: venus: hfi: add Venus HFI files Stanimir Varbanov
2016-11-07 17:34 ` [PATCH v3 8/9] media: venus: add Makefiles and Kconfig files Stanimir Varbanov
2016-11-10 2:04 ` Stephen Boyd
2016-11-11 6:12 ` Vivek Gautam
2016-11-11 9:07 ` Stanimir Varbanov
2016-11-11 9:45 ` Vivek Gautam
2016-11-07 17:34 ` [PATCH v3 9/9] media: venus: enable building of Venus video codec driver Stanimir Varbanov
2016-11-11 11:49 ` [PATCH v3 0/9] Qualcomm video decoder/encoder driver Hans Verkuil
2016-11-11 12:11 ` Javier Martinez Canillas
2016-11-14 14:59 ` Stanimir Varbanov
2016-11-14 14:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111225452.GD5177@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).