From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 5/9] media: venus: venc: add video encoder files
Date: Mon, 14 Nov 2016 12:27:25 +0200 [thread overview]
Message-ID: <9e4549e5-4e24-8aaa-bf8a-549f7906c207@linaro.org> (raw)
In-Reply-To: <5e918c07-c3fb-262a-5c9e-11014cdb0eb0@xs4all.nl>
Hi Hans,
Thanks for the comments!
On 11/11/2016 01:43 PM, Hans Verkuil wrote:
> The comments I made before about start_streaming and the use of struct venus_ctrl
> apply here as well and I won't repeat them.
>
> On 11/07/2016 06:33 PM, Stanimir Varbanov wrote:
>> This adds encoder part of the driver plus encoder controls.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>> drivers/media/platform/qcom/venus/venc.c | 1212 ++++++++++++++++++++++++
>> drivers/media/platform/qcom/venus/venc.h | 32 +
>> drivers/media/platform/qcom/venus/venc_ctrls.c | 396 ++++++++
>> 3 files changed, 1640 insertions(+)
>> create mode 100644 drivers/media/platform/qcom/venus/venc.c
>> create mode 100644 drivers/media/platform/qcom/venus/venc.h
>> create mode 100644 drivers/media/platform/qcom/venus/venc_ctrls.c
>>
>> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
>> new file mode 100644
>> index 000000000000..35572eaffb9e
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/venus/venc.c
>
> <snip>
>
>> +static int
>> +venc_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
>> +{
>> + struct venus_inst *inst = to_inst(file);
>> +
>> + if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
>> + return -EINVAL;
>> +
>> + switch (s->target) {
>> + case V4L2_SEL_TGT_CROP:
>> + if (s->r.width != inst->out_width ||
>> + s->r.height != inst->out_height ||
>> + s->r.top != 0 || s->r.left != 0)
>> + return -EINVAL;
>> + break;
>> + default:
>> + return -EINVAL;
>> + }
>> +
>> + return 0;
>> +}
>
> Why implement s_selection if I can't change the selection?
without s_selection the v4l2-compliance test starts failing with:
fail: v4l2-test-formats.cpp(1319): doioctl(node, VIDIOC_S_SELECTION,
&sel_crop) != EINVAL
fail: v4l2-test-formats.cpp(1407): testBasicCrop(node,
V4L2_BUF_TYPE_VIDEO_OUTPUT)
>
>> +
>> +static int
>> +venc_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *b)
>> +{
>> + struct vb2_queue *queue = to_vb2q(file, b->type);
>> +
>> + if (!queue)
>> + return -EINVAL;
>> +
>> + return vb2_reqbufs(queue, b);
>> +}
>
> Use the m2m helpers if at all possible.
I've answered already to that in 4/9.
--
regards,
Stan
next prev parent reply other threads:[~2016-11-14 10:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 17:33 [PATCH v3 0/9] Qualcomm video decoder/encoder driver Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 1/9] doc: DT: vidc: binding document for Qualcomm video driver Stanimir Varbanov
2016-11-14 17:04 ` Rob Herring
2016-11-15 17:15 ` Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 2/9] MAINTAINERS: Add Qualcomm Venus video accelerator driver Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 3/9] media: venus: adding core part and helper functions Stanimir Varbanov
2016-11-10 21:43 ` Stephen Boyd
2016-11-11 16:17 ` Stanimir Varbanov
2016-11-11 22:54 ` Stephen Boyd
2016-11-11 11:32 ` Hans Verkuil
2016-11-14 9:42 ` Stanimir Varbanov
2016-11-14 9:47 ` Hans Verkuil
2016-11-14 10:11 ` Stanimir Varbanov
2016-11-14 10:25 ` Hans Verkuil
2016-11-17 9:10 ` Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 4/9] media: venus: vdec: add video decoder files Stanimir Varbanov
2016-11-11 11:39 ` Hans Verkuil
2016-11-14 10:11 ` Stanimir Varbanov
2016-11-18 9:11 ` Stanimir Varbanov
2016-11-21 15:04 ` Hans Verkuil
2016-11-21 15:29 ` Stanimir Varbanov
2016-11-21 15:33 ` Hans Verkuil
2016-11-21 16:09 ` Stanimir Varbanov
2016-11-23 20:24 ` Nicolas Dufresne
2016-11-24 13:16 ` Stanimir Varbanov
2016-11-07 17:33 ` [PATCH v3 5/9] media: venus: venc: add video encoder files Stanimir Varbanov
2016-11-11 11:43 ` Hans Verkuil
2016-11-14 10:27 ` Stanimir Varbanov [this message]
2016-11-07 17:34 ` [PATCH v3 6/9] media: venus: hfi: add Host Firmware Interface (HFI) Stanimir Varbanov
2016-11-07 17:34 ` [PATCH v3 7/9] media: venus: hfi: add Venus HFI files Stanimir Varbanov
2016-11-07 17:34 ` [PATCH v3 8/9] media: venus: add Makefiles and Kconfig files Stanimir Varbanov
2016-11-10 2:04 ` Stephen Boyd
2016-11-11 6:12 ` Vivek Gautam
2016-11-11 9:07 ` Stanimir Varbanov
2016-11-11 9:45 ` Vivek Gautam
2016-11-07 17:34 ` [PATCH v3 9/9] media: venus: enable building of Venus video codec driver Stanimir Varbanov
2016-11-11 11:49 ` [PATCH v3 0/9] Qualcomm video decoder/encoder driver Hans Verkuil
2016-11-11 12:11 ` Javier Martinez Canillas
2016-11-14 14:59 ` Stanimir Varbanov
2016-11-14 14:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4549e5-4e24-8aaa-bf8a-549f7906c207@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).