* [RESEND PATCH] pinctrl: qcom: fix wrong pull status display for no_keeper SoC
@ 2018-05-04 23:57 Bjorn Andersson
2018-05-16 12:52 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2018-05-04 23:57 UTC (permalink / raw)
To: Linus Walleij, Clément Péron
Cc: linux-arm-msm, linux-gpio, linux-kernel
From: Clément Péron <peron.clem@gmail.com>
DebugFS strings about pin pull status for no_keeper SoC are wrong
Fix this by adding a different string array for no_keeper SoC
Signed-off-by: Clément Péron <peron.clem@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Hi Linus,
Forwarding this patch which was posted to linux-arm-msm@ only. LGTM, please apply.
@Clémen, please use ./scripts/get_maintaine.pl to find appropriate recipients
for future patches.
Regards,
Bjorn
drivers/pinctrl/qcom/pinctrl-msm.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index fa4e94fedb8c..c3c77b86eff7 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -504,13 +504,19 @@ static void msm_gpio_dbg_show_one(struct seq_file *s,
int pull;
u32 ctl_reg;
- static const char * const pulls[] = {
+ static const char * const pulls_keeper[] = {
"no pull",
"pull down",
"keeper",
"pull up"
};
+ static const char * const pulls_no_keeper[] = {
+ "no pull",
+ "pull down",
+ "pull up",
+ };
+
if (!gpiochip_line_is_valid(chip, offset))
return;
@@ -524,7 +530,10 @@ static void msm_gpio_dbg_show_one(struct seq_file *s,
seq_printf(s, " %-8s: %-3s %d", g->name, is_out ? "out" : "in", func);
seq_printf(s, " %dmA", msm_regval_to_drive(drive));
- seq_printf(s, " %s", pulls[pull]);
+ if (pctrl->soc->pull_no_keeper)
+ seq_printf(s, " %s", pulls_no_keeper[pull]);
+ else
+ seq_printf(s, " %s", pulls_keeper[pull]);
seq_puts(s, "\n");
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] pinctrl: qcom: fix wrong pull status display for no_keeper SoC
2018-05-04 23:57 [RESEND PATCH] pinctrl: qcom: fix wrong pull status display for no_keeper SoC Bjorn Andersson
@ 2018-05-16 12:52 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-05-16 12:52 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Clément Péron, linux-arm-msm, open list:GPIO SUBSYSTEM,
linux-kernel
On Sat, May 5, 2018 at 1:57 AM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> From: Clément Péron <peron.clem@gmail.com>
>
> DebugFS strings about pin pull status for no_keeper SoC are wrong
>
> Fix this by adding a different string array for no_keeper SoC
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Hi Linus,
>
> Forwarding this patch which was posted to linux-arm-msm@ only. LGTM, please apply.
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-16 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 23:57 [RESEND PATCH] pinctrl: qcom: fix wrong pull status display for no_keeper SoC Bjorn Andersson
2018-05-16 12:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).