* [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
[not found] <20180508150952.24562-1-robh@kernel.org>
@ 2018-05-08 15:09 ` Rob Herring
2018-05-23 20:29 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-05-08 15:09 UTC (permalink / raw)
To: devicetree, linux-arm-kernel
Cc: Andy Gross, David Brown, Mathieu Poirier, Ivan T . Ivanov, linux-arm-msm
The ETF input should be connected to the funnel output, and the ETF
output should be connected to the replicator input. The labels are wrong
and these got swapped:
Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional
Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional
Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")
Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>
Cc: David Brown <david.brown@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 66b318e1de80..aef814b2dc9e 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1191,14 +1191,14 @@
port@0 {
reg = <0>;
- etf_out: endpoint {
+ etf_in: endpoint {
slave-mode;
remote-endpoint = <&funnel0_out>;
};
};
port@1 {
reg = <0>;
- etf_in: endpoint {
+ etf_out: endpoint {
remote-endpoint = <&replicator_in>;
};
};
--
2.17.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
2018-05-08 15:09 ` [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections Rob Herring
@ 2018-05-23 20:29 ` Rob Herring
2018-05-24 4:48 ` Ivan T. Ivanov
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-05-23 20:29 UTC (permalink / raw)
To: devicetree,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Andy Gross
Cc: David Brown, Mathieu Poirier, Ivan T . Ivanov, linux-arm-msm
On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote:
> The ETF input should be connected to the funnel output, and the ETF
> output should be connected to the replicator input. The labels are wrong
> and these got swapped:
>
> Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional
> Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional
>
> Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")
> Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Ping. Still seeing warnings in -next for these.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
2018-05-23 20:29 ` Rob Herring
@ 2018-05-24 4:48 ` Ivan T. Ivanov
2018-05-24 16:32 ` Mathieu Poirier
0 siblings, 1 reply; 5+ messages in thread
From: Ivan T. Ivanov @ 2018-05-24 4:48 UTC (permalink / raw)
To: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Andy Gross, Rob Herring, devicetree
Cc: David Brown, Mathieu Poirier, Ivan T . Ivanov, linux-arm-msm
Quoting Rob Herring (2018-05-23 23:29:29)
> On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote:
> > The ETF input should be connected to the funnel output, and the ETF
> > output should be connected to the replicator input. The labels are wrong
> > and these got swapped:
> >
> > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional
> > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional
> >
> > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")
> > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Cc: Andy Gross <andy.gross@linaro.org>
> > Cc: David Brown <david.brown@linaro.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Ping. Still seeing warnings in -next for these.
>
Hi Rob,
I no longer have access to this hardware and documentation.
I am sure that Mathieu and friends will take care for verification
of this patch :-)
Regards,
Ivan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
2018-05-24 4:48 ` Ivan T. Ivanov
@ 2018-05-24 16:32 ` Mathieu Poirier
2018-05-25 22:46 ` Andy Gross
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Poirier @ 2018-05-24 16:32 UTC (permalink / raw)
To: Ivan T. Ivanov
Cc: Rob Herring, devicetree, linux-arm-msm, David Brown,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Andy Gross, Ivan T . Ivanov
On 23 May 2018 at 22:48, Ivan T. Ivanov <iivanov.xz@gmail.com> wrote:
> Quoting Rob Herring (2018-05-23 23:29:29)
>> On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote:
>> > The ETF input should be connected to the funnel output, and the ETF
>> > output should be connected to the replicator input. The labels are wrong
>> > and these got swapped:
>> >
>> > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional
>> > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional
>> >
>> > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")
>> > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
>> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> > Cc: Andy Gross <andy.gross@linaro.org>
>> > Cc: David Brown <david.brown@linaro.org>
>> > Cc: linux-arm-msm@vger.kernel.org
>> > Signed-off-by: Rob Herring <robh@kernel.org>
>> > ---
>> > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Ping. Still seeing warnings in -next for these.
>>
>
> Hi Rob,
>
> I no longer have access to this hardware and documentation.
> I am sure that Mathieu and friends will take care for verification
> of this patch :-)
The code triggers on the "slave-mode" property rather than the labels,
so this patch has no effect on how a path is established. I've tested
this on a 410c and things look good.
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> Regards,
> Ivan
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
2018-05-24 16:32 ` Mathieu Poirier
@ 2018-05-25 22:46 ` Andy Gross
0 siblings, 0 replies; 5+ messages in thread
From: Andy Gross @ 2018-05-25 22:46 UTC (permalink / raw)
To: Mathieu Poirier
Cc: devicetree, Rob Herring, linux-arm-msm, David Brown,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Ivan T. Ivanov, Ivan T . Ivanov
On Thu, May 24, 2018 at 10:32:46AM -0600, Mathieu Poirier wrote:
<snip>
> >
> > Hi Rob,
> >
> > I no longer have access to this hardware and documentation.
> > I am sure that Mathieu and friends will take care for verification
> > of this patch :-)
>
> The code triggers on the "slave-mode" property rather than the labels,
> so this patch has no effect on how a path is established. I've tested
> this on a 410c and things look good.
>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks for verifying this Matthew. I'll put this in for a fixes as I just sent
out my last set for 4.18.
Regards,
Andy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-25 22:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180508150952.24562-1-robh@kernel.org>
2018-05-08 15:09 ` [PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections Rob Herring
2018-05-23 20:29 ` Rob Herring
2018-05-24 4:48 ` Ivan T. Ivanov
2018-05-24 16:32 ` Mathieu Poirier
2018-05-25 22:46 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).