* [PATCH] spi: qup: remove unnecessary goto
@ 2019-05-31 14:46 Jorge Ramirez-Ortiz
2019-06-03 18:02 ` Applied "spi: qup: remove unnecessary goto" to the spi tree Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-05-31 14:46 UTC (permalink / raw)
To: jorge.ramirez-ortiz, agross, david.brown, broonie
Cc: linux-arm-msm, linux-spi, linux-kernel
Remove unnecessary condition check and associated goto.
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
drivers/spi/spi-qup.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 974a8ce58b68..314d91b95a16 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -842,10 +842,6 @@ static int spi_qup_transfer_one(struct spi_master *master,
else
ret = spi_qup_do_pio(spi, xfer, timeout);
- if (ret)
- goto exit;
-
-exit:
spi_qup_set_state(controller, QUP_STATE_RESET);
spin_lock_irqsave(&controller->lock, flags);
if (!ret)
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Applied "spi: qup: remove unnecessary goto" to the spi tree
2019-05-31 14:46 [PATCH] spi: qup: remove unnecessary goto Jorge Ramirez-Ortiz
@ 2019-06-03 18:02 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2019-06-03 18:02 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz
Cc: agross, broonie, david.brown, jorge.ramirez-ortiz, linux-arm-msm,
linux-kernel, linux-spi, Mark Brown
The patch
spi: qup: remove unnecessary goto
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 3594bfa265da38dcfbab2312ddaff39711b98857 Mon Sep 17 00:00:00 2001
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Date: Fri, 31 May 2019 16:46:36 +0200
Subject: [PATCH] spi: qup: remove unnecessary goto
Remove unnecessary condition check and associated goto.
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-qup.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 974a8ce58b68..314d91b95a16 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -842,10 +842,6 @@ static int spi_qup_transfer_one(struct spi_master *master,
else
ret = spi_qup_do_pio(spi, xfer, timeout);
- if (ret)
- goto exit;
-
-exit:
spi_qup_set_state(controller, QUP_STATE_RESET);
spin_lock_irqsave(&controller->lock, flags);
if (!ret)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-03 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 14:46 [PATCH] spi: qup: remove unnecessary goto Jorge Ramirez-Ortiz
2019-06-03 18:02 ` Applied "spi: qup: remove unnecessary goto" to the spi tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).