* [PATCH] arm64: dts: msm8996: fix PSCI entry-latency-us
@ 2019-06-04 12:29 Niklas Cassel
2019-06-08 3:50 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2019-06-04 12:29 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland
Cc: amit.kucheria, bjorn.andersson, Niklas Cassel, linux-arm-msm,
devicetree, linux-kernel
The current entry-latency-us is too short.
The proper way to convert between the device tree properties
from the vendor tree to the upstream PSCI device tree properties is:
entry-latency-us = qcom,time-overhead - qcom,latency-us
which gives
entry-latency-us = 210 - 80 = 130
Fixes: f6aee7af59b6 ("arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states")
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index b7cf2a17dcb5..e8c03b5c8990 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -174,7 +174,7 @@
compatible = "arm,idle-state";
idle-state-name = "standalone-power-collapse";
arm,psci-suspend-param = <0x00000004>;
- entry-latency-us = <40>;
+ entry-latency-us = <130>;
exit-latency-us = <80>;
min-residency-us = <300>;
};
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: msm8996: fix PSCI entry-latency-us
2019-06-04 12:29 [PATCH] arm64: dts: msm8996: fix PSCI entry-latency-us Niklas Cassel
@ 2019-06-08 3:50 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-06-08 3:50 UTC (permalink / raw)
To: Niklas Cassel
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
amit.kucheria, linux-arm-msm, devicetree, linux-kernel
On Tue 04 Jun 05:29 PDT 2019, Niklas Cassel wrote:
> The current entry-latency-us is too short.
> The proper way to convert between the device tree properties
> from the vendor tree to the upstream PSCI device tree properties is:
>
> entry-latency-us = qcom,time-overhead - qcom,latency-us
>
> which gives
>
> entry-latency-us = 210 - 80 = 130
>
> Fixes: f6aee7af59b6 ("arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states")
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Thanks Niklas
Applied,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index b7cf2a17dcb5..e8c03b5c8990 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -174,7 +174,7 @@
> compatible = "arm,idle-state";
> idle-state-name = "standalone-power-collapse";
> arm,psci-suspend-param = <0x00000004>;
> - entry-latency-us = <40>;
> + entry-latency-us = <130>;
> exit-latency-us = <80>;
> min-residency-us = <300>;
> };
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-08 3:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 12:29 [PATCH] arm64: dts: msm8996: fix PSCI entry-latency-us Niklas Cassel
2019-06-08 3:50 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).