From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: robh+dt@kernel.org, agross@kernel.org, vkoul@kernel.org,
evgreen@chromium.org, daidavid1@codeaurora.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 2/5] soc: qcom: smd-rpm: Create RPM interconnect proxy child device
Date: Thu, 13 Jun 2019 08:40:02 -0700 [thread overview]
Message-ID: <20190613154002.GH6792@builder> (raw)
In-Reply-To: <20190613151323.10850-3-georgi.djakov@linaro.org>
On Thu 13 Jun 08:13 PDT 2019, Georgi Djakov wrote:
> Register a platform device to handle the communication of bus bandwidth
> requests with the remote processor. The interconnect proxy device is part
> of this remote processor (RPM) hardware. Let's create a icc-smd-rpm proxy
> child device to represent the bus throughput functionality that is provided
> by the RPM.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
>
> v4:
> - Return error if platform_device_register_data() fails
> - Remove platform_set_drvdata() on the child device.
>
> v3:
> - New patch.
>
> drivers/soc/qcom/smd-rpm.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
> index fa9dd12b5e39..34cdd638a6c1 100644
> --- a/drivers/soc/qcom/smd-rpm.c
> +++ b/drivers/soc/qcom/smd-rpm.c
> @@ -19,12 +19,14 @@
> /**
> * struct qcom_smd_rpm - state of the rpm device driver
> * @rpm_channel: reference to the smd channel
> + * @icc: interconnect proxy device
> * @ack: completion for acks
> * @lock: mutual exclusion around the send/complete pair
> * @ack_status: result of the rpm request
> */
> struct qcom_smd_rpm {
> struct rpmsg_endpoint *rpm_channel;
> + struct platform_device *icc;
> struct device *dev;
>
> struct completion ack;
> @@ -193,6 +195,7 @@ static int qcom_smd_rpm_callback(struct rpmsg_device *rpdev,
> static int qcom_smd_rpm_probe(struct rpmsg_device *rpdev)
> {
> struct qcom_smd_rpm *rpm;
> + int ret;
>
> rpm = devm_kzalloc(&rpdev->dev, sizeof(*rpm), GFP_KERNEL);
> if (!rpm)
> @@ -205,11 +208,23 @@ static int qcom_smd_rpm_probe(struct rpmsg_device *rpdev)
> rpm->rpm_channel = rpdev->ept;
> dev_set_drvdata(&rpdev->dev, rpm);
>
> - return of_platform_populate(rpdev->dev.of_node, NULL, NULL, &rpdev->dev);
> + rpm->icc = platform_device_register_data(&rpdev->dev, "icc_smd_rpm", -1,
> + NULL, 0);
> + if (IS_ERR(rpm->icc))
> + return PTR_ERR(rpm->icc);
> +
> + ret = of_platform_populate(rpdev->dev.of_node, NULL, NULL, &rpdev->dev);
> + if (ret)
> + platform_device_unregister(rpm->icc);
> +
> + return ret;
> }
>
> static void qcom_smd_rpm_remove(struct rpmsg_device *rpdev)
> {
> + struct qcom_smd_rpm *rpm = dev_get_drvdata(&rpdev->dev);
> +
> + platform_device_unregister(rpm->icc);
> of_platform_depopulate(&rpdev->dev);
> }
>
next prev parent reply other threads:[~2019-06-13 15:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 15:13 [PATCH v4 0/5] Add QCS404 interconnect provider driver Georgi Djakov
2019-06-13 15:13 ` [PATCH v4 1/5] dt-bindings: interconnect: Add Qualcomm QCS404 DT bindings Georgi Djakov
2019-06-25 15:00 ` Georgi Djakov
2019-07-08 19:26 ` Bjorn Andersson
2019-07-15 13:56 ` Georgi Djakov
2019-06-13 15:13 ` [PATCH v4 2/5] soc: qcom: smd-rpm: Create RPM interconnect proxy child device Georgi Djakov
2019-06-13 15:40 ` Bjorn Andersson [this message]
2019-10-07 2:01 ` Brian Masney
2019-10-07 5:28 ` Bjorn Andersson
2019-06-13 15:13 ` [PATCH v4 3/5] interconnect: qcom: Add interconnect SMD over SMD driver Georgi Djakov
2019-06-13 15:42 ` Bjorn Andersson
2019-06-13 15:13 ` [PATCH v4 4/5] interconnect: qcom: Add QCS404 interconnect provider driver Georgi Djakov
2019-06-13 15:47 ` Bjorn Andersson
2019-06-13 15:13 ` [PATCH v4 5/5] arm64: dts: qcs404: Add interconnect provider DT nodes Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613154002.GH6792@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).