From: Mark Brown <broonie@kernel.org>
To: Nisha Kumari <nishakumari@codeaurora.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
agross@kernel.org, lgirdwood@gmail.com, mark.rutland@arm.com,
david.brown@linaro.org, linux-kernel@vger.kernel.org,
kgunda@codeaurora.org, rnayak@codeaurora.org
Subject: Re: [PATCH 3/4] regulator: Add labibb driver
Date: Tue, 18 Jun 2019 11:59:35 +0100 [thread overview]
Message-ID: <20190618105935.GM5316@sirena.org.uk> (raw)
In-Reply-To: <577d6e90-0bed-ff2e-32dc-e64c3118458f@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Tue, Jun 18, 2019 at 11:51:18AM +0530, Nisha Kumari wrote:
> On 6/13/2019 10:55 PM, Mark Brown wrote:
> > > + labibb->lab_vreg.vreg_enabled = 1;
> > What function does this serve? It never seems to be read.
> Its used in next patch for handling interrupts
It'd be better to move this code into the patch where it's used then.
> > > + if (val & IBB_STATUS1_VREG_OK_BIT) {
> > > + labibb->ibb_vreg.vreg_enabled = 1;
> > > + return 0;
> > > + }
> > > + }
> > This is doing more than the other regulator was but it's not clear why -
> > is it just that the delays are different for the two regulators?
> LAB regulator comes up in first try, so we did not added much delay in that
> like IBB. Planning to make equal no of retries for both in next patch so
> that code can be reused.
Is there actually a need for polling at all?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-18 10:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 11:00 [PATCH 0/4] Add labibb regulator support for LCD display mode Nisha Kumari
2019-06-12 11:00 ` [PATCH 1/4] dt-bindings: regulator: Add labibb regulator Nisha Kumari
2019-06-13 16:05 ` Mark Brown
2019-06-13 16:28 ` Bjorn Andersson
2019-06-18 5:52 ` Nisha Kumari
2019-06-12 11:00 ` [PATCH 2/4] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators Nisha Kumari
2019-06-12 11:00 ` [PATCH 3/4] regulator: Add labibb driver Nisha Kumari
2019-06-13 17:04 ` Bjorn Andersson
2019-06-18 6:13 ` Nisha Kumari
2019-06-13 17:25 ` Mark Brown
2019-06-18 6:21 ` Nisha Kumari
2019-06-18 10:59 ` Mark Brown [this message]
2019-06-12 11:00 ` [PATCH 4/4] regulator: adding interrupt handling in labibb regulator Nisha Kumari
2019-06-13 17:27 ` Mark Brown
2019-06-18 6:23 ` Nisha Kumari
2020-04-28 5:16 ` Sumit Semwal
2020-04-28 11:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618105935.GM5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nishakumari@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).