From: Mark Brown <broonie@kernel.org>
To: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Nisha Kumari <nishakumari@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, agross@kernel.org,
lgirdwood@gmail.com, mark.rutland@arm.com,
david.brown@linaro.org, LKML <linux-kernel@vger.kernel.org>,
kgunda@codeaurora.org, Rajendra Nayak <rnayak@codeaurora.org>
Subject: Re: [PATCH 4/4] regulator: adding interrupt handling in labibb regulator
Date: Tue, 28 Apr 2020 12:09:42 +0100 [thread overview]
Message-ID: <20200428110942.GC5677@sirena.org.uk> (raw)
In-Reply-To: <CAO_48GEYAWBgzeEKx1kjjmLJ+F0chSkRs0EUC86Y2q20kyqjkA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
On Tue, Apr 28, 2020 at 10:46:52AM +0530, Sumit Semwal wrote:
> On Thu, 13 Jun 2019 at 22:57, Mark Brown <broonie@kernel.org> wrote:
> > > + /*
> > > + * The SC(short circuit) fault would trigger PBS(Portable Batch
> > > + * System) to disable regulators for protection. This would
> > > + * cause the SC_DETECT status being cleared so that it's not
> > > + * able to get the SC fault status.
> > > + * Check if LAB/IBB regulators are enabled in the driver but
> > > + * disabled in hardware, this means a SC fault had happened
> > > + * and SCP handling is completed by PBS.
> > > + */
> > Let the core worry about this, the driver should just report the problem
> > to the core like all other devices do (and this driver doesn't...).
> I (and Bjorn too) looked to find the api that allows us to do this
> short circuit reporting and recovery in the core, but couldn't find
> anything except REGULATOR_ERROR_OVER_CURRENT which also looks like
> it's used only once in the code.
A short circuit will generate excessive current (and detection of a
short circuit is usually current based) so using the same notification
should be fine. If you're concerned about this feel free to add a
specific notification, and add any handling you need in response to that
notification. You certainly shouldn't be just reenabling the regulators
in your driver.
Mostly AFAICT people are fairly happy with the autonomous response of
the hardware to these issues, it's not like they're expected to happen
in normal operation or be recoverable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-04-28 11:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 11:00 [PATCH 0/4] Add labibb regulator support for LCD display mode Nisha Kumari
2019-06-12 11:00 ` [PATCH 1/4] dt-bindings: regulator: Add labibb regulator Nisha Kumari
2019-06-13 16:05 ` Mark Brown
2019-06-13 16:28 ` Bjorn Andersson
2019-06-18 5:52 ` Nisha Kumari
2019-06-12 11:00 ` [PATCH 2/4] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators Nisha Kumari
2019-06-12 11:00 ` [PATCH 3/4] regulator: Add labibb driver Nisha Kumari
2019-06-13 17:04 ` Bjorn Andersson
2019-06-18 6:13 ` Nisha Kumari
2019-06-13 17:25 ` Mark Brown
2019-06-18 6:21 ` Nisha Kumari
2019-06-18 10:59 ` Mark Brown
2019-06-12 11:00 ` [PATCH 4/4] regulator: adding interrupt handling in labibb regulator Nisha Kumari
2019-06-13 17:27 ` Mark Brown
2019-06-18 6:23 ` Nisha Kumari
2020-04-28 5:16 ` Sumit Semwal
2020-04-28 11:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428110942.GC5677@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nishakumari@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).