From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
jorge.ramirez-ortiz@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: qcom_spmi: Do NULL check for lvs
Date: Thu, 20 Jun 2019 10:13:52 -0700 [thread overview]
Message-ID: <20190620171352.GA19899@builder> (raw)
In-Reply-To: <20190620142228.11773-1-jeffrey.l.hugo@gmail.com>
On Thu 20 Jun 07:22 PDT 2019, Jeffrey Hugo wrote:
> Low-voltage switches (lvs) don't have set_points since the voltage ranges
> of the output are really controlled by the inputs. This is a problem for
> the newly added linear range support in the probe(), as that will cause
> a null pointer dereference error on older platforms like msm8974 which
> happen to need to control some of the implemented lvs.
>
> Fix this by adding the appropriate null check.
>
Thanks Jeff, this resolves the regression I've seen the last couple of
days on linux-next.
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Fixes: 86f4ff7a0c0c ("regulator: qcom_spmi: enable linear range info")
> Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
> drivers/regulator/qcom_spmi-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
> index 877df33e0246..7f51c5fc8194 100644
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -2045,7 +2045,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev)
> }
> }
>
> - if (vreg->set_points->count == 1) {
> + if (vreg->set_points && vreg->set_points->count == 1) {
> /* since there is only one range */
> range = vreg->set_points->range;
> vreg->desc.uV_step = range->step_uV;
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-06-20 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 14:22 [PATCH] regulator: qcom_spmi: Do NULL check for lvs Jeffrey Hugo
2019-06-20 17:13 ` Bjorn Andersson [this message]
2019-06-24 16:32 ` Applied "regulator: qcom_spmi: Do NULL check for lvs" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620171352.GA19899@builder \
--to=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).