Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] regulator: qcom_spmi: Do NULL check for lvs
@ 2019-06-20 14:22 Jeffrey Hugo
  2019-06-20 17:13 ` Bjorn Andersson
  2019-06-24 16:32 ` Applied "regulator: qcom_spmi: Do NULL check for lvs" to the regulator tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2019-06-20 14:22 UTC (permalink / raw)
  To: bjorn.andersson, lgirdwood, broonie, jorge.ramirez-ortiz
  Cc: linux-arm-msm, linux-kernel, Jeffrey Hugo

Low-voltage switches (lvs) don't have set_points since the voltage ranges
of the output are really controlled by the inputs.  This is a problem for
the newly added linear range support in the probe(), as that will cause
a null pointer dereference error on older platforms like msm8974 which
happen to need to control some of the implemented lvs.

Fix this by adding the appropriate null check.

Fixes: 86f4ff7a0c0c ("regulator: qcom_spmi: enable linear range info")
Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
---
 drivers/regulator/qcom_spmi-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index 877df33e0246..7f51c5fc8194 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -2045,7 +2045,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev)
 			}
 		}
 
-		if (vreg->set_points->count == 1) {
+		if (vreg->set_points && vreg->set_points->count == 1) {
 			/* since there is only one range */
 			range = vreg->set_points->range;
 			vreg->desc.uV_step = range->step_uV;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: qcom_spmi: Do NULL check for lvs
  2019-06-20 14:22 [PATCH] regulator: qcom_spmi: Do NULL check for lvs Jeffrey Hugo
@ 2019-06-20 17:13 ` Bjorn Andersson
  2019-06-24 16:32 ` Applied "regulator: qcom_spmi: Do NULL check for lvs" to the regulator tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2019-06-20 17:13 UTC (permalink / raw)
  To: Jeffrey Hugo
  Cc: lgirdwood, broonie, jorge.ramirez-ortiz, linux-arm-msm, linux-kernel

On Thu 20 Jun 07:22 PDT 2019, Jeffrey Hugo wrote:

> Low-voltage switches (lvs) don't have set_points since the voltage ranges
> of the output are really controlled by the inputs.  This is a problem for
> the newly added linear range support in the probe(), as that will cause
> a null pointer dereference error on older platforms like msm8974 which
> happen to need to control some of the implemented lvs.
> 
> Fix this by adding the appropriate null check.
> 

Thanks Jeff, this resolves the regression I've seen the last couple of
days on linux-next.

Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Fixes: 86f4ff7a0c0c ("regulator: qcom_spmi: enable linear range info")
> Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
>  drivers/regulator/qcom_spmi-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
> index 877df33e0246..7f51c5fc8194 100644
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -2045,7 +2045,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev)
>  			}
>  		}
>  
> -		if (vreg->set_points->count == 1) {
> +		if (vreg->set_points && vreg->set_points->count == 1) {
>  			/* since there is only one range */
>  			range = vreg->set_points->range;
>  			vreg->desc.uV_step = range->step_uV;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "regulator: qcom_spmi: Do NULL check for lvs" to the regulator tree
  2019-06-20 14:22 [PATCH] regulator: qcom_spmi: Do NULL check for lvs Jeffrey Hugo
  2019-06-20 17:13 ` Bjorn Andersson
@ 2019-06-24 16:32 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-06-24 16:32 UTC (permalink / raw)
  To: Jeffrey Hugo
  Cc: Bjorn Andersson, bjorn.andersson, broonie, jorge.ramirez-ortiz,
	lgirdwood, linux-arm-msm, linux-kernel, Mark Brown

The patch

   regulator: qcom_spmi: Do NULL check for lvs

has been applied to the regulator tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From b01d18232587881ae813d4a1d14c8d9a2ac36b15 Mon Sep 17 00:00:00 2001
From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Date: Thu, 20 Jun 2019 07:22:28 -0700
Subject: [PATCH] regulator: qcom_spmi: Do NULL check for lvs

Low-voltage switches (lvs) don't have set_points since the voltage ranges
of the output are really controlled by the inputs.  This is a problem for
the newly added linear range support in the probe(), as that will cause
a null pointer dereference error on older platforms like msm8974 which
happen to need to control some of the implemented lvs.

Fix this by adding the appropriate null check.

Fixes: 86f4ff7a0c0c ("regulator: qcom_spmi: enable linear range info")
Reported-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/qcom_spmi-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
index 877df33e0246..7f51c5fc8194 100644
--- a/drivers/regulator/qcom_spmi-regulator.c
+++ b/drivers/regulator/qcom_spmi-regulator.c
@@ -2045,7 +2045,7 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev)
 			}
 		}
 
-		if (vreg->set_points->count == 1) {
+		if (vreg->set_points && vreg->set_points->count == 1) {
 			/* since there is only one range */
 			range = vreg->set_points->range;
 			vreg->desc.uV_step = range->step_uV;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-20 14:22 [PATCH] regulator: qcom_spmi: Do NULL check for lvs Jeffrey Hugo
2019-06-20 17:13 ` Bjorn Andersson
2019-06-24 16:32 ` Applied "regulator: qcom_spmi: Do NULL check for lvs" to the regulator tree Mark Brown

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org linux-arm-msm@archiver.kernel.org
	public-inbox-index linux-arm-msm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox