[PATCH v2 0/2] Add Sharp panel option for Lenovo Miix 630

[PATCH v2 0/2] Add Sharp panel option for Lenovo Miix 630

[Jeffrey Hugo]

The Lenovo Miix 630 laptop can be found with one of two panels - a BOE
or Sharp option.  This likely provides options during manufacturing.

These panels connect via eDP, however they sit behind a DSI to eDP
bridge on the laptop, so they can easily be handled by the existing
simple panel code.

This series adds support for the Sharp option.

v2:
-removed no-hpd from dt example
-added .bus_format and .bus_flags fields based on reviews
-added .flags after Bjorn pointed me to something I missed
-added Sam's reviewed-by tags

Jeffrey Hugo (2):
  dt-bindings: panel: Add Sharp LD-D5116Z01B
  drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

 .../display/panel/sharp,ld-d5116z01b.txt      | 26 +++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt

-- 
2.17.1

[PATCH v2 1/2] dt-bindings: panel: Add Sharp LD-D5116Z01B

[Jeffrey Hugo]

The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution.

Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
 .../display/panel/sharp,ld-d5116z01b.txt      | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt b/Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt
new file mode 100644
index 000000000000..fd9cf39bde77
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt
@@ -0,0 +1,26 @@
+Sharp LD-D5116Z01B 12.3" WUXGA+ eDP panel
+
+Required properties:
+- compatible: should be "sharp,ld-d5116z01b"
+- power-supply: regulator to provide the VCC supply voltage (3.3 volts)
+
+This binding is compatible with the simple-panel binding.
+
+The device node can contain one 'port' child node with one child
+'endpoint' node, according to the bindings defined in [1]. This
+node should describe panel's video bus.
+
+[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
+
+Example:
+
+	panel: panel {
+		compatible = "sharp,ld-d5116z01b";
+		power-supply = <&vlcd_3v3>;
+
+		port {
+			panel_ep: endpoint {
+				remote-endpoint = <&bridge_out_ep>;
+			};
+		};
+	};
-- 
2.17.1

[PATCH v2 2/2] drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

[Jeffrey Hugo]

The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution.

Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5a93c4edf1e4..a8808b13c370 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2354,6 +2354,32 @@ static const struct panel_desc samsung_ltn140at29_301 = {
 	},
 };
 
+static const struct drm_display_mode sharp_ld_d5116z01b_mode = {
+	.clock = 168480,
+	.hdisplay = 1920,
+	.hsync_start = 1920 + 48,
+	.hsync_end = 1920 + 48 + 32,
+	.htotal = 1920 + 48 + 32 + 80,
+	.vdisplay = 1280,
+	.vsync_start = 1280 + 3,
+	.vsync_end = 1280 + 3 + 10,
+	.vtotal = 1280 + 3 + 10 + 57,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc sharp_ld_d5116z01b = {
+	.modes = &sharp_ld_d5116z01b_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 260,
+		.height = 120,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DATA_MSB_TO_LSB,
+};
+
 static const struct drm_display_mode sharp_lq035q7db03_mode = {
 	.clock = 5500,
 	.hdisplay = 240,
@@ -3002,6 +3028,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "samsung,ltn140at29-301",
 		.data = &samsung_ltn140at29_301,
+	}, {
+		.compatible = "sharp,ld-d5116z01b",
+		.data = &sharp_ld_d5116z01b,
 	}, {
 		.compatible = "sharp,lq035q7db03",
 		.data = &sharp_lq035q7db03,
-- 
2.17.1

Re: [PATCH v2 1/2] dt-bindings: panel: Add Sharp LD-D5116Z01B

[Rob Herring]

On Mon,  8 Jul 2019 09:57:53 -0700, Jeffrey Hugo wrote:
> The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution.
> 
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  .../display/panel/sharp,ld-d5116z01b.txt      | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 0/2] Add Sharp panel option for Lenovo Miix 630

[Sam Ravnborg]

Hi Jeffrey.

On Mon, Jul 08, 2019 at 09:56:47AM -0700, Jeffrey Hugo wrote:
> The Lenovo Miix 630 laptop can be found with one of two panels - a BOE
> or Sharp option.  This likely provides options during manufacturing.
> 
> These panels connect via eDP, however they sit behind a DSI to eDP
> bridge on the laptop, so they can easily be handled by the existing
> simple panel code.
> 
> This series adds support for the Sharp option.
> 
> v2:
> -removed no-hpd from dt example
> -added .bus_format and .bus_flags fields based on reviews
> -added .flags after Bjorn pointed me to something I missed
> -added Sam's reviewed-by tags
> 
> Jeffrey Hugo (2):
>   dt-bindings: panel: Add Sharp LD-D5116Z01B
>   drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

Thanks.
Both patches applied and pushed to drm-misc-next.

Are you up to a little janitorial work?
Today the preferred format for bindings files are the new yaml format.
Could you update 'your' file, and maybe the other sharp files too?
It would be good to have some progress in this.

	Sam

Re: [PATCH v2 0/2] Add Sharp panel option for Lenovo Miix 630

[Jeffrey Hugo]

On Fri, Jul 26, 2019 at 6:36 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jeffrey.
>
> On Mon, Jul 08, 2019 at 09:56:47AM -0700, Jeffrey Hugo wrote:
> > The Lenovo Miix 630 laptop can be found with one of two panels - a BOE
> > or Sharp option.  This likely provides options during manufacturing.
> >
> > These panels connect via eDP, however they sit behind a DSI to eDP
> > bridge on the laptop, so they can easily be handled by the existing
> > simple panel code.
> >
> > This series adds support for the Sharp option.
> >
> > v2:
> > -removed no-hpd from dt example
> > -added .bus_format and .bus_flags fields based on reviews
> > -added .flags after Bjorn pointed me to something I missed
> > -added Sam's reviewed-by tags
> >
> > Jeffrey Hugo (2):
> >   dt-bindings: panel: Add Sharp LD-D5116Z01B
> >   drm/panel: simple: Add support for Sharp LD-D5116Z01B panel
>
> Thanks.
> Both patches applied and pushed to drm-misc-next.

Excellent.  Thanks

> Are you up to a little janitorial work?
> Today the preferred format for bindings files are the new yaml format.
> Could you update 'your' file, and maybe the other sharp files too?

I confess I haven't yet familiarized myself with the yaml format yet,
but I'll take a look and do an update once I understand the
requirements.