From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: "Brad Love" <brad@nextdimension.cc>,
"Antti Palosaari" <crope@iki.fi>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v3] media: si2168: Refactor command setup code
Date: Sat, 13 Jul 2019 07:02:56 -0300 [thread overview]
Message-ID: <20190713070256.3495de51@coco.lan> (raw)
In-Reply-To: <10f064c5-1634-c9f9-fcc9-6ab51b7f8f0b@free.fr>
Em Sat, 13 Jul 2019 00:11:12 +0200
Marc Gonzalez <marc.w.gonzalez@free.fr> escreveu:
> On 12/07/2019 19:45, Mauro Carvalho Chehab wrote:
>
> > Brad Love <brad@nextdimension.cc> escreveu:
> >
> >> On 04/07/2019 05.33, Marc Gonzalez wrote:
> >>
> >>> +#define CMD_SETUP(cmd, args, rlen) \
> >>> + cmd_setup(cmd, args, sizeof(args) - 1, rlen)
> >>> +
> >>
> >> This is only a valid helper if args is a null terminated string. It just
> >> so happens that every instance in this driver is, but that could be a
> >> silent pitfall if someone used a u8 array with this macro.
> >
> > Actually, it is uglier than that. If one writes something like:
> >
> > char buf[20];
> >
> > buf[0] = 0x20;
> > buf[1] = 0x03;
> >
> > CMD_SETUP(cmd, buf, 0);
> >
> > // some other init, up to 5 values, then another CMD_SETUP()
>
> I'm not sure what you mean in the // comment.
> What kind of init? Why up to 5 values? Why another CMD_SETUP?
I mean that the same buffer could be re-used to do something like:
char buf[20];
buf[0] = 0x20;
buf[1] = 0x03;
CMD_SETUP(cmd, buf, 0); // write size here should be 2
buf[2] = 0x04
buf[3] = 0x00
buf[4] = 0x05
CMD_SETUP(cmd, buf, 0); // write size here should be 5
This kind of pattern happens on other drivers and someone may
end needing something like that at this driver on some future.
> > sizeof() will evaluate to 20, and not to 2, with would be the
> > expected buffer size, and it will pass 18 random values.
> >
> > IMHO, using sizeof() here is a very bad idea.
>
> You may have a point...
> (Though I'm not proposing a kernel API function, merely code
> refactoring for a single file that's unlikely to change going
> forward.)
Yes, I know, but we had already some bugs due to the usage of
sizeof() on similar macros at drivers in the past.
> It's also bad form to repeat the cmd size (twice) when the compiler
> can figure it out automatically for string literals (which is 95%
> of the use-cases).
>
> I can drop the macro, and just use the helper...
The helper function sounds fine.
>
> Or maybe there's a GCC extension to test that an argument is a
> string literal...
If this could be evaluated by some advanced macro logic that
would work not only with gcc but also with clang, then a
macro that does what you proposed could be useful.
There are some ways to check the type of a macro argument, but I'm
not sure if are there any way for it to distinguish between a
string constant from a char * array.
Thanks,
Mauro
next prev parent reply other threads:[~2019-07-13 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 10:33 [PATCH v3] media: si2168: Refactor command setup code Marc Gonzalez
2019-07-12 8:43 ` Uwe Kleine-König
2019-07-12 9:37 ` Marc Gonzalez
2019-07-12 15:47 ` Brad Love
2019-07-12 17:45 ` Mauro Carvalho Chehab
2019-07-12 22:11 ` Marc Gonzalez
2019-07-13 10:02 ` Mauro Carvalho Chehab [this message]
2019-07-14 18:31 ` Matthias Schwarzott
2019-07-12 21:41 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190713070256.3495de51@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=brad@nextdimension.cc \
--cc=crope@iki.fi \
--cc=j.neuschaefer@gmx.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).