From: Jordan Crouse <jcrouse@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Georgi Djakov <georgi.djakov@linaro.org>,
linux-clk@vger.kernel.org, Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH v2] drivers: qcom: Add BCM vote macro to header
Date: Tue, 13 Aug 2019 12:47:17 -0600 [thread overview]
Message-ID: <20190813184717.GA28465@jcrouse1-lnx.qualcomm.com> (raw)
In-Reply-To: <20190807234232.27AA720880@mail.kernel.org>
On Wed, Aug 07, 2019 at 04:42:31PM -0700, Stephen Boyd wrote:
> Quoting Jordan Crouse (2019-08-05 13:33:46)
> > The macro to generate a Bus Controller Manager (BCM) TCS command is used
> > by the interconnect driver but might also be interesting to other
> > drivers that need to construct TCS commands for sub processors so move
> > it out of the sdm845 specific file and into the header.
> >
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > ---
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
>
> Unless this is supposed to be applied by me?
I figured this landed in Bjorn's domain, but you guys can fight it out if you
want.
Jordan
> BTW, I wonder why we need an rpm clk driver much at all nowadays, except
> maybe for the XO clk state. The big user, from what I can tell, is the
> interconnect driver and we don't use any of the features of the clk
> framework besides the API to set a frequency. Maybe it would be better
> to just push push the bus frequency logic into interconnect code, then
> XO clk is the only thing we need to keep, and it can be a simple on/off
> thing.
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-08-13 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 20:33 [PATCH v2] drivers: qcom: Add BCM vote macro to header Jordan Crouse
2019-08-07 23:42 ` Stephen Boyd
2019-08-13 18:47 ` Jordan Crouse [this message]
2019-08-13 20:09 ` Stephen Boyd
2019-08-19 16:52 ` Bjorn Andersson
2019-08-19 18:26 ` Stephen Boyd
2019-08-19 16:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813184717.GA28465@jcrouse1-lnx.qualcomm.com \
--to=jcrouse@codeaurora.org \
--cc=agross@kernel.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).