From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Jordan Crouse <jcrouse@codeaurora.org>,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Georgi Djakov <georgi.djakov@linaro.org>,
linux-clk@vger.kernel.org, Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH v2] drivers: qcom: Add BCM vote macro to header
Date: Mon, 19 Aug 2019 09:52:55 -0700 [thread overview]
Message-ID: <20190819165255.GA26807@tuxbook-pro> (raw)
In-Reply-To: <20190807234232.27AA720880@mail.kernel.org>
On Wed 07 Aug 16:42 PDT 2019, Stephen Boyd wrote:
> Quoting Jordan Crouse (2019-08-05 13:33:46)
> > The macro to generate a Bus Controller Manager (BCM) TCS command is used
> > by the interconnect driver but might also be interesting to other
> > drivers that need to construct TCS commands for sub processors so move
> > it out of the sdm845 specific file and into the header.
> >
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > ---
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
>
> Unless this is supposed to be applied by me?
>
> BTW, I wonder why we need an rpm clk driver much at all nowadays, except
> maybe for the XO clk state. The big user, from what I can tell, is the
> interconnect driver and we don't use any of the features of the clk
> framework besides the API to set a frequency. Maybe it would be better
> to just push push the bus frequency logic into interconnect code, then
> XO clk is the only thing we need to keep, and it can be a simple on/off
> thing.
>
There's been a number of cases where we'll need to enable the buffered
XOs, but perhaps these are handled by other subsystems these days(?)
If so the one case that remains would be the operation of explicitly
holding CXO enabled during operations such as booting the remoteprocs.
Regards,
Bjorn
next prev parent reply other threads:[~2019-08-19 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 20:33 [PATCH v2] drivers: qcom: Add BCM vote macro to header Jordan Crouse
2019-08-07 23:42 ` Stephen Boyd
2019-08-13 18:47 ` Jordan Crouse
2019-08-13 20:09 ` Stephen Boyd
2019-08-19 16:52 ` Bjorn Andersson [this message]
2019-08-19 18:26 ` Stephen Boyd
2019-08-19 16:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819165255.GA26807@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).