* [RESEND PATCH v2 0/2] Add PDC Global and AOSS reset support @ 2019-08-24 15:24 Sibi Sankar 2019-08-24 15:24 ` [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar 2019-08-24 15:24 ` [RESEND PATCH v2 2/2] dt-bindings: reset: pdc: Add PDC Global " Sibi Sankar 0 siblings, 2 replies; 7+ messages in thread From: Sibi Sankar @ 2019-08-24 15:24 UTC (permalink / raw) To: p.zabel, robh+dt, bjorn.andersson Cc: agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel, Sibi Sankar This patch series adds PDC Global and AOSS reset support on SC7180 SoCs. v2: * Addressed Philipp's review comments Sibi Sankar (2): dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs dt-bindings: reset: pdc: Add PDC Global binding for SC7180 SoCs Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- Documentation/devicetree/bindings/reset/qcom,pdc-global.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs 2019-08-24 15:24 [RESEND PATCH v2 0/2] Add PDC Global and AOSS reset support Sibi Sankar @ 2019-08-24 15:24 ` Sibi Sankar 2019-08-26 8:36 ` Philipp Zabel 2019-08-30 5:32 ` Stephen Boyd 2019-08-24 15:24 ` [RESEND PATCH v2 2/2] dt-bindings: reset: pdc: Add PDC Global " Sibi Sankar 1 sibling, 2 replies; 7+ messages in thread From: Sibi Sankar @ 2019-08-24 15:24 UTC (permalink / raw) To: p.zabel, robh+dt, bjorn.andersson Cc: agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel, Sibi Sankar Add SC7180 AOSS reset to the list of possible bindings. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt index 510c748656ec5..3eb6a22ced4bc 100644 --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt @@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-aoss-cc" + Definition: must be one of: + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" - reg: Usage: required -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs 2019-08-24 15:24 ` [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar @ 2019-08-26 8:36 ` Philipp Zabel 2019-08-29 2:38 ` Sibi Sankar 2019-08-30 5:32 ` Stephen Boyd 1 sibling, 1 reply; 7+ messages in thread From: Philipp Zabel @ 2019-08-26 8:36 UTC (permalink / raw) To: Sibi Sankar, robh+dt, bjorn.andersson Cc: agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel On Sat, 2019-08-24 at 20:54 +0530, Sibi Sankar wrote: > Add SC7180 AOSS reset to the list of possible bindings. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > index 510c748656ec5..3eb6a22ced4bc 100644 > --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > @@ -8,8 +8,8 @@ Required properties: > - compatible: > Usage: required > Value type: <string> > - Definition: must be: > - "qcom,sdm845-aoss-cc" > + Definition: must be one of: > + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" Should this emphasize that the common sdm845 compatible always has to be included? + Definition: must be: + "qcom,sdm845-aoss-cc" for SDM845 or + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" for SC7180 or like the qcom,kpss-gcc bindings: + Definition: should be one of the following. The generic compatible + "qcom,sdm845-aoss-cc" should also be included. + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" + "qcom,sdm845-aoss-cc" regards Philipp ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs 2019-08-26 8:36 ` Philipp Zabel @ 2019-08-29 2:38 ` Sibi Sankar 0 siblings, 0 replies; 7+ messages in thread From: Sibi Sankar @ 2019-08-29 2:38 UTC (permalink / raw) To: Philipp Zabel Cc: robh+dt, bjorn.andersson, agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel, linux-kernel-owner Hey Philipp, Thanks for the review! On 2019-08-26 14:06, Philipp Zabel wrote: > On Sat, 2019-08-24 at 20:54 +0530, Sibi Sankar wrote: >> Add SC7180 AOSS reset to the list of possible bindings. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> index 510c748656ec5..3eb6a22ced4bc 100644 >> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> @@ -8,8 +8,8 @@ Required properties: >> - compatible: >> Usage: required >> Value type: <string> >> - Definition: must be: >> - "qcom,sdm845-aoss-cc" >> + Definition: must be one of: >> + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" > > Should this emphasize that the common sdm845 compatible always has to > be > included? > > + Definition: must be: > + "qcom,sdm845-aoss-cc" for SDM845 or can we drop the "or" since we would need to keep adding it in the future. > + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" for SC7180 I prefer ^^ approach for the reasons stated below. > > or like the qcom,kpss-gcc bindings: > > + Definition: should be one of the following. The generic > compatible > + "qcom,sdm845-aoss-cc" should also be > included. > + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" > + It is extremely unlikely that future SoCs would maintain same number of reset lines/offsets due to the constant flux in remote processors being added to the SoCs. So a generic compatible might not make sense here. > "qcom,sdm845-aoss-cc" > > regards > Philipp -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs 2019-08-24 15:24 ` [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar 2019-08-26 8:36 ` Philipp Zabel @ 2019-08-30 5:32 ` Stephen Boyd 2019-08-30 18:34 ` Sibi Sankar 1 sibling, 1 reply; 7+ messages in thread From: Stephen Boyd @ 2019-08-30 5:32 UTC (permalink / raw) To: Sibi Sankar, bjorn.andersson, p.zabel, robh+dt Cc: agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel, Sibi Sankar Quoting Sibi Sankar (2019-08-24 08:24:10) > Add SC7180 AOSS reset to the list of possible bindings. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- Can you convert this binding to YAML/JSON schema? Would help to describe the 'one of' requirement below in a more structured way. > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > index 510c748656ec5..3eb6a22ced4bc 100644 > --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt > @@ -8,8 +8,8 @@ Required properties: > - compatible: > Usage: required > Value type: <string> > - Definition: must be: > - "qcom,sdm845-aoss-cc" > + Definition: must be one of: ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs 2019-08-30 5:32 ` Stephen Boyd @ 2019-08-30 18:34 ` Sibi Sankar 0 siblings, 0 replies; 7+ messages in thread From: Sibi Sankar @ 2019-08-30 18:34 UTC (permalink / raw) To: Stephen Boyd Cc: bjorn.andersson, p.zabel, robh+dt, agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel, linux-arm-msm-owner Hey Stephen, Thanks for the review! On 2019-08-30 11:02, Stephen Boyd wrote: > Quoting Sibi Sankar (2019-08-24 08:24:10) >> Add SC7180 AOSS reset to the list of possible bindings. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- > > Can you convert this binding to YAML/JSON schema? Would help to > describe > the 'one of' requirement below in a more structured way. yeah converting them shouldn't take time but 'oneof' isn't the requirement here. We want to specify that sc7180 should continue to use the sdm845 compatible since the offset/ num of reset are identical. > >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> index 510c748656ec5..3eb6a22ced4bc 100644 >> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> @@ -8,8 +8,8 @@ Required properties: >> - compatible: >> Usage: required >> Value type: <string> >> - Definition: must be: >> - "qcom,sdm845-aoss-cc" >> + Definition: must be one of: -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH v2 2/2] dt-bindings: reset: pdc: Add PDC Global binding for SC7180 SoCs 2019-08-24 15:24 [RESEND PATCH v2 0/2] Add PDC Global and AOSS reset support Sibi Sankar 2019-08-24 15:24 ` [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar @ 2019-08-24 15:24 ` Sibi Sankar 1 sibling, 0 replies; 7+ messages in thread From: Sibi Sankar @ 2019-08-24 15:24 UTC (permalink / raw) To: p.zabel, robh+dt, bjorn.andersson Cc: agross, mark.rutland, linux-arm-msm, devicetree, linux-kernel, Sibi Sankar Add SC7180 PDC global to the list of possible bindings. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- Documentation/devicetree/bindings/reset/qcom,pdc-global.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt index a62a492843e70..c1fef349f0faf 100644 --- a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt @@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-pdc-global" + Definition: must be one of: + "qcom,sc7180-pdc-global", "qcom,sdm845-pdc-global" - reg: Usage: required -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-30 18:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-08-24 15:24 [RESEND PATCH v2 0/2] Add PDC Global and AOSS reset support Sibi Sankar 2019-08-24 15:24 ` [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar 2019-08-26 8:36 ` Philipp Zabel 2019-08-29 2:38 ` Sibi Sankar 2019-08-30 5:32 ` Stephen Boyd 2019-08-30 18:34 ` Sibi Sankar 2019-08-24 15:24 ` [RESEND PATCH v2 2/2] dt-bindings: reset: pdc: Add PDC Global " Sibi Sankar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).