Re: [PATCH v2 3/5] arm64: dts: qcom: Add configuration for PM8950 and PMI8950 peripherals

[Brian Masney <masneyb@onstation.org>]

On Tue, Nov 05, 2019 at 12:18:45PM +0100, AngeloGioacchino Del Regno wrote:
> Il giorno gio 31 ott 2019 alle ore 20:58 Brian Masney
> <masneyb@onstation.org> ha scritto:
> >
> > Thanks for the patches. Good to see the progress!
> >
> > On Thu, Oct 31, 2019 at 12:16:43PM +0100, kholk11@gmail.com wrote:
> > > From: AngeloGioacchino Del Regno <kholk11@gmail.com>
> > >
> > > The PM(I)8950 feature integrated peripherals like ADC, GPIO
> > > controller, MPPs, PON keys and others.
> > > Add them to DT files that will be imported on boards having
> > > this PMIC combo (or one of them, anyways).
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> > > ---
> > >  arch/arm64/boot/dts/qcom/pm8950.dtsi  | 187 ++++++++++++++++++++++++++
> > >  arch/arm64/boot/dts/qcom/pmi8950.dtsi |  98 ++++++++++++++
> > >  2 files changed, 285 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/qcom/pm8950.dtsi
> > >  create mode 100644 arch/arm64/boot/dts/qcom/pmi8950.dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/pm8950.dtsi b/arch/arm64/boot/dts/qcom/pm8950.dtsi
> > > new file mode 100644
> > > index 000000000000..a349a8dd867e
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/qcom/pm8950.dtsi
> > > @@ -0,0 +1,187 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +// Copyright (c) 2019, AngeloGioacchino Del Regno <kholk11@gmail.com>
> > > +
> > > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > > +#include <dt-bindings/input/linux-event-codes.h>
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
> > > +#include <dt-bindings/spmi/spmi.h>
> > > +
> > > +&spmi_bus {
> > > +     pm8950_lsid0: pm8950@0 {
> > > +             compatible = "qcom,pm8950", "qcom,spmi-pmic";
> > > +             reg = <0x0 SPMI_USID>;
> > > +             #address-cells = <1>;
> > > +             #size-cells = <0>;
> > > +
> > > +             pon@800 {
> > > +                     compatible = "qcom,pm8916-pon";
> > > +                     reg = <0x0800>;
> > > +                     mode-bootloader = <0x2>;
> > > +                     mode-recovery = <0x1>;
> > > +
> > > +                     pwrkey {
> > > +                             compatible = "qcom,pm8941-pwrkey";
> > > +                             interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> > > +                             debounce = <15625>;
> > > +                             bias-pull-up;
> > > +                             linux,code = <KEY_POWER>;
> > > +                     };
> > > +             };
> > > +
> > > +             pm8950_mpps: mpps@a000 {
> > > +                     compatible = "qcom,pm8950-mpp", "qcom,spmi-mpp";
> > > +                     reg = <0xa000>;
> > > +                     gpio-controller;
> > > +                     #gpio-cells = <2>;
> > > +                     interrupts = <0 0xa0 0 IRQ_TYPE_NONE>,
> > > +                                  <0 0xa1 0 IRQ_TYPE_NONE>,
> > > +                                  <0 0xa2 0 IRQ_TYPE_NONE>,
> > > +                                  <0 0xa3 0 IRQ_TYPE_NONE>;
> > > +
> > > +                     /* MPP_2: PA_THERM1 */
> > > +                     pa_therm {
> > > +                             pm8950_mpp2_def: pa_therm1_default {
> > > +                                     pins = "mpp2";
> > > +                                     function = "analog";
> > > +                                     input-enable;
> > > +                                     qcom,amux-route =
> > > +                                             <PMIC_MPP_AMUX_ROUTE_CH6>;
> > > +                             };
> > > +                     };
> > > +
> > > +                     /* MPP_4: QUIET_THERM */
> > > +                     case_therm {
> > > +                             pm8950_mpp4_def: case_therm_default {
> > > +                                     pins = "mpp4";
> > > +                                     function = "analog";
> > > +                                     input-enable;
> > > +                                     qcom,amux-route =
> > > +                                             <PMIC_MPP_AMUX_ROUTE_CH8>;
> > > +                             };
> > > +                     };
> > > +             };
> > > +
> > > +             pm8950_gpios: gpio@c000 {
> > > +                     compatible = "qcom,pm8950-gpio", "qcom,spmi-gpio";
> > > +                     reg = <0xc000>;
> > > +                     gpio-controller;
> > > +                     #gpio-cells = <2>;
> > > +                     interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> > > +                             <0 0xc1 0 IRQ_TYPE_NONE>,
> > > +                             <0 0xc3 0 IRQ_TYPE_NONE>,
> > > +                             <0 0xc4 0 IRQ_TYPE_NONE>,
> > > +                             <0 0xc5 0 IRQ_TYPE_NONE>,
> > > +                             <0 0xc6 0 IRQ_TYPE_NONE>,
> > > +                             <0 0xc7 0 IRQ_TYPE_NONE>;
> > > +             };
> >
> > Please add gpio-ranges so that gpio-hogging will work properly. See
> > commits for pm8941 and spmi-gpio that describes the problem and how
> > to fix it:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=149a96047237574b756d872007c006acd0cc6687
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cdd3d64d843a2a4c658a182b744bfefbd021d542
> >
> > Please drop the interrupts property and configure this to be a
> > hierarchical IRQ chip. See these two commits for more details:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca69e2d165eb3d060cc9ad70a745e27a2cf4310b
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f540fb4821a5444350ab3311fff60013d755d8f
> >
> > There is some kind of mask that you'll need to add to omit 0xc2 that
> > Linus Walleij told me about before. I don't have the property handy
> > right now, but can look it up later if needed.
> >
> > Brian
> 
> That looks cleaner! Didn't know about it... Anyway, the only way that I know
> to exclude the 0xc2 is something like
> 
> gpio-ranges = <&pm8950_gpios 0 0 8>;
> gpio-reserved-ranges = <2 1>;
> 
> ...but you're talking about a mask? Is there a different way of doing it, or
> were you referring to the gpio-reserved-ranges property?

Yes, it looks like gpio-reserved-ranges property is what you need.

Brian