From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Evan Green <evgreen@chromium.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] phy: qcom-qmp: Increase PHY ready timeout
Date: Tue, 10 Dec 2019 11:11:42 -0800 [thread overview]
Message-ID: <20191210191142.GF314059@yoga> (raw)
In-Reply-To: <CAE=gft5mLSqsJzj=DtesH3G68_wSKUr8rZ5iubOerimQmZKegA@mail.gmail.com>
On Tue 10 Dec 10:47 PST 2019, Evan Green wrote:
> On Wed, Nov 6, 2019 at 4:09 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > It's typical for the QHP PHY to take slightly above 1ms to initialize,
> > so increase the timeout of the PHY ready check to 10ms - as already done
> > in the downstream PCIe driver.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Tested-by: Evan Green <evgreen@chromium.org>
>
Thanks.
> Should this have a Fixes tag for 14ced7e3a1ae9 ("phy: qcom-qmp:
> Correct ready status, again")?
For UFS it would be 885bd765963b ("phy: qcom-qmp: Correct READY_STATUS
poll break condition"), but I think that before the two we would exit
the poll immediately, so we would only hit the timeout in the "error"
case - where the PHY did come up in a timely fashion.
So I don't think there is a particular commit to "Fixes:"...
But given that this is no longer only needed for the (new) QHP PCIe
instance it would be reasonable to Cc: stable, to get it into v5.4
Regards,
Bjorn
next prev parent reply other threads:[~2019-12-10 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 0:09 [PATCH v3 0/5] phy: qcom-qmp: Add SDM845 QMP and QHP PHYs Bjorn Andersson
2019-11-07 0:09 ` [PATCH v3 1/5] dt-bindings: phy-qcom-qmp: Add SDM845 PCIe to binding Bjorn Andersson
2019-11-07 0:09 ` [PATCH v3 2/5] phy: qcom-qmp: Increase PHY ready timeout Bjorn Andersson
2019-12-10 18:47 ` Evan Green
2019-12-10 19:11 ` Bjorn Andersson [this message]
2019-11-07 0:09 ` [PATCH v3 3/5] phy: qcom: qmp: Use power_on/off ops for PCIe Bjorn Andersson
2019-11-07 0:09 ` [PATCH v3 4/5] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support Bjorn Andersson
2019-11-07 0:09 ` [PATCH v3 5/5] phy: qcom: qmp: Add SDM845 QHP PCIe PHY Bjorn Andersson
2019-11-07 15:20 ` [PATCH v3 0/5] phy: qcom-qmp: Add SDM845 QMP and QHP PHYs Julien Massot
2019-12-27 3:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210191142.GF314059@yoga \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).