* [PATCH] power: avs: qcom-cpr: add a printout after the driver has been initialized
@ 2020-01-13 20:02 Niklas Cassel
2020-01-24 17:10 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2020-01-13 20:02 UTC (permalink / raw)
To: Rafael J . Wysocki; +Cc: linux-pm, linux-arm-msm, Niklas Cassel
In order to easier inform the user that the driver has been initialized
successfully, add a printout after the driver has been initialized.
At the same time, remove a dev_dbg() that is now redundant.
Signed-off-by: Niklas Cassel <nks@flawful.org>
---
drivers/power/avs/qcom-cpr.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index 9192fb747653..b158a684d05c 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -1547,8 +1547,6 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
goto unlock;
}
- dev_dbg(drv->dev, "number of OPPs: %d\n", drv->num_corners);
-
drv->corners = devm_kcalloc(drv->dev, drv->num_corners,
sizeof(*drv->corners),
GFP_KERNEL);
@@ -1586,6 +1584,9 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
acc_desc->enable_mask,
acc_desc->enable_mask);
+ dev_info(drv->dev, "driver initialized with %u OPPs\n",
+ drv->num_corners);
+
unlock:
mutex_unlock(&drv->lock);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: avs: qcom-cpr: add a printout after the driver has been initialized
2020-01-13 20:02 [PATCH] power: avs: qcom-cpr: add a printout after the driver has been initialized Niklas Cassel
@ 2020-01-24 17:10 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-01-24 17:10 UTC (permalink / raw)
To: Niklas Cassel; +Cc: Rafael J . Wysocki, linux-pm, linux-arm-msm
On Mon 13 Jan 12:02 PST 2020, Niklas Cassel wrote:
> In order to easier inform the user that the driver has been initialized
> successfully, add a printout after the driver has been initialized.
>
> At the same time, remove a dev_dbg() that is now redundant.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
> drivers/power/avs/qcom-cpr.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 9192fb747653..b158a684d05c 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -1547,8 +1547,6 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
> goto unlock;
> }
>
> - dev_dbg(drv->dev, "number of OPPs: %d\n", drv->num_corners);
> -
> drv->corners = devm_kcalloc(drv->dev, drv->num_corners,
> sizeof(*drv->corners),
> GFP_KERNEL);
> @@ -1586,6 +1584,9 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
> acc_desc->enable_mask,
> acc_desc->enable_mask);
>
> + dev_info(drv->dev, "driver initialized with %u OPPs\n",
> + drv->num_corners);
> +
> unlock:
> mutex_unlock(&drv->lock);
>
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-24 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 20:02 [PATCH] power: avs: qcom-cpr: add a printout after the driver has been initialized Niklas Cassel
2020-01-24 17:10 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).