linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
@ 2020-03-10 14:37 Ansuel Smith
  2020-03-10 18:41 ` Rob Herring
  2020-03-13 20:57 ` Stephen Boyd
  0 siblings, 2 replies; 7+ messages in thread
From: Ansuel Smith @ 2020-03-10 14:37 UTC (permalink / raw)
  To: sboyd
  Cc: Ansuel Smith, John Crispin, Andy Gross, Bjorn Andersson,
	Michael Turquette, Rob Herring, Mark Rutland, linux-arm-msm,
	linux-clk, devicetree, linux-kernel

Add missing definition of rpm clk for ipq806x soc

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: John Crispin <john@phrozen.org>
---
 .../devicetree/bindings/clock/qcom,rpmcc.txt  |  1 +
 drivers/clk/qcom/clk-rpm.c                    | 35 +++++++++++++++++++
 include/dt-bindings/clock/qcom,rpmcc.h        |  4 +++
 3 files changed, 40 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
index 944719bd586f..4bb2cbeff2b4 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
@@ -15,6 +15,7 @@ Required properties :
 			"qcom,rpmcc-msm8916", "qcom,rpmcc"
 			"qcom,rpmcc-msm8974", "qcom,rpmcc"
 			"qcom,rpmcc-apq8064", "qcom,rpmcc"
+			"qcom,rpmcc-ipq806x", "qcom,rpmcc"
 			"qcom,rpmcc-msm8996", "qcom,rpmcc"
 			"qcom,rpmcc-msm8998", "qcom,rpmcc"
 			"qcom,rpmcc-qcs404", "qcom,rpmcc"
diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index 9e3110a71f12..f71d228fd6bd 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b/drivers/clk/qcom/clk-rpm.c
@@ -543,10 +543,45 @@ static const struct rpm_clk_desc rpm_clk_apq8064 = {
 	.num_clks = ARRAY_SIZE(apq8064_clks),
 };
 
+/* ipq806x */
+DEFINE_CLK_RPM(ipq806x, afab_clk, afab_a_clk, QCOM_RPM_APPS_FABRIC_CLK);
+DEFINE_CLK_RPM(ipq806x, cfpb_clk, cfpb_a_clk, QCOM_RPM_CFPB_CLK);
+DEFINE_CLK_RPM(ipq806x, daytona_clk, daytona_a_clk, QCOM_RPM_DAYTONA_FABRIC_CLK);
+DEFINE_CLK_RPM(ipq806x, ebi1_clk, ebi1_a_clk, QCOM_RPM_EBI1_CLK);
+DEFINE_CLK_RPM(ipq806x, sfab_clk, sfab_a_clk, QCOM_RPM_SYS_FABRIC_CLK);
+DEFINE_CLK_RPM(ipq806x, sfpb_clk, sfpb_a_clk, QCOM_RPM_SFPB_CLK);
+DEFINE_CLK_RPM(ipq806x, nss_fabric_0_clk, nss_fabric_0_a_clk, QCOM_RPM_NSS_FABRIC_0_CLK);
+DEFINE_CLK_RPM(ipq806x, nss_fabric_1_clk, nss_fabric_1_a_clk, QCOM_RPM_NSS_FABRIC_1_CLK);
+
+static struct clk_rpm *ipq806x_clks[] = {
+	[RPM_APPS_FABRIC_CLK] = &ipq806x_afab_clk,
+	[RPM_APPS_FABRIC_A_CLK] = &ipq806x_afab_a_clk,
+	[RPM_CFPB_CLK] = &ipq806x_cfpb_clk,
+	[RPM_CFPB_A_CLK] = &ipq806x_cfpb_a_clk,
+	[RPM_DAYTONA_FABRIC_CLK] = &ipq806x_daytona_clk,
+	[RPM_DAYTONA_FABRIC_A_CLK] = &ipq806x_daytona_a_clk,
+	[RPM_EBI1_CLK] = &ipq806x_ebi1_clk,
+	[RPM_EBI1_A_CLK] = &ipq806x_ebi1_a_clk,
+	[RPM_SYS_FABRIC_CLK] = &ipq806x_sfab_clk,
+	[RPM_SYS_FABRIC_A_CLK] = &ipq806x_sfab_a_clk,
+	[RPM_SFPB_CLK] = &ipq806x_sfpb_clk,
+	[RPM_SFPB_A_CLK] = &ipq806x_sfpb_a_clk,
+	[RPM_NSS_FABRIC_0_CLK] = &ipq806x_nss_fabric_0_clk,
+	[RPM_NSS_FABRIC_0_A_CLK] = &ipq806x_nss_fabric_0_a_clk,
+	[RPM_NSS_FABRIC_1_CLK] = &ipq806x_nss_fabric_1_clk,
+	[RPM_NSS_FABRIC_1_A_CLK] = &ipq806x_nss_fabric_1_a_clk,
+};
+
+static const struct rpm_clk_desc rpm_clk_ipq806x = {
+	.clks = ipq806x_clks,
+	.num_clks = ARRAY_SIZE(ipq806x_clks),
+};
+
 static const struct of_device_id rpm_clk_match_table[] = {
 	{ .compatible = "qcom,rpmcc-msm8660", .data = &rpm_clk_msm8660 },
 	{ .compatible = "qcom,rpmcc-apq8060", .data = &rpm_clk_msm8660 },
 	{ .compatible = "qcom,rpmcc-apq8064", .data = &rpm_clk_apq8064 },
+	{ .compatible = "qcom,rpmcc-ipq806x", .data = &rpm_clk_ipq806x },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, rpm_clk_match_table);
diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h
index 8e3095720552..ae74c43c485d 100644
--- a/include/dt-bindings/clock/qcom,rpmcc.h
+++ b/include/dt-bindings/clock/qcom,rpmcc.h
@@ -37,6 +37,10 @@
 #define RPM_XO_A0				27
 #define RPM_XO_A1				28
 #define RPM_XO_A2				29
+#define RPM_NSS_FABRIC_0_CLK			30
+#define RPM_NSS_FABRIC_0_A_CLK			31
+#define RPM_NSS_FABRIC_1_CLK			32
+#define RPM_NSS_FABRIC_1_A_CLK			33
 
 /* SMD RPM clocks */
 #define RPM_SMD_XO_CLK_SRC				0
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
  2020-03-10 14:37 [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x Ansuel Smith
@ 2020-03-10 18:41 ` Rob Herring
  2020-03-11 12:46   ` R: " ansuelsmth
  2020-03-13 20:57 ` Stephen Boyd
  1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2020-03-10 18:41 UTC (permalink / raw)
  To: Ansuel Smith
  Cc: sboyd, Ansuel Smith, John Crispin, Andy Gross, Bjorn Andersson,
	Michael Turquette, Mark Rutland, linux-arm-msm, linux-clk,
	devicetree, linux-kernel

On Tue, 10 Mar 2020 15:37:56 +0100, Ansuel Smith wrote:
> Add missing definition of rpm clk for ipq806x soc
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Acked-by: John Crispin <john@phrozen.org>
> ---
>  .../devicetree/bindings/clock/qcom,rpmcc.txt  |  1 +
>  drivers/clk/qcom/clk-rpm.c                    | 35 +++++++++++++++++++
>  include/dt-bindings/clock/qcom,rpmcc.h        |  4 +++
>  3 files changed, 40 insertions(+)
> 

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* R: [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
  2020-03-10 18:41 ` Rob Herring
@ 2020-03-11 12:46   ` ansuelsmth
  0 siblings, 0 replies; 7+ messages in thread
From: ansuelsmth @ 2020-03-11 12:46 UTC (permalink / raw)
  To: 'Rob Herring'
  Cc: sboyd, 'John Crispin', 'Andy Gross',
	'Bjorn Andersson', 'Michael Turquette',
	'Mark Rutland',
	linux-arm-msm, linux-clk, devicetree, linux-kernel

> On Tue, 10 Mar 2020 15:37:56 +0100, Ansuel Smith wrote:
> > Add missing definition of rpm clk for ipq806x soc
> >
> > Signed-off-by: John Crispin <john@phrozen.org>
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > Acked-by: John Crispin <john@phrozen.org>
> > ---
> >  .../devicetree/bindings/clock/qcom,rpmcc.txt  |  1 +
> >  drivers/clk/qcom/clk-rpm.c                    | 35 +++++++++++++++++++
> >  include/dt-bindings/clock/qcom,rpmcc.h        |  4 +++
> >  3 files changed, 40 insertions(+)
> >
> 
> Please add Acked-by/Reviewed-by tags when posting new versions.
> However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.

Sorry it was asked to resend this as there was a bug in the software used to
apply this. 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
  2020-03-10 14:37 [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x Ansuel Smith
  2020-03-10 18:41 ` Rob Herring
@ 2020-03-13 20:57 ` Stephen Boyd
  1 sibling, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2020-03-13 20:57 UTC (permalink / raw)
  To: Ansuel Smith
  Cc: Ansuel Smith, John Crispin, Andy Gross, Bjorn Andersson,
	Michael Turquette, Rob Herring, Mark Rutland, linux-arm-msm,
	linux-clk, devicetree, linux-kernel

Quoting Ansuel Smith (2020-03-10 07:37:56)
> Add missing definition of rpm clk for ipq806x soc
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Acked-by: John Crispin <john@phrozen.org>
> ---

Applied to clk-next and added Rob's review tag from v1. Please help and
do it next time.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
  2020-03-03 14:59   ` Rob Herring
@ 2020-03-09 21:12     ` Stephen Boyd
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2020-03-09 21:12 UTC (permalink / raw)
  To: Ansuel Smith, Rob Herring
  Cc: Ansuel Smith, John Crispin, Andy Gross, Bjorn Andersson,
	Michael Turquette, Mark Rutland, linux-arm-msm, linux-clk,
	devicetree, linux-kernel

Quoting Rob Herring (2020-03-03 06:59:20)
> On Wed, 26 Feb 2020 22:48:12 +0100, Ansuel Smith wrote:
> > Add missing definition of rpm clk for ipq806x soc
> > 
> > Signed-off-by: John Crispin <john@phrozen.org>
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > Acked-by: John Crispin <john@phrozen.org>
> > ---
> >  .../devicetree/bindings/clock/qcom,rpmcc.txt  |  1 +
> >  drivers/clk/qcom/clk-rpm.c                    | 35 +++++++++++++++++++
> >  include/dt-bindings/clock/qcom,rpmcc.h        |  4 +++
> >  3 files changed, 40 insertions(+)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

Ansuel, can you send this again and address it To: somebody like me? My
MUA fails at getting emails when they're addressed to nobody.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
  2020-02-26 21:48 ` Ansuel Smith
@ 2020-03-03 14:59   ` Rob Herring
  2020-03-09 21:12     ` Stephen Boyd
  0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2020-03-03 14:59 UTC (permalink / raw)
  To: Ansuel Smith
  Cc: Ansuel Smith, John Crispin, Andy Gross, Bjorn Andersson,
	Michael Turquette, Stephen Boyd, Mark Rutland, linux-arm-msm,
	linux-clk, devicetree, linux-kernel

On Wed, 26 Feb 2020 22:48:12 +0100, Ansuel Smith wrote:
> Add missing definition of rpm clk for ipq806x soc
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Acked-by: John Crispin <john@phrozen.org>
> ---
>  .../devicetree/bindings/clock/qcom,rpmcc.txt  |  1 +
>  drivers/clk/qcom/clk-rpm.c                    | 35 +++++++++++++++++++
>  include/dt-bindings/clock/qcom,rpmcc.h        |  4 +++
>  3 files changed, 40 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x
       [not found] <robh@kernel.org>
@ 2020-02-26 21:48 ` Ansuel Smith
  2020-03-03 14:59   ` Rob Herring
  0 siblings, 1 reply; 7+ messages in thread
From: Ansuel Smith @ 2020-02-26 21:48 UTC (permalink / raw)
  Cc: Ansuel Smith, John Crispin, Andy Gross, Bjorn Andersson,
	Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland,
	linux-arm-msm, linux-clk, devicetree, linux-kernel

Add missing definition of rpm clk for ipq806x soc

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: John Crispin <john@phrozen.org>
---
 .../devicetree/bindings/clock/qcom,rpmcc.txt  |  1 +
 drivers/clk/qcom/clk-rpm.c                    | 35 +++++++++++++++++++
 include/dt-bindings/clock/qcom,rpmcc.h        |  4 +++
 3 files changed, 40 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
index 944719bd586f..4bb2cbeff2b4 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt
@@ -15,6 +15,7 @@ Required properties :
 			"qcom,rpmcc-msm8916", "qcom,rpmcc"
 			"qcom,rpmcc-msm8974", "qcom,rpmcc"
 			"qcom,rpmcc-apq8064", "qcom,rpmcc"
+			"qcom,rpmcc-ipq806x", "qcom,rpmcc"
 			"qcom,rpmcc-msm8996", "qcom,rpmcc"
 			"qcom,rpmcc-msm8998", "qcom,rpmcc"
 			"qcom,rpmcc-qcs404", "qcom,rpmcc"
diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index 9e3110a71f12..f71d228fd6bd 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b/drivers/clk/qcom/clk-rpm.c
@@ -543,10 +543,45 @@ static const struct rpm_clk_desc rpm_clk_apq8064 = {
 	.num_clks = ARRAY_SIZE(apq8064_clks),
 };
 
+/* ipq806x */
+DEFINE_CLK_RPM(ipq806x, afab_clk, afab_a_clk, QCOM_RPM_APPS_FABRIC_CLK);
+DEFINE_CLK_RPM(ipq806x, cfpb_clk, cfpb_a_clk, QCOM_RPM_CFPB_CLK);
+DEFINE_CLK_RPM(ipq806x, daytona_clk, daytona_a_clk, QCOM_RPM_DAYTONA_FABRIC_CLK);
+DEFINE_CLK_RPM(ipq806x, ebi1_clk, ebi1_a_clk, QCOM_RPM_EBI1_CLK);
+DEFINE_CLK_RPM(ipq806x, sfab_clk, sfab_a_clk, QCOM_RPM_SYS_FABRIC_CLK);
+DEFINE_CLK_RPM(ipq806x, sfpb_clk, sfpb_a_clk, QCOM_RPM_SFPB_CLK);
+DEFINE_CLK_RPM(ipq806x, nss_fabric_0_clk, nss_fabric_0_a_clk, QCOM_RPM_NSS_FABRIC_0_CLK);
+DEFINE_CLK_RPM(ipq806x, nss_fabric_1_clk, nss_fabric_1_a_clk, QCOM_RPM_NSS_FABRIC_1_CLK);
+
+static struct clk_rpm *ipq806x_clks[] = {
+	[RPM_APPS_FABRIC_CLK] = &ipq806x_afab_clk,
+	[RPM_APPS_FABRIC_A_CLK] = &ipq806x_afab_a_clk,
+	[RPM_CFPB_CLK] = &ipq806x_cfpb_clk,
+	[RPM_CFPB_A_CLK] = &ipq806x_cfpb_a_clk,
+	[RPM_DAYTONA_FABRIC_CLK] = &ipq806x_daytona_clk,
+	[RPM_DAYTONA_FABRIC_A_CLK] = &ipq806x_daytona_a_clk,
+	[RPM_EBI1_CLK] = &ipq806x_ebi1_clk,
+	[RPM_EBI1_A_CLK] = &ipq806x_ebi1_a_clk,
+	[RPM_SYS_FABRIC_CLK] = &ipq806x_sfab_clk,
+	[RPM_SYS_FABRIC_A_CLK] = &ipq806x_sfab_a_clk,
+	[RPM_SFPB_CLK] = &ipq806x_sfpb_clk,
+	[RPM_SFPB_A_CLK] = &ipq806x_sfpb_a_clk,
+	[RPM_NSS_FABRIC_0_CLK] = &ipq806x_nss_fabric_0_clk,
+	[RPM_NSS_FABRIC_0_A_CLK] = &ipq806x_nss_fabric_0_a_clk,
+	[RPM_NSS_FABRIC_1_CLK] = &ipq806x_nss_fabric_1_clk,
+	[RPM_NSS_FABRIC_1_A_CLK] = &ipq806x_nss_fabric_1_a_clk,
+};
+
+static const struct rpm_clk_desc rpm_clk_ipq806x = {
+	.clks = ipq806x_clks,
+	.num_clks = ARRAY_SIZE(ipq806x_clks),
+};
+
 static const struct of_device_id rpm_clk_match_table[] = {
 	{ .compatible = "qcom,rpmcc-msm8660", .data = &rpm_clk_msm8660 },
 	{ .compatible = "qcom,rpmcc-apq8060", .data = &rpm_clk_msm8660 },
 	{ .compatible = "qcom,rpmcc-apq8064", .data = &rpm_clk_apq8064 },
+	{ .compatible = "qcom,rpmcc-ipq806x", .data = &rpm_clk_ipq806x },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, rpm_clk_match_table);
diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h
index 8e3095720552..ae74c43c485d 100644
--- a/include/dt-bindings/clock/qcom,rpmcc.h
+++ b/include/dt-bindings/clock/qcom,rpmcc.h
@@ -37,6 +37,10 @@
 #define RPM_XO_A0				27
 #define RPM_XO_A1				28
 #define RPM_XO_A2				29
+#define RPM_NSS_FABRIC_0_CLK			30
+#define RPM_NSS_FABRIC_0_A_CLK			31
+#define RPM_NSS_FABRIC_1_CLK			32
+#define RPM_NSS_FABRIC_1_A_CLK			33
 
 /* SMD RPM clocks */
 #define RPM_SMD_XO_CLK_SRC				0
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-13 20:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 14:37 [PATCH v2] clk: qcom: clk-rpm: add missing rpm clk for ipq806x Ansuel Smith
2020-03-10 18:41 ` Rob Herring
2020-03-11 12:46   ` R: " ansuelsmth
2020-03-13 20:57 ` Stephen Boyd
     [not found] <robh@kernel.org>
2020-02-26 21:48 ` Ansuel Smith
2020-03-03 14:59   ` Rob Herring
2020-03-09 21:12     ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).