From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
smohanad@codeaurora.org, kvalo@codeaurora.org,
bjorn.andersson@linaro.org, hemantk@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] bus: mhi: core: Add support for reading MHI info from device
Date: Tue, 24 Mar 2020 11:04:58 +0530 [thread overview]
Message-ID: <20200324053458.GB11834@Mani-XPS-13-9360> (raw)
In-Reply-To: <c6b696ed-b9cf-98ed-7402-9fb82bcab1c6@codeaurora.org>
On Mon, Mar 23, 2020 at 08:14:07AM -0600, Jeffrey Hugo wrote:
> On 3/23/2020 6:30 AM, Manivannan Sadhasivam wrote:
> > The MHI register base has several registers used for getting the MHI
> > specific information such as version, family, major, and minor numbers
> > from the device. This information can be used by the controller drivers
> > for usecases such as applying quirks for a specific revision etc...
> >
> > While at it, let's also rearrange the local variables
> > in mhi_register_controller().
> >
> > Suggested-by: Hemant Kumar <hemantk@codeaurora.org>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > --- a/include/linux/mhi.h
> > +++ b/include/linux/mhi.h
> > @@ -310,6 +310,10 @@ struct mhi_controller_config {
> > * @sw_ev_rings: Number of software event rings
> > * @nr_irqs_req: Number of IRQs required to operate (optional)
> > * @nr_irqs: Number of IRQ allocated by bus master (required)
> > + * @family_number: MHI controller family number
> > + * @device_number: MHI controller device number
> > + * @major_version: MHI controller major revision number
> > + * @minor_version: MHI controller minor revision number
>
> Maybe expand the comment to indicate there are valid after register() to
> give controller implementations an idea of when they can use these for
> quirks, etc?
>
Hmm, Okay. Will add a note in next revision.
Thanks,
Mani
> > * @mhi_event: MHI event ring configurations table
> > * @mhi_cmd: MHI command ring configurations table
> > * @mhi_ctxt: MHI device context, shared memory between host and device
> > @@ -375,6 +379,10 @@ struct mhi_controller {
> > u32 sw_ev_rings;
> > u32 nr_irqs_req;
> > u32 nr_irqs;
> > + u32 family_number;
> > + u32 device_number;
> > + u32 major_version;
> > + u32 minor_version;
> > struct mhi_event *mhi_event;
> > struct mhi_cmd *mhi_cmd;
> >
>
>
> --
> Jeffrey Hugo
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-03-24 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 12:30 [PATCH v2 0/7] Improvements to MHI Bus Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 1/7] bus: mhi: core: Pass module owner during client driver registration Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 2/7] bus: mhi: core: Add support for reading MHI info from device Manivannan Sadhasivam
2020-03-23 14:14 ` Jeffrey Hugo
2020-03-24 5:34 ` Manivannan Sadhasivam [this message]
2020-03-23 12:30 ` [PATCH v2 3/7] bus: mhi: core: Initialize bhie field in mhi_cntrl for RDDM capture Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 4/7] bus: mhi: core: Drop the references to mhi_dev in mhi_destroy_device() Manivannan Sadhasivam
2020-03-23 12:31 ` [PATCH v2 5/7] bus: mhi: core: Add support for MHI suspend and resume Manivannan Sadhasivam
2020-03-23 12:31 ` [PATCH v2 6/7] net: qrtr: Add MHI transport layer Manivannan Sadhasivam
2020-03-23 12:31 ` [PATCH v2 7/7] net: qrtr: Do not depend on ARCH_QCOM Manivannan Sadhasivam
2020-03-23 16:30 ` Kalle Valo
2020-03-24 5:33 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324053458.GB11834@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smohanad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).