Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	gregkh@linuxfoundation.org, davem@davemloft.net
Cc: smohanad@codeaurora.org, kvalo@codeaurora.org,
	bjorn.andersson@linaro.org, hemantk@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] bus: mhi: core: Add support for reading MHI info from device
Date: Mon, 23 Mar 2020 08:14:07 -0600
Message-ID: <c6b696ed-b9cf-98ed-7402-9fb82bcab1c6@codeaurora.org> (raw)
In-Reply-To: <20200323123102.13992-3-manivannan.sadhasivam@linaro.org>

On 3/23/2020 6:30 AM, Manivannan Sadhasivam wrote:
> The MHI register base has several registers used for getting the MHI
> specific information such as version, family, major, and minor numbers
> from the device. This information can be used by the controller drivers
> for usecases such as applying quirks for a specific revision etc...
> 
> While at it, let's also rearrange the local variables
> in mhi_register_controller().
> 
> Suggested-by: Hemant Kumar <hemantk@codeaurora.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -310,6 +310,10 @@ struct mhi_controller_config {
>    * @sw_ev_rings: Number of software event rings
>    * @nr_irqs_req: Number of IRQs required to operate (optional)
>    * @nr_irqs: Number of IRQ allocated by bus master (required)
> + * @family_number: MHI controller family number
> + * @device_number: MHI controller device number
> + * @major_version: MHI controller major revision number
> + * @minor_version: MHI controller minor revision number

Maybe expand the comment to indicate there are valid after register() to 
give controller implementations an idea of when they can use these for 
quirks, etc?

>    * @mhi_event: MHI event ring configurations table
>    * @mhi_cmd: MHI command ring configurations table
>    * @mhi_ctxt: MHI device context, shared memory between host and device
> @@ -375,6 +379,10 @@ struct mhi_controller {
>   	u32 sw_ev_rings;
>   	u32 nr_irqs_req;
>   	u32 nr_irqs;
> +	u32 family_number;
> +	u32 device_number;
> +	u32 major_version;
> +	u32 minor_version;
>   
>   	struct mhi_event *mhi_event;
>   	struct mhi_cmd *mhi_cmd;
> 


-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 12:30 [PATCH v2 0/7] Improvements to MHI Bus Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 1/7] bus: mhi: core: Pass module owner during client driver registration Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 2/7] bus: mhi: core: Add support for reading MHI info from device Manivannan Sadhasivam
2020-03-23 14:14   ` Jeffrey Hugo [this message]
2020-03-24  5:34     ` Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 3/7] bus: mhi: core: Initialize bhie field in mhi_cntrl for RDDM capture Manivannan Sadhasivam
2020-03-23 12:30 ` [PATCH v2 4/7] bus: mhi: core: Drop the references to mhi_dev in mhi_destroy_device() Manivannan Sadhasivam
2020-03-23 12:31 ` [PATCH v2 5/7] bus: mhi: core: Add support for MHI suspend and resume Manivannan Sadhasivam
2020-03-23 12:31 ` [PATCH v2 6/7] net: qrtr: Add MHI transport layer Manivannan Sadhasivam
2020-03-23 12:31 ` [PATCH v2 7/7] net: qrtr: Do not depend on ARCH_QCOM Manivannan Sadhasivam
2020-03-23 16:30   ` Kalle Valo
2020-03-24  5:33     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6b696ed-b9cf-98ed-7402-9fb82bcab1c6@codeaurora.org \
    --to=jhugo@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hemantk@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=smohanad@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git