* [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs
@ 2020-04-28 0:01 Bjorn Andersson
2020-04-28 0:01 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs Bjorn Andersson
2020-04-28 10:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Sibi Sankar
0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-04-28 0:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ohad Ben-Cohen, Rob Herring
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Rishabh Bhatnagar, Sibi Sankar
Add the SM8250 audio, compute and sensor remoteprocs to the PAS DT
binding.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
.../devicetree/bindings/remoteproc/qcom,adsp.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
index 9938918b2fea..49ec30454198 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
@@ -21,6 +21,9 @@ on the Qualcomm ADSP Hexagon core.
"qcom,sm8150-cdsp-pas"
"qcom,sm8150-mpss-pas"
"qcom,sm8150-slpi-pas"
+ "qcom,sm8250-adsp-pas"
+ "qcom,sm8250-cdsp-pas"
+ "qcom,sm8250-slpi-pas"
- interrupts-extended:
Usage: required
@@ -44,6 +47,9 @@ on the Qualcomm ADSP Hexagon core.
qcom,sm8150-adsp-pas:
qcom,sm8150-cdsp-pas:
qcom,sm8150-slpi-pas:
+ qcom,sm8250-adsp-pas:
+ qcom,sm8250-cdsp-pas:
+ qcom,sm8250-slpi-pas:
must be "wdog", "fatal", "ready", "handover", "stop-ack"
qcom,qcs404-wcss-pas:
qcom,sm8150-mpss-pas:
@@ -105,10 +111,13 @@ on the Qualcomm ADSP Hexagon core.
qcom,sdm845-cdsp-pas:
qcom,sm8150-adsp-pas:
qcom,sm8150-cdsp-pas:
+ qcom,sm8250-adsp-pas:
+ qcom,sm8250-cdsp-pas:
must be "cx", "load_state"
qcom,sm8150-mpss-pas:
must be "cx", "load_state", "mss"
qcom,sm8150-slpi-pas:
+ qcom,sm8250-slpi-pas:
must be "lcx", "lmx", "load_state"
- memory-region:
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs
2020-04-28 0:01 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Bjorn Andersson
@ 2020-04-28 0:01 ` Bjorn Andersson
2020-04-28 10:31 ` Sibi Sankar
2020-04-28 10:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Sibi Sankar
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2020-04-28 0:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ohad Ben-Cohen, Rob Herring
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Rishabh Bhatnagar, Sibi Sankar
Add audio, compute and sensor DSP compatibles to the Qualcomm PAS
binding and driver.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/remoteproc/qcom_q6v5_pas.c | 62 ++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 8ecc157f1ed1..5f2266c74448 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -508,6 +508,26 @@ static const struct adsp_data sm8150_adsp_resource = {
.ssctl_id = 0x14,
};
+static const struct adsp_data sm8250_adsp_resource = {
+ .crash_reason_smem = 423,
+ .firmware_name = "adsp.mdt",
+ .pas_id = 1,
+ .has_aggre2_clk = false,
+ .auto_boot = true,
+ .active_pd_names = (char*[]){
+ "load_state",
+ NULL
+ },
+ .proxy_pd_names = (char*[]){
+ "cx",
+ "mx",
+ NULL
+ },
+ .ssr_name = "lpass",
+ .sysmon_name = "adsp",
+ .ssctl_id = 0x14,
+};
+
static const struct adsp_data msm8998_adsp_resource = {
.crash_reason_smem = 423,
.firmware_name = "adsp.mdt",
@@ -553,6 +573,25 @@ static const struct adsp_data sm8150_cdsp_resource = {
.ssctl_id = 0x17,
};
+static const struct adsp_data sm8250_cdsp_resource = {
+ .crash_reason_smem = 601,
+ .firmware_name = "cdsp.mdt",
+ .pas_id = 18,
+ .has_aggre2_clk = false,
+ .auto_boot = true,
+ .active_pd_names = (char*[]){
+ "load_state",
+ NULL
+ },
+ .proxy_pd_names = (char*[]){
+ "cx",
+ NULL
+ },
+ .ssr_name = "cdsp",
+ .sysmon_name = "cdsp",
+ .ssctl_id = 0x17,
+};
+
static const struct adsp_data mpss_resource_init = {
.crash_reason_smem = 421,
.firmware_name = "modem.mdt",
@@ -604,6 +643,26 @@ static const struct adsp_data sm8150_slpi_resource = {
.ssctl_id = 0x16,
};
+static const struct adsp_data sm8250_slpi_resource = {
+ .crash_reason_smem = 424,
+ .firmware_name = "slpi.mdt",
+ .pas_id = 12,
+ .has_aggre2_clk = false,
+ .auto_boot = true,
+ .active_pd_names = (char*[]){
+ "load_state",
+ NULL
+ },
+ .proxy_pd_names = (char*[]){
+ "lcx",
+ "lmx",
+ NULL
+ },
+ .ssr_name = "dsps",
+ .sysmon_name = "slpi",
+ .ssctl_id = 0x16,
+};
+
static const struct adsp_data msm8998_slpi_resource = {
.crash_reason_smem = 424,
.firmware_name = "slpi.mdt",
@@ -644,6 +703,9 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},
{ .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
{ .compatible = "qcom,sm8150-slpi-pas", .data = &sm8150_slpi_resource},
+ { .compatible = "qcom,sm8250-adsp-pas", .data = &sm8250_adsp_resource},
+ { .compatible = "qcom,sm8250-cdsp-pas", .data = &sm8250_cdsp_resource},
+ { .compatible = "qcom,sm8250-slpi-pas", .data = &sm8250_slpi_resource},
{ },
};
MODULE_DEVICE_TABLE(of, adsp_of_match);
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs
2020-04-28 0:01 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Bjorn Andersson
2020-04-28 0:01 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs Bjorn Andersson
@ 2020-04-28 10:25 ` Sibi Sankar
1 sibling, 0 replies; 4+ messages in thread
From: Sibi Sankar @ 2020-04-28 10:25 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Ohad Ben-Cohen, Rob Herring, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, Rishabh Bhatnagar
Hey Bjorn,
On 2020-04-28 05:31, Bjorn Andersson wrote:
> Add the SM8250 audio, compute and sensor remoteprocs to the PAS DT
> binding.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../devicetree/bindings/remoteproc/qcom,adsp.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 9938918b2fea..49ec30454198 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -21,6 +21,9 @@ on the Qualcomm ADSP Hexagon core.
> "qcom,sm8150-cdsp-pas"
> "qcom,sm8150-mpss-pas"
> "qcom,sm8150-slpi-pas"
> + "qcom,sm8250-adsp-pas"
> + "qcom,sm8250-cdsp-pas"
> + "qcom,sm8250-slpi-pas"
>
> - interrupts-extended:
> Usage: required
> @@ -44,6 +47,9 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> qcom,sm8150-slpi-pas:
> + qcom,sm8250-adsp-pas:
> + qcom,sm8250-cdsp-pas:
> + qcom,sm8250-slpi-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack"
> qcom,qcs404-wcss-pas:
> qcom,sm8150-mpss-pas:
> @@ -105,10 +111,13 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sdm845-cdsp-pas:
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> + qcom,sm8250-adsp-pas:
Looks like adsp also uses lcx and lmx
similar to slpi, the rest looks good
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> + qcom,sm8250-cdsp-pas:
> must be "cx", "load_state"
> qcom,sm8150-mpss-pas:
> must be "cx", "load_state", "mss"
> qcom,sm8150-slpi-pas:
> + qcom,sm8250-slpi-pas:
> must be "lcx", "lmx", "load_state"
>
> - memory-region:
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs
2020-04-28 0:01 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs Bjorn Andersson
@ 2020-04-28 10:31 ` Sibi Sankar
0 siblings, 0 replies; 4+ messages in thread
From: Sibi Sankar @ 2020-04-28 10:31 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Ohad Ben-Cohen, Rob Herring, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, Rishabh Bhatnagar,
linux-kernel-owner
Hey Bjorn,
On 2020-04-28 05:31, Bjorn Andersson wrote:
> Add audio, compute and sensor DSP compatibles to the Qualcomm PAS
> binding and driver.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 62 ++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
> b/drivers/remoteproc/qcom_q6v5_pas.c
> index 8ecc157f1ed1..5f2266c74448 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -508,6 +508,26 @@ static const struct adsp_data sm8150_adsp_resource
> = {
> .ssctl_id = 0x14,
> };
>
> +static const struct adsp_data sm8250_adsp_resource = {
> + .crash_reason_smem = 423,
> + .firmware_name = "adsp.mdt",
> + .pas_id = 1,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .active_pd_names = (char*[]){
> + "load_state",
> + NULL
> + },
> + .proxy_pd_names = (char*[]){
> + "cx",
> + "mx",
you may want to name it as lcx, lmx.
The remaining looks good!
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> + NULL
> + },
> + .ssr_name = "lpass",
> + .sysmon_name = "adsp",
> + .ssctl_id = 0x14,
> +};
> +
> static const struct adsp_data msm8998_adsp_resource = {
> .crash_reason_smem = 423,
> .firmware_name = "adsp.mdt",
> @@ -553,6 +573,25 @@ static const struct adsp_data sm8150_cdsp_resource
> = {
> .ssctl_id = 0x17,
> };
>
> +static const struct adsp_data sm8250_cdsp_resource = {
> + .crash_reason_smem = 601,
> + .firmware_name = "cdsp.mdt",
> + .pas_id = 18,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .active_pd_names = (char*[]){
> + "load_state",
> + NULL
> + },
> + .proxy_pd_names = (char*[]){
> + "cx",
> + NULL
> + },
> + .ssr_name = "cdsp",
> + .sysmon_name = "cdsp",
> + .ssctl_id = 0x17,
> +};
> +
> static const struct adsp_data mpss_resource_init = {
> .crash_reason_smem = 421,
> .firmware_name = "modem.mdt",
> @@ -604,6 +643,26 @@ static const struct adsp_data sm8150_slpi_resource
> = {
> .ssctl_id = 0x16,
> };
>
> +static const struct adsp_data sm8250_slpi_resource = {
> + .crash_reason_smem = 424,
> + .firmware_name = "slpi.mdt",
> + .pas_id = 12,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .active_pd_names = (char*[]){
> + "load_state",
> + NULL
> + },
> + .proxy_pd_names = (char*[]){
> + "lcx",
> + "lmx",
> + NULL
> + },
> + .ssr_name = "dsps",
> + .sysmon_name = "slpi",
> + .ssctl_id = 0x16,
> +};
> +
> static const struct adsp_data msm8998_slpi_resource = {
> .crash_reason_smem = 424,
> .firmware_name = "slpi.mdt",
> @@ -644,6 +703,9 @@ static const struct of_device_id adsp_of_match[] =
> {
> { .compatible = "qcom,sm8150-cdsp-pas", .data =
> &sm8150_cdsp_resource},
> { .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
> { .compatible = "qcom,sm8150-slpi-pas", .data =
> &sm8150_slpi_resource},
> + { .compatible = "qcom,sm8250-adsp-pas", .data =
> &sm8250_adsp_resource},
> + { .compatible = "qcom,sm8250-cdsp-pas", .data =
> &sm8250_cdsp_resource},
> + { .compatible = "qcom,sm8250-slpi-pas", .data =
> &sm8250_slpi_resource},
> { },
> };
> MODULE_DEVICE_TABLE(of, adsp_of_match);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-28 10:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 0:01 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Bjorn Andersson
2020-04-28 0:01 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs Bjorn Andersson
2020-04-28 10:31 ` Sibi Sankar
2020-04-28 10:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Sibi Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).