* [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level
@ 2020-05-28 11:03 Zijun Hu
2020-05-28 15:17 ` Matthias Kaehlcke
0 siblings, 1 reply; 4+ messages in thread
From: Zijun Hu @ 2020-05-28 11:03 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar, c-hbandi,
hemantg, mka, rjliao, zijuhu
Controller ID info got by VSC EDL_PATCH_GETVER is very
important, so improve its log level from DEBUG to INFO.
Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
---
drivers/bluetooth/btqca.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 3ea866d..6193030 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
ver = (struct qca_btsoc_version *)(edl->data);
- BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
- BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
- BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
- BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
+ bt_dev_info(hdev, "QCA Product ID :0x%08x",
+ le32_to_cpu(ver->product_id));
+ bt_dev_info(hdev, "QCA SOC Version :0x%08x",
+ le32_to_cpu(ver->soc_id));
+ bt_dev_info(hdev, "QCA ROM Version :0x%08x",
+ le16_to_cpu(ver->rom_ver));
+ bt_dev_info(hdev, "QCA Patch Version:0x%08x",
+ le16_to_cpu(ver->patch_ver));
/* QCA chipset version can be decided by patch and SoC
* version, combination with upper 2 bytes from SoC
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level
2020-05-28 11:03 [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level Zijun Hu
@ 2020-05-28 15:17 ` Matthias Kaehlcke
2020-05-28 19:42 ` Zijun Hu
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Kaehlcke @ 2020-05-28 15:17 UTC (permalink / raw)
To: Zijun Hu
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth,
linux-arm-msm, bgodavar, c-hbandi, hemantg, rjliao
On Thu, May 28, 2020 at 07:03:17PM +0800, Zijun Hu wrote:
> Controller ID info got by VSC EDL_PATCH_GETVER is very
> important, so improve its log level from DEBUG to INFO.
>
> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
Please add the tags from earlier version unless the new patch has
substantial changes.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level
2020-05-28 15:17 ` Matthias Kaehlcke
@ 2020-05-28 19:42 ` Zijun Hu
2020-05-28 20:36 ` Matthias Kaehlcke
0 siblings, 1 reply; 4+ messages in thread
From: Zijun Hu @ 2020-05-28 19:42 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth,
linux-arm-msm, bgodavar, c-hbandi, hemantg, rjliao
On 5/28/2020 11:17 PM, Matthias Kaehlcke wrote:
> On Thu, May 28, 2020 at 07:03:17PM +0800, Zijun Hu wrote:
>> Controller ID info got by VSC EDL_PATCH_GETVER is very
>> important, so improve its log level from DEBUG to INFO.
>>
>> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
>
> Please add the tags from earlier version unless the new patch has
> substantial changes.
>
actually, this v3 patch is only to correct the code stye issue pointed
by you. let me resend it.
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level
2020-05-28 19:42 ` Zijun Hu
@ 2020-05-28 20:36 ` Matthias Kaehlcke
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2020-05-28 20:36 UTC (permalink / raw)
To: Zijun Hu
Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth,
linux-arm-msm, bgodavar, c-hbandi, hemantg, rjliao
On Fri, May 29, 2020 at 03:42:54AM +0800, Zijun Hu wrote:
>
>
> On 5/28/2020 11:17 PM, Matthias Kaehlcke wrote:
> > On Thu, May 28, 2020 at 07:03:17PM +0800, Zijun Hu wrote:
> >> Controller ID info got by VSC EDL_PATCH_GETVER is very
> >> important, so improve its log level from DEBUG to INFO.
> >>
> >> Signed-off-by: Zijun Hu <zijuhu@codeaurora.org>
> >
> > Please add the tags from earlier version unless the new patch has
> > substantial changes.
> >
> actually, this v3 patch is only to correct the code stye issue pointed
> by you. let me resend it.
no need to resend it, it was just a reminder to do it in the futre.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-28 20:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 11:03 [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level Zijun Hu
2020-05-28 15:17 ` Matthias Kaehlcke
2020-05-28 19:42 ` Zijun Hu
2020-05-28 20:36 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).