From: Mayank Grover <groverm@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Neeraj Upadhyay <neeraju@codeaurora.org>
Subject: Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid
Date: Tue, 2 Jun 2020 17:56:00 +0530 [thread overview]
Message-ID: <20200602122600.GA10584@codeaurora.org> (raw)
In-Reply-To: <CACRpkdbSsVcy=6Bo42SnPqgKoa+jNanmBEXix_yv6aNK8VcreQ@mail.gmail.com>
On Mon, May 25, 2020 at 11:02:14AM +0200, Linus Walleij wrote:
> On Tue, May 19, 2020 at 3:39 AM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>
> > @Linus, we started off with something similar for GPIOs and ended up
> > with the logic in the core code. Should we somehow try to do the same
> > for pinctrl?
>
> msm_pingroup_is_valid() looks very reusable but I'm afraid I do not
> understand the implicit assumptions around it, but I guess yes,
> if it can be properly documented etc.
>
> Yours,
> Linus Walleij
Hi Bjorn,
Can you please help guide further on this ?
we can validate group using request calls similar to pinmux_ops here.
-Mayank
prev parent reply other threads:[~2020-06-02 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 15:50 [PATCH] pinctrl: msm: Add check for pinctrl group is valid Mayank Grover
2020-05-19 1:38 ` Bjorn Andersson
2020-05-19 11:31 ` Mayank Grover
2020-05-25 9:02 ` Linus Walleij
2020-06-02 12:26 ` Mayank Grover [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602122600.GA10584@codeaurora.org \
--to=groverm@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraju@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).