* [PATCH] dt-bindings: hwlock: qcom: Remove invalid binding
@ 2020-07-29 0:47 Bjorn Andersson
2020-07-31 17:53 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2020-07-29 0:47 UTC (permalink / raw)
To: Bjorn Andersson, Ohad Ben-Cohen, Baolin Wang, Rob Herring
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
The Qualcomm hwlock is described in DeviceTree either directly on the
mmio bus or split between a syscon and a mutex node, but as noted in
[1] the latter is not valid DT, so remove any traces of this from the
binding.
[1] https://lore.kernel.org/r/CAL_JsqLa9GBtbgN6aL7AQ=A6V-YRtPgYqh6XgM2kpx532+r4Gg@mail.gmail.com/
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
.../bindings/hwlock/qcom-hwspinlock.yaml | 25 +------------------
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
index 88f975837588..1c7149f7d171 100644
--- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
@@ -25,37 +25,14 @@ properties:
'#hwlock-cells':
const: 1
- syscon:
- $ref: "/schemas/types.yaml#/definitions/phandle-array"
- description:
- Should be a triple of phandle referencing the TCSR mutex syscon, offset
- of first mutex within the syscon and stride between each mutex.
-
required:
- compatible
+ - reg
- '#hwlock-cells'
-oneOf:
- - required:
- - reg
- - required:
- - syscon
-
additionalProperties: false
examples:
- - |
- tcsr_mutex_block: syscon@fd484000 {
- compatible = "syscon";
- reg = <0xfd484000 0x2000>;
- };
-
- hwlock {
- compatible = "qcom,tcsr-mutex";
- syscon = <&tcsr_mutex_block 0 0x80>;
-
- #hwlock-cells = <1>;
- };
- |
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: hwlock: qcom: Remove invalid binding
2020-07-29 0:47 [PATCH] dt-bindings: hwlock: qcom: Remove invalid binding Bjorn Andersson
@ 2020-07-31 17:53 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-07-31 17:53 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ohad Ben-Cohen, Baolin Wang, linux-arm-msm,
open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM, devicetree,
linux-kernel
On Tue, Jul 28, 2020 at 6:48 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> The Qualcomm hwlock is described in DeviceTree either directly on the
> mmio bus or split between a syscon and a mutex node, but as noted in
> [1] the latter is not valid DT, so remove any traces of this from the
> binding.
>
> [1] https://lore.kernel.org/r/CAL_JsqLa9GBtbgN6aL7AQ=A6V-YRtPgYqh6XgM2kpx532+r4Gg@mail.gmail.com/
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../bindings/hwlock/qcom-hwspinlock.yaml | 25 +------------------
> 1 file changed, 1 insertion(+), 24 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-31 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 0:47 [PATCH] dt-bindings: hwlock: qcom: Remove invalid binding Bjorn Andersson
2020-07-31 17:53 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).