* [PATCH -next] phy: qualcomm: fix return value check in qcom_ipq806x_usb_phy_probe()
@ 2020-07-23 11:36 Wei Yongjun
2020-08-05 6:28 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-23 11:36 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul,
Ansuel Smith
Cc: Wei Yongjun, linux-arm-msm, kernel-janitors, Hulk Robot
In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.
Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
index 71f257b4a7f5..092fd2d9c3f3 100644
--- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
@@ -505,9 +505,9 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
size = resource_size(res);
phy_dwc3->base = devm_ioremap(phy_dwc3->dev, res->start, size);
- if (IS_ERR(phy_dwc3->base)) {
+ if (!phy_dwc3->base) {
dev_err(phy_dwc3->dev, "failed to map reg\n");
- return PTR_ERR(phy_dwc3->base);
+ return -ENOMEM;
}
phy_dwc3->ref_clk = devm_clk_get(phy_dwc3->dev, "ref");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] phy: qualcomm: fix return value check in qcom_ipq806x_usb_phy_probe()
2020-07-23 11:36 [PATCH -next] phy: qualcomm: fix return value check in qcom_ipq806x_usb_phy_probe() Wei Yongjun
@ 2020-08-05 6:28 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-08-05 6:28 UTC (permalink / raw)
To: Wei Yongjun
Cc: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I,
Ansuel Smith, linux-arm-msm, kernel-janitors, Hulk Robot
On 23-07-20, 11:36, Wei Yongjun wrote:
> In case of error, the function devm_ioremap() returns NULL pointer not
> ERR_PTR(). The IS_ERR() test in the return value check should be
> replaced with NULL test.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-05 6:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 11:36 [PATCH -next] phy: qualcomm: fix return value check in qcom_ipq806x_usb_phy_probe() Wei Yongjun
2020-08-05 6:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).